From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20382 invoked by alias); 13 May 2013 06:06:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20344 invoked by uid 89); 13 May 2013 06:06:09 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-oa0-f52.google.com (HELO mail-oa0-f52.google.com) (209.85.219.52) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 13 May 2013 06:05:50 +0000 Received: by mail-oa0-f52.google.com with SMTP id h1so7173954oag.11 for ; Sun, 12 May 2013 23:05:49 -0700 (PDT) X-Received: by 10.60.84.33 with SMTP id v1mr11656516oey.36.1368425149281; Sun, 12 May 2013 23:05:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Sun, 12 May 2013 23:05:09 -0700 (PDT) In-Reply-To: References: <51665508.5050706@mentor.com> <516655FC.6070206@mentor.com> <51666686.7090203@codesourcery.com> <516668F3.3030405@mentor.com> <5166722F.2000709@codesourcery.com> From: Hui Zhu Date: Mon, 13 May 2013 06:06:00 -0000 Message-ID: Subject: Re: [PATCH] store trace default-collect to target [6/6] test To: gdb-patches ml Cc: Hui Zhu , Yao Qi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-05/txt/msg00421.txt.bz2 Ping http://sourceware.org/ml/gdb-patches/2013-04/msg00455.html Thanks, Hui On Tue, Apr 16, 2013 at 5:32 PM, Hui Zhu wrote: > Hi Yao, > > Thanks for your review. > > On Thu, Apr 11, 2013 at 4:19 PM, Yao Qi wrote: >> On 04/11/2013 03:40 PM, Hui Zhu wrote: >>> >>> --- a/testsuite/gdb.trace/tstatus.exp >>> +++ b/testsuite/gdb.trace/tstatus.exp >>> @@ -137,6 +137,8 @@ proc test_tracepoints {} { >>> >>> test_tracepoints >>> >>> +gdb_test_no_output "set default-collect \$regs" >>> + >>> set tracefile [standard_output_file ${testfile}] >>> # Save trace frames to tfile. >>> gdb_test "tsave ${tracefile}.tf" \ >>> @@ -147,6 +149,8 @@ gdb_test "tsave -ctf ${tracefile}.ctf" \ >>> "Trace data saved to directory '${tracefile}.ctf'.*" \ >>> "save ctf trace file" >>> >>> +gdb_test_no_output "set default-collect" >>> + >>> # Change target to tfile. >>> set test "change to tfile target" >>> gdb_test_multiple "target tfile ${tracefile}.tf" "$test" { >>> @@ -159,6 +163,8 @@ gdb_test_multiple "target tfile ${tracef >>> } >>> } >>> >>> +gdb_test "show default-collect" "The list of expressions to collect by >>> default is \"\\\$regs\".*" >>> + >>> # Convert "(because I can) to "\(because I can\)" >>> set tstatus_output [string map {\( \\(} $tstatus_output] >>> set tstatus_output [string map {\) \\)} $tstatus_output] >> >> >> I am afraid that tstatus.exp is not a good place to test "default-collec= t". >> The tstatus.exp is to test the output of command 'tstatus' in various >> situations, and also test that the output of 'tstatus' command on tfile >> target is identical to its output on the ctf target. Probably, actions.= exp >> is better, IMO. > > Move it to actions.exp > > Post a new version for it. > > Best, > Hui > > 2013-04-16 Hui Zhu > > * gdb.trace/disconnected-tracing.exp (disconnected_tracing): Add > test for default-collect. > * gdb.trace/actions.exp: Add test for default-collect. > >> >> -- >> Yao (=E9=BD=90=E5=B0=A7)