From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9094 invoked by alias); 10 Dec 2012 10:57:12 -0000 Received: (qmail 9046 invoked by uid 22791); 10 Dec 2012 10:57:11 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-bk0-f41.google.com (HELO mail-bk0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Dec 2012 10:57:02 +0000 Received: by mail-bk0-f41.google.com with SMTP id jg9so1099010bkc.0 for ; Mon, 10 Dec 2012 02:57:00 -0800 (PST) Received: by 10.204.156.11 with SMTP id u11mr4284558bkw.106.1355137020867; Mon, 10 Dec 2012 02:57:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.205.32.12 with HTTP; Mon, 10 Dec 2012 02:56:20 -0800 (PST) In-Reply-To: <87lid9x6hl.fsf@fleche.redhat.com> References: <87txryx36w.fsf@fleche.redhat.com> <87lid9x6hl.fsf@fleche.redhat.com> From: Hui Zhu Date: Mon, 10 Dec 2012 10:57:00 -0000 Message-ID: Subject: Re: [PATCH] Add fseek to ui-file To: Tom Tromey Cc: gdb-patches ml , Hui Zhu Content-Type: multipart/mixed; boundary=0015175d02d2c034f304d07d6c70 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00229.txt.bz2 --0015175d02d2c034f304d07d6c70 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 861 On Fri, Dec 7, 2012 at 10:49 PM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> And I found all other set_ui_file_xxx functions have this issue, do > Hui> you mind I post a patch to update them? > > I think it would be fine. > > Tom Post a patch for that. Please help me review it. Thanks, Hui 2012-12-10 Hui Zhu * ui-file.c (set_ui_file_flush): Change flush to flush_p. (set_ui_file_isatty): Change isatty to isatty_p. (set_ui_file_rewind): Change rewind to rewind_p. (set_ui_file_put): Change put to put_p. (set_ui_file_write): Change write to write_p. (set_ui_file_write_async_safe): Change write_async_safe to write_async_safe_p. (set_ui_file_read): Change read to read_p. (set_ui_file_fputs): Change fputs to fputs_p. (set_ui_file_data): Change delete to delete_p. --0015175d02d2c034f304d07d6c70 Content-Type: text/plain; charset=US-ASCII; name="ui-file-change-arg.txt" Content-Disposition: attachment; filename="ui-file-change-arg.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hajhkbuq0 Content-length: 2888 LS0tIGEvdWktZmlsZS5jCisrKyBiL3VpLWZpbGUuYwpAQCAtMjM0LDYxICsy MzQsNjEgQEAgZnB1dHNfdW5maWx0ZXJlZCAoY29uc3QgY2hhciAqYnVmLCBz dHJ1YwogfQogCiB2b2lkCi1zZXRfdWlfZmlsZV9mbHVzaCAoc3RydWN0IHVp X2ZpbGUgKmZpbGUsIHVpX2ZpbGVfZmx1c2hfZnR5cGUgKmZsdXNoKQorc2V0 X3VpX2ZpbGVfZmx1c2ggKHN0cnVjdCB1aV9maWxlICpmaWxlLCB1aV9maWxl X2ZsdXNoX2Z0eXBlICpmbHVzaF9wKQogewotICBmaWxlLT50b19mbHVzaCA9 IGZsdXNoOworICBmaWxlLT50b19mbHVzaCA9IGZsdXNoX3A7CiB9CiAKIHZv aWQKLXNldF91aV9maWxlX2lzYXR0eSAoc3RydWN0IHVpX2ZpbGUgKmZpbGUs IHVpX2ZpbGVfaXNhdHR5X2Z0eXBlICppc2F0dHkpCitzZXRfdWlfZmlsZV9p c2F0dHkgKHN0cnVjdCB1aV9maWxlICpmaWxlLCB1aV9maWxlX2lzYXR0eV9m dHlwZSAqaXNhdHR5X3ApCiB7Ci0gIGZpbGUtPnRvX2lzYXR0eSA9IGlzYXR0 eTsKKyAgZmlsZS0+dG9faXNhdHR5ID0gaXNhdHR5X3A7CiB9CiAKIHZvaWQK LXNldF91aV9maWxlX3Jld2luZCAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHVp X2ZpbGVfcmV3aW5kX2Z0eXBlICpyZXdpbmQpCitzZXRfdWlfZmlsZV9yZXdp bmQgKHN0cnVjdCB1aV9maWxlICpmaWxlLCB1aV9maWxlX3Jld2luZF9mdHlw ZSAqcmV3aW5kX3ApCiB7Ci0gIGZpbGUtPnRvX3Jld2luZCA9IHJld2luZDsK KyAgZmlsZS0+dG9fcmV3aW5kID0gcmV3aW5kX3A7CiB9CiAKIHZvaWQKLXNl dF91aV9maWxlX3B1dCAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHVpX2ZpbGVf cHV0X2Z0eXBlICpwdXQpCitzZXRfdWlfZmlsZV9wdXQgKHN0cnVjdCB1aV9m aWxlICpmaWxlLCB1aV9maWxlX3B1dF9mdHlwZSAqcHV0X3ApCiB7Ci0gIGZp bGUtPnRvX3B1dCA9IHB1dDsKKyAgZmlsZS0+dG9fcHV0ID0gcHV0X3A7CiB9 CiAKIHZvaWQKIHNldF91aV9maWxlX3dyaXRlIChzdHJ1Y3QgdWlfZmlsZSAq ZmlsZSwKLQkJICAgIHVpX2ZpbGVfd3JpdGVfZnR5cGUgKndyaXRlKQorCQkg ICAgdWlfZmlsZV93cml0ZV9mdHlwZSAqd3JpdGVfcCkKIHsKLSAgZmlsZS0+ dG9fd3JpdGUgPSB3cml0ZTsKKyAgZmlsZS0+dG9fd3JpdGUgPSB3cml0ZV9w OwogfQogCiB2b2lkCiBzZXRfdWlfZmlsZV93cml0ZV9hc3luY19zYWZlIChz dHJ1Y3QgdWlfZmlsZSAqZmlsZSwKLQkJCSAgICAgIHVpX2ZpbGVfd3JpdGVf YXN5bmNfc2FmZV9mdHlwZSAqd3JpdGVfYXN5bmNfc2FmZSkKKwkJCSAgICAg IHVpX2ZpbGVfd3JpdGVfYXN5bmNfc2FmZV9mdHlwZSAqd3JpdGVfYXN5bmNf c2FmZV9wKQogewotICBmaWxlLT50b193cml0ZV9hc3luY19zYWZlID0gd3Jp dGVfYXN5bmNfc2FmZTsKKyAgZmlsZS0+dG9fd3JpdGVfYXN5bmNfc2FmZSA9 IHdyaXRlX2FzeW5jX3NhZmVfcDsKIH0KIAogdm9pZAotc2V0X3VpX2ZpbGVf cmVhZCAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHVpX2ZpbGVfcmVhZF9mdHlw ZSAqcmVhZCkKK3NldF91aV9maWxlX3JlYWQgKHN0cnVjdCB1aV9maWxlICpm aWxlLCB1aV9maWxlX3JlYWRfZnR5cGUgKnJlYWRfcCkKIHsKLSAgZmlsZS0+ dG9fcmVhZCA9IHJlYWQ7CisgIGZpbGUtPnRvX3JlYWQgPSByZWFkX3A7CiB9 CiAKIHZvaWQKLXNldF91aV9maWxlX2ZwdXRzIChzdHJ1Y3QgdWlfZmlsZSAq ZmlsZSwgdWlfZmlsZV9mcHV0c19mdHlwZSAqZnB1dHMpCitzZXRfdWlfZmls ZV9mcHV0cyAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHVpX2ZpbGVfZnB1dHNf ZnR5cGUgKmZwdXRzX3ApCiB7Ci0gIGZpbGUtPnRvX2ZwdXRzID0gZnB1dHM7 CisgIGZpbGUtPnRvX2ZwdXRzID0gZnB1dHNfcDsKIH0KIAogdm9pZAogc2V0 X3VpX2ZpbGVfZGF0YSAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHZvaWQgKmRh dGEsCi0JCSAgdWlfZmlsZV9kZWxldGVfZnR5cGUgKmRlbGV0ZSkKKwkJICB1 aV9maWxlX2RlbGV0ZV9mdHlwZSAqZGVsZXRlX3ApCiB7CiAgIGZpbGUtPnRv X2RhdGEgPSBkYXRhOwotICBmaWxlLT50b19kZWxldGUgPSBkZWxldGU7Cisg IGZpbGUtPnRvX2RlbGV0ZSA9IGRlbGV0ZV9wOwogfQogCiAvKiB1aV9maWxl IHV0aWxpdHkgZnVuY3Rpb24gZm9yIGNvbnZlcnRpbmcgYSBgYHN0cnVjdCB1 aV9maWxlJycgaW50bwo= --0015175d02d2c034f304d07d6c70--