From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32095 invoked by alias); 11 May 2013 05:55:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32046 invoked by uid 89); 11 May 2013 05:55:04 -0000 X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-oa0-f52.google.com (HELO mail-oa0-f52.google.com) (209.85.219.52) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 11 May 2013 05:55:03 +0000 Received: by mail-oa0-f52.google.com with SMTP id h1so5668202oag.39 for ; Fri, 10 May 2013 22:55:02 -0700 (PDT) X-Received: by 10.60.79.198 with SMTP id l6mr8387651oex.47.1368251702229; Fri, 10 May 2013 22:55:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Fri, 10 May 2013 22:54:22 -0700 (PDT) From: Hui Zhu Date: Sat, 11 May 2013 05:55:00 -0000 Message-ID: Subject: [PATCH] Fix bug 15433 - GDB crashes when using agent dprintf, %s format, and an in-line string To: gdb-patches ml Content-Type: multipart/mixed; boundary=089e0118289eacc1a104dc6aec83 X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00404.txt.bz2 --089e0118289eacc1a104dc6aec83 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 633 Hi, This issue is because GDB doesn't OP_STRING now. So parse_cmd_to_aexpr will got NULL if using agent dprintf, %s format, and an in-line string. And this NULL will be push to bl->target_info.tcommands. Then it make remote part crash. So add a check in build_target_command_list for the return of parse_cmd_to_aexpr. And add a test for it. Thanks, Hui 2013-05-11 Hui Zhu PR gdb/15433 * breakpoint.c (build_target_command_list): Add check for the return of parse_cmd_to_aexpr. 2013-05-11 Hui Zhu PR gdb/15433 * gdb.base/dprintf.exp: Test unsupport commands on target. --089e0118289eacc1a104dc6aec83 Content-Type: text/plain; charset=US-ASCII; name="dprintf-cmd-not-support.txt" Content-Disposition: attachment; filename="dprintf-cmd-not-support.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hgkdp21z0 Content-length: 578 LS0tIGEvZ2RiL2JyZWFrcG9pbnQuYworKysgYi9nZGIvYnJlYWtwb2ludC5j CkBAIC0yMzAyLDYgKzIzMDIsOSBAQCBidWlsZF90YXJnZXRfY29tbWFuZF9s aXN0IChzdHJ1Y3QgYnBfbG9jCiAJCSBuZWVkIHRvIHBhcnNlIHRoZSBjb21t YW5kIHRvIGJ5dGVjb2RlcyBhZ2Fpbi4gICovCiAJICAgICAgYWV4cHIgPSBw YXJzZV9jbWRfdG9fYWV4cHIgKGJsLT5hZGRyZXNzLAogCQkJCQkgIGxvYy0+ b3duZXItPmV4dHJhX3N0cmluZyk7CisJICAgICAgaWYgKGFleHByID09IE5V TEwpCisJCWVycm9yIChfKCJBZ2VudCBpcyBub3Qgc3VwcG9ydCBjb21tYW5k cyBvZiBicmVha3BvaW50ICVkLiIpLAorCQkgICAgICAgYmwtPm93bmVyLT5u dW1iZXIpOwogCSAgICAgIGxvYy0+Y21kX2J5dGVjb2RlID0gYWV4cHI7CiAK IAkgICAgICBpZiAoIWFleHByKQo= --089e0118289eacc1a104dc6aec83 Content-Type: text/plain; charset=US-ASCII; name="dprintf-cmd-not-support-test.txt" Content-Disposition: attachment; filename="dprintf-cmd-not-support-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hgkdpawn1 Content-length: 716 LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9kcHJpbnRmLmV4cAorKysg Yi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2RwcmludGYuZXhwCkBAIC0xMzEs NiArMTMxLDExIEBAIGlmICR0YXJnZXRfY2FuX2RwcmludGYgewogCSJcW1xy XG5cXVx0YnJlYWtwb2ludCBhbHJlYWR5IGhpdCAyIHRpbWVzIgogCSJcW1xy XG5cXSAgICAgICAgYWdlbnQtcHJpbnRmIFwiYXJnPSVkLCBnPSVkXFxcXG5c IiwgYXJnLCBnIgogICAgIH0KKworICAgICMgVGVzdCB1bnN1cHBvcnQgY29t bWFuZHMuCisgICAgZ2RiX3Rlc3QgImRwcmludGYgJGRwX2xvY2F0aW9uMSxc IiVzXFxuXCIsIFwidGVzdFwiIiAiRHByaW50ZiAuKiIKKyAgICBnZGJfdGVz dCAiY29udGludWUiICJBZ2VudCBpcyBub3Qgc3VwcG9ydCBjb21tYW5kcyBv ZiBicmVha3BvaW50IC4qIiBcCisgICAgICAiM3JkIGRwcmludGYsIGFnZW50 IgogfQogCiBnZGJfdGVzdCAic2V0IGRwcmludGYtc3R5bGUgZm9vYmFyIiAi VW5kZWZpbmVkIGl0ZW06IFwiZm9vYmFyXCIuIiBcCg== --089e0118289eacc1a104dc6aec83--