From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5609 invoked by alias); 18 Jun 2012 14:22:41 -0000 Received: (qmail 5600 invoked by uid 22791); 18 Jun 2012 14:22:40 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_YM X-Spam-Check-By: sourceware.org Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Jun 2012 14:22:15 +0000 Received: by wgbdr1 with SMTP id dr1so4218461wgb.12 for ; Mon, 18 Jun 2012 07:22:14 -0700 (PDT) Received: by 10.180.78.161 with SMTP id c1mr24601383wix.1.1340029333785; Mon, 18 Jun 2012 07:22:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.122.193 with HTTP; Mon, 18 Jun 2012 07:21:33 -0700 (PDT) In-Reply-To: References: <4FD0AF8C.2040908@codesourcery.com> <4FDEF3C3.6090100@codesourcery.com> From: Hui Zhu Date: Mon, 18 Jun 2012 14:22:00 -0000 Message-ID: Subject: Re: [PATCH] Makefile.in includes linux-record.c to be common for all arch. (arm-reversible>phase-3) To: oza Pawandeep Cc: Yao Qi , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00579.txt.bz2 On Mon, Jun 18, 2012 at 7:49 PM, oza Pawandeep wr= ote: > Yes I agree; as I integrated both of them and post them at once. > sorry about confusion; this patch has to be ignored. > > In fact I wanted this patch to be approved first because without which > sys call patch would not compile. Why you cannot commit a patch list when the function is done? I think the function in the trunk tree need be done before commit to it. If you want work in cvs, I suggest you use the branch first. On the other hand, I heard that some of code of arm record is checked in. I don't think it is right. Because without syscall support, it cannot work, right? So what I suggest is move all the code about arm record to a separate branch. And when all of the arm record function done, you re-send all of them. Thanks, Hui > > Regards, > Oza. > > On Mon, Jun 18, 2012 at 2:54 PM, Yao Qi wrote: >> On 06/18/2012 05:08 PM, oza Pawandeep wrote: >>> diff -urN orig/configure.tgt new/configure.tgt >>> --- orig/configure.tgt =C2=A0 =C2=A0 =C2=A0 =C2=A02012-06-18 12:36:47.2= 74501400 +0530 >>> +++ new/configure.tgt 2012-06-18 12:31:47.335501400 +0530 >>> @@ -76,7 +76,7 @@ >>> =C2=A0arm*-*-linux*) >>> =C2=A0 =C2=A0 =C2=A0 # Target: ARM based machine running GNU/Linux >>> =C2=A0 =C2=A0 =C2=A0 gdb_target_obs=3D"arm-tdep.o arm-linux-tdep.o glib= c-tdep.o \ >>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= solib-svr4.o symfile-mem.o linux-tdep.o" >>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= solib-svr4.o symfile-mem.o linux-tdep.o linux-record.o" >>> =C2=A0 =C2=A0 =C2=A0 build_gdbserver=3Dyes >>> =C2=A0 =C2=A0 =C2=A0 ;; >>> =C2=A0arm*-*-netbsd* | arm*-*-knetbsd*-gnu) >>> >>> ok to check in ? >> >> It is not good to post the same change twice in different mails. =C2=A0T= his >> change makes no sense until your 'arm-syscall record' patch is approved. >> =C2=A0I noticed that this change has been included in your 'arm-syscall >> record' patch, so I think patch here doesn't have to reviewed. >> >> -- >> Yao (=E9=BD=90=E5=B0=A7) >> >>