From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2726 invoked by alias); 17 Jun 2013 07:48:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2716 invoked by uid 89); 17 Jun 2013 07:48:00 -0000 X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ob0-f178.google.com (HELO mail-ob0-f178.google.com) (209.85.214.178) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 17 Jun 2013 07:47:59 +0000 Received: by mail-ob0-f178.google.com with SMTP id fb19so2838393obc.9 for ; Mon, 17 Jun 2013 00:47:57 -0700 (PDT) X-Received: by 10.60.54.194 with SMTP id l2mr7981615oep.52.1371455277761; Mon, 17 Jun 2013 00:47:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.137.196 with HTTP; Mon, 17 Jun 2013 00:47:17 -0700 (PDT) From: Hui Zhu Date: Mon, 17 Jun 2013 10:12:00 -0000 Message-ID: Subject: [PATCH] fix PR 15180 "May only run agent-printf on the target" To: gdb-patches ml Content-Type: multipart/mixed; boundary=089e011841c8a80d5d04df54d0c6 X-Virus-Found: No X-SW-Source: 2013-06/txt/msg00369.txt.bz2 --089e011841c8a80d5d04df54d0c6 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 643 Hi, This patch is for PR 15180 too. Because it depends on patch in http://sourceware.org/ml/gdb-patches/2013-06/msg00139.html So I post it in another thread. It make dprintf_after_condition_true doesn't do actions if dprintf style is agent. Because the actions is already did in agent. The test patch test the issue about 15180. Thanks, Hui 2013-06-17 Hui Zhu PR gdb/15180 * breakpoint.c (dprintf_after_condition_true): Check dprintf style before do actions. 2013-06-17 Hui Zhu PR gdb/15180 * gdb.base/dprintf-same-addr.c: New file. * gdb.base/dprintf-same-addr.exp: New file. --089e011841c8a80d5d04df54d0c6 Content-Type: text/plain; charset=US-ASCII; name="dprintf-same-addr.txt" Content-Disposition: attachment; filename="dprintf-same-addr.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hi1d0vsl0 Content-length: 964 LS0tIGEvZ2RiL2JyZWFrcG9pbnQuYworKysgYi9nZGIvYnJlYWtwb2ludC5j CkBAIC0xMzQ2NSw3ICsxMzQ2NSwxMiBAQCBkcHJpbnRmX2FmdGVyX2NvbmRp dGlvbl90cnVlIChzdHJ1Y3QgYnBzCiAgIGJzLT5jb21tYW5kcyA9IE5VTEw7 CiAgIG9sZF9jaGFpbiA9IG1ha2VfY2xlYW51cF9kZWNyZWZfY291bnRlZF9j b21tYW5kX2xpbmUgKCZ0bXBfYnMuY29tbWFuZHMpOwogCi0gIGJwc3RhdF9k b19hY3Rpb25zXzEgKCZ0bXBfYnNfcCk7CisgIC8qIElmIGRwcmludGYtc3R5 bGUgaXMgc2V0IHRvIGFnZW50LCB0aGUgYWN0aW9ucyBvZiBkcHJpbnRmIGhh cyBiZWVuCisgICAgIGV4ZWN1dGVkIGluIGFnZW50LiAgVGhleSBzaG91bGQg bm90IGJlIGV4ZWN1ZWQgaW4gR0RCIHNpZGUuCisgICAgIFNvIHRoZSBhY3Rp b25zIHNob3VsZCBiZSBleGVjdXRlZCBvbmx5IHdoZW4gZHByaW50Zi1zdHls ZSBpcyBub3QKKyAgICAgc2V0IHRvIGFnZW50LiAgKi8KKyAgaWYgKHN0cmNt cCAoZHByaW50Zl9zdHlsZSwgZHByaW50Zl9zdHlsZV9hZ2VudCkgIT0gMCkK KyAgICBicHN0YXRfZG9fYWN0aW9uc18xICgmdG1wX2JzX3ApOwogCiAgIC8q ICd0bXBfYnMuY29tbWFuZHMnIHdpbGwgdXN1YWxseSBiZSBOVUxMIGJ5IG5v dywgYnV0CiAgICAgIGJwc3RhdF9kb19hY3Rpb25zXzEgbWF5IHJldHVybiBl YXJseSB3aXRob3V0IHByb2Nlc3NpbmcgdGhlIHdob2xlCg== --089e011841c8a80d5d04df54d0c6 Content-Type: text/plain; charset=US-ASCII; name="dprintf-same-addr-test.txt" Content-Disposition: attachment; filename="dprintf-same-addr-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hi1d140r1 Content-length: 5072 LS0tIC9kZXYvbnVsbAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2Rw cmludGYtc2FtZS1hZGRyLmMKQEAgLTAsMCArMSwzNSBAQAorLyogVGhpcyB0 ZXN0Y2FzZSBpcyBwYXJ0IG9mIEdEQiwgdGhlIEdOVSBkZWJ1Z2dlci4KKwor ICAgQ29weXJpZ2h0IChDKSAyMDEzIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv biwgSW5jLgorICAgQ29udHJpYnV0ZWQgYnkgSHVpIFpodSAgPGh1aUBjb2Rl c291cmNlcnkuY29tPgorCisgICBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0 d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQor ICAgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyAgIHRoZSBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vu c2UsIG9yCisgICAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9u LgorCisgICBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhv cGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAgIGJ1dCBXSVRIT1VUIEFO WSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5 IG9mCisgICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisgICBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCisgICBZb3Ugc2hvdWxk IGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZQorICAgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBu b3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwor CisjaW5jbHVkZSA8c3RkaW8uaD4KKworaW50CittYWluICgpCit7CisgIGlu dCBpOworCisgIGZvciAoaT0wOyBpIDwgOTk7IGkrKykKKyAgICB7CisgICAg ICBwcmludGYoIkhlbGxvXG4iKTsJLyogdGVzdCBsaW5lICAqLworCisgICAg ICAvKiBXaXRob3V0IHRoaXMgbGluZSwgdGVzdCB3aXRoIGZwcmludGYgd2ls bCBub3Qgd29yay4gICovCisgICAgICBmcHJpbnRmIChzdGRlcnIsICJ3b3Js ZFxuIik7CisgICAgfQorCisgIHJldHVybiAwOworfQotLS0gL2Rldi9udWxs CisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvZHByaW50Zi1zYW1lLWFk ZHIuZXhwCkBAIC0wLDAgKzEsODIgQEAKKyMgICBDb3B5cmlnaHQgKEMpIDIw MTMgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisjICAgQ29udHJp YnV0ZWQgYnkgSHVpIFpodSAgPGh1aUBjb2Rlc291cmNlcnkuY29tPgorCisj IFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlz dHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJt cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlz aGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhl ciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9w dGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBp cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsLAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkg b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhl CisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFp bHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGgg dGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9y Zy9saWNlbnNlcy8+LgorCitzdGFuZGFyZF90ZXN0ZmlsZQorCitpZiBbcHJl cGFyZV9mb3JfdGVzdGluZyAiZmFpbGVkIHRvIHByZXBhcmUgZm9yIGRwcmlu dGYgd2l0aCBub24tc3RvcCIgXAorICAgICR7dGVzdGZpbGV9ICR7c3JjZmls ZX0ge2RlYnVnfV0geworICAgIHJldHVybiAtMQorfQorCitzZXQgYnBfbG9j YXRpb24gW2dkYl9nZXRfbGluZV9udW1iZXIgInRlc3QgbGluZSJdCisKK3By b2MgY29udGludWVfZHByaW50ZiB7YXJnc30geworICAgIHdpdGhfdGVzdF9w cmVmaXggJGFyZ3MgeworCWdsb2JhbCBicF9sb2NhdGlvbgorCisJZ2RiX3Rl c3QgImRwcmludGYgJGJwX2xvY2F0aW9uLFwiSGVsbG9cXG5cIiIgIkRwcmlu dGYgLioiCisJZ2RiX3Rlc3Rfbm9fb3V0cHV0IHtzZXQgJGJwbnVtMT0kYnBu dW19CisJZ2RiX2JyZWFrcG9pbnQgJGJwX2xvY2F0aW9uCisJZ2RiX3Rlc3Rf bm9fb3V0cHV0IHtzZXQgJGJwbnVtMj0kYnBudW19CisKKwlnZGJfdGVzdCAi Y29udGludWUiICJCcmVha3BvaW50IFxbMC05XF0rLCBtYWluIC4qIiAiRmly c3QgY29udGludWUiCisKKwlnZGJfdGVzdF9ub19vdXRwdXQgImNvbmRpdGlv biBcJGJwbnVtMSBpPjEwIgorCWdkYl90ZXN0X25vX291dHB1dCAiY29uZGl0 aW9uIFwkYnBudW0yIGk+MTUiCisKKwlnZGJfdGVzdCAiY29udGludWUiICJC cmVha3BvaW50IFxbMC05XF0rLCBtYWluIC4qIiAiU2Vjb25kIGNvbnRpbnVl IgorCisJZ2RiX3Rlc3QgInAgaSIgIlxbMC05XF0rID0gMTYiICJjaGVjayBp IgorICAgIH0KK30KKworaWYgIVtydW50byBtYWluXSB7CisgICAgcmV0dXJu IC0xCit9CitnZGJfdGVzdF9ub19vdXRwdXQgInNldCBkcHJpbnRmLXN0eWxl IGdkYiIgIlNldCBkcHJpbnRmIHN0eWxlIHRvIGdkYiIKK2NvbnRpbnVlX2Rw cmludGYgImdkYiIKKworaWYgIVt0YXJnZXRfaW5mbyBleGlzdHMgZ2RiLG5v aW5mZXJpb3Jpb10geworICAgIGlmICFbcnVudG8gbWFpbl0geworCXJldHVy biAtMQorICAgIH0KKyAgICBnZGJfdGVzdF9ub19vdXRwdXQgInNldCBkcHJp bnRmLXN0eWxlIGNhbGwiICJTZXQgZHByaW50ZiBzdHlsZSB0byBjYWxsIgor ICAgIGNvbnRpbnVlX2RwcmludGYgImNhbGwiCisKKyAgICBpZiAhW3J1bnRv IG1haW5dIHsKKwlyZXR1cm4gLTEKKyAgICB9CisgICAgZ2RiX3Rlc3Rfbm9f b3V0cHV0ICJzZXQgZHByaW50Zi1mdW5jdGlvbiBmcHJpbnRmIiAic2V0IGRw cmludGYtY2hhbm5lbCBzdGRlcnIiCisgICAgZ2RiX3Rlc3Rfbm9fb3V0cHV0 ICJzZXQgZHByaW50Zi1jaGFubmVsIHN0ZGVyciIgInNldCBkcHJpbnRmIGNo YW5uZWwiCisgICAgY29udGludWVfZHByaW50ZiAiZnByaW50ZiIKK30gZWxz ZSB7CisgICAgdW5zdXBwb3J0ZWQgInRlc3QgZHByaW50Zi1zdHlsZSBjYWxs IgorfQorCitpZiAhW3J1bnRvIG1haW5dIHsKKyAgICByZXR1cm4gLTEKK30K K2dkYl90ZXN0ICJkcHJpbnRmIG1haW4sXCJIZWxsb1xcblwiIiAiRHByaW50 ZiAuKiIKK3NldCBtc2cgIlNldCBkcHJpbnRmIHN0eWxlIHRvIGFnZW50Igor Z2RiX3Rlc3RfbXVsdGlwbGUgInNldCBkcHJpbnRmLXN0eWxlIGFnZW50IiAk bXNnIHsKKyAgICAtcmUgIndhcm5pbmc6IFRhcmdldCBjYW5ub3QgcnVuIGRw cmludGYgY29tbWFuZHMuKlxyXG4kZ2RiX3Byb21wdCAkIiB7CisJdW5zdXBw b3J0ZWQgJG1zZworICAgIH0KKyAgICAtcmUgIi4qJGdkYl9wcm9tcHQgJCIg eworCXBhc3MgJG1zZworCWNvbnRpbnVlX2RwcmludGYgImFnZW50IgorICAg IH0KK30K --089e011841c8a80d5d04df54d0c6--