From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12045 invoked by alias); 21 Apr 2013 11:07:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12036 invoked by uid 89); 21 Apr 2013 11:07:18 -0000 X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-oa0-f45.google.com (HELO mail-oa0-f45.google.com) (209.85.219.45) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 21 Apr 2013 11:07:17 +0000 Received: by mail-oa0-f45.google.com with SMTP id o17so5052272oag.32 for ; Sun, 21 Apr 2013 04:07:16 -0700 (PDT) X-Received: by 10.182.79.165 with SMTP id k5mr11646669obx.24.1366542436222; Sun, 21 Apr 2013 04:07:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Sun, 21 Apr 2013 04:06:36 -0700 (PDT) From: Hui Zhu Date: Mon, 22 Apr 2013 09:22:00 -0000 Message-ID: Subject: [PATCH] Fix bug 15181 Missing continue on dprintf that defaults to "gdb" style from "agent" To: gdb-patches ml Cc: Marc Khouzam Content-Type: multipart/mixed; boundary=089e01293f867b513b04dadcf4ba X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00647.txt.bz2 --089e01293f867b513b04dadcf4ba Content-Type: text/plain; charset=ISO-8859-1 Content-length: 487 Hi, This patch is from Marc to fix http://sourceware.org/bugzilla/show_bug.cgi?id=15181 I add a test for it. Please help me review it. Thanks, Hui 2013-04-21 Marc Khouzam PR gdb/15181 * breakpoint.c (update_dprintf_command_list): Add "continue" to command list if target cannot run dprintf commands. 2013-04-21 Hui Zhu PR gdb/15181 * gdb.base/dprintf.exp: Test dprintf commands if target cannot run dprintf commands. --089e01293f867b513b04dadcf4ba Content-Type: text/plain; charset=US-ASCII; name="dprintf-miss-continue.txt" Content-Disposition: attachment; filename="dprintf-miss-continue.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfs41h150 Content-length: 1200 LS0tIGEvZ2RiL2JyZWFrcG9pbnQuYworKysgYi9nZGIvYnJlYWtwb2ludC5j CkBAIC04OTEwLDYgKzg5MTAsNyBAQCB1cGRhdGVfZHByaW50Zl9jb21tYW5k X2xpc3QgKHN0cnVjdCBicmVhCiB7CiAgIGNoYXIgKmRwcmludGZfYXJncyA9 IGItPmV4dHJhX3N0cmluZzsKICAgY2hhciAqcHJpbnRmX2xpbmUgPSBOVUxM OworICBpbnQgbmVlZF9jb250aW51ZSA9IDA7CiAKICAgaWYgKCFkcHJpbnRm X2FyZ3MpCiAgICAgcmV0dXJuOwpAQCAtODk1MCw2ICs4OTUxLDcgQEAgdXBk YXRlX2RwcmludGZfY29tbWFuZF9saXN0IChzdHJ1Y3QgYnJlYQogCXsKIAkg IHdhcm5pbmcgKF8oIlRhcmdldCBjYW5ub3QgcnVuIGRwcmludGYgY29tbWFu ZHMsIGZhbGxpbmcgYmFjayB0byBHREIgcHJpbnRmIikpOwogCSAgcHJpbnRm X2xpbmUgPSB4c3RycHJpbnRmICgicHJpbnRmICVzIiwgZHByaW50Zl9hcmdz KTsKKwkgIG5lZWRfY29udGludWUgPSAxOwogCX0KICAgICB9CiAgIGVsc2UK QEAgLTg5NjEsNyArODk2Myw4IEBAIHVwZGF0ZV9kcHJpbnRmX2NvbW1hbmRf bGlzdCAoc3RydWN0IGJyZWEKICAgewogICAgIHN0cnVjdCBjb21tYW5kX2xp bmUgKnByaW50Zl9jbWRfbGluZSwgKmNvbnRfY21kX2xpbmUgPSBOVUxMOwog Ci0gICAgaWYgKHN0cmNtcCAoZHByaW50Zl9zdHlsZSwgZHByaW50Zl9zdHls ZV9hZ2VudCkgIT0gMCkKKyAgICBpZiAoc3RyY21wIChkcHJpbnRmX3N0eWxl LCBkcHJpbnRmX3N0eWxlX2FnZW50KSAhPSAwCisJfHwgbmVlZF9jb250aW51 ZSkKICAgICAgIHsKIAljb250X2NtZF9saW5lID0geG1hbGxvYyAoc2l6ZW9m IChzdHJ1Y3QgY29tbWFuZF9saW5lKSk7CiAJY29udF9jbWRfbGluZS0+Y29u dHJvbF90eXBlID0gc2ltcGxlX2NvbnRyb2w7Cg== --089e01293f867b513b04dadcf4ba Content-Type: text/plain; charset=US-ASCII; name="dprintf-miss-continue-test.txt" Content-Disposition: attachment; filename="dprintf-miss-continue-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfs41pb61 Content-length: 863 LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9kcHJpbnRmLmV4cAorKysg Yi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2RwcmludGYuZXhwCkBAIC0xMjks NiArMTI5LDE3IEBAIGlmICR0YXJnZXRfY2FuX2RwcmludGYgewogCSJcW1xy XG5cXVx0YnJlYWtwb2ludCBhbHJlYWR5IGhpdCAyIHRpbWVzIgogCSJcW1xy XG5cXSAgICAgICAgYWdlbnQtcHJpbnRmIFwiYXJnPSVkLCBnPSVkXFxcXG5c IiwgYXJnLCBnIgogICAgIH0KK30gZWxzZSB7CisgICAgZGVsZXRlX2JyZWFr cG9pbnRzCisKKyAgICBnZGJfdGVzdCAiZHByaW50ZiBmb28sXCJIZWxsb1xc blwiIiBcCisJIkRwcmludGYgLioiCisgICAgZ2RiX3Rlc3Rfc2VxdWVuY2Ug ImluZm8gYnJlYWtwb2ludHMiICJkcHJpbnRmIGluZm8gMyIgeworCSJcW1xy XG5cXU51bSAgICAgVHlwZSAgICAgICAgICAgRGlzcCBFbmIgQWRkcmVzcyAr V2hhdCIKKwkiXFtcclxuXF02ICAgICAgIGRwcmludGYiCisJIlxbXHJcblxd ICAgICAgICBwcmludGYgXCJIZWxsb1xcXFxuXCIiCisJIlxbXHJcblxdICAg ICAgICBjb250aW51ZSIKKyAgICB9CiB9CiAKIGdkYl90ZXN0ICJzZXQgZHBy aW50Zi1zdHlsZSBmb29iYXIiICJVbmRlZmluZWQgaXRlbTogXCJmb29iYXJc Ii4iIFwK --089e01293f867b513b04dadcf4ba--