From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29064 invoked by alias); 1 Jul 2013 08:51:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29012 invoked by uid 89); 1 Jul 2013 08:51:49 -0000 X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-oa0-f44.google.com (HELO mail-oa0-f44.google.com) (209.85.219.44) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Jul 2013 08:51:47 +0000 Received: by mail-oa0-f44.google.com with SMTP id l10so4571392oag.31 for ; Mon, 01 Jul 2013 01:51:45 -0700 (PDT) X-Received: by 10.182.181.99 with SMTP id dv3mr10553914obc.71.1372668705550; Mon, 01 Jul 2013 01:51:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.137.196 with HTTP; Mon, 1 Jul 2013 01:51:05 -0700 (PDT) In-Reply-To: <51D13985.9020709@redhat.com> References: <51CB2BAA.1070507@redhat.com> <51D13985.9020709@redhat.com> From: Hui Zhu Date: Mon, 01 Jul 2013 08:51:00 -0000 Message-ID: Subject: Re: [PATCH] fix PR 15180 "May only run agent-printf on the target" To: Pedro Alves Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=089e0158b6a696c13804e06f560d X-Virus-Found: No X-SW-Source: 2013-07/txt/msg00022.txt.bz2 --089e0158b6a696c13804e06f560d Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1446 On Mon, Jul 1, 2013 at 4:10 PM, Pedro Alves wrote: > On 06/30/2013 04:17 PM, Hui Zhu wrote: >>> > If dprintf style is agent, then the target doesn't report events >>> > for such hits. If we happen to see a trap reported for the >>> > same address as another breakpoint, the trap is surely not explained >>> > by the dprintf. IOW, we shouldn't have a bpstat a dprintf w/ style >>> > agent at all. What is need is to override the breakpoint_hit method >>> > of dprintf_breakpoint_ops to always return false for agent style dprintfs. >>> > >>> > Or maybe I'm missing something. I have a hard time going from >>> > the bug description in the PR to the patch. >> OK. I add dprintf_check_status in the new patch according to your comments. >> > > But I suggested the breakpoint_ops->breakpoint_hit not breakpoint_ops->check_status. > An agent-style dprintf is just like a tracepoint. It can't ever explain > a stop. See tracepoint_breakpoint_hit. If it didn't work, please explain why. OK. Post a new version according to your comments. Please help me review it. Thanks, Hui > > -- > Pedro Alves > 2013-07-01 Hui Zhu PR gdb/15180 * breakpoint.c (dprintf_breakpoint_hit): New function. (initialize_breakpoint_ops): Set dprintf_breakpoint_hit. 2013-07-01 Hui Zhu PR gdb/15180 * gdb.base/dprintf-same-addr.c: New file. * gdb.base/dprintf-same-addr.exp: New file. --089e0158b6a696c13804e06f560d Content-Type: text/plain; charset=US-ASCII; name="dprintf-same-addr.txt" Content-Disposition: attachment; filename="dprintf-same-addr.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hilfgxio0 Content-length: 1229 LS0tIGEvZ2RiL2JyZWFrcG9pbnQuYworKysgYi9nZGIvYnJlYWtwb2ludC5j CkBAIC0xMzM4OSw2ICsxMzM4OSwxOSBAQCB0cmFjZXBvaW50X3Byb2JlX2Rl Y29kZV9saW5lc3BlYyAoc3RydWN0CiAKIHN0YXRpYyBzdHJ1Y3QgYnJlYWtw b2ludF9vcHMgdHJhY2Vwb2ludF9wcm9iZV9icmVha3BvaW50X29wczsKIAor LyogSW1wbGVtZW50IHRoZSAiYnJlYWtwb2ludF9oaXQiIGJyZWFrcG9pbnRf b3BzIG1ldGhvZCBmb3IgZHByaW50Zi4gICovCisKK3N0YXRpYyBpbnQKK2Rw cmludGZfYnJlYWtwb2ludF9oaXQgKGNvbnN0IHN0cnVjdCBicF9sb2NhdGlv biAqYmwsCisJCQlzdHJ1Y3QgYWRkcmVzc19zcGFjZSAqYXNwYWNlLCBDT1JF X0FERFIgYnBfYWRkciwKKwkJCWNvbnN0IHN0cnVjdCB0YXJnZXRfd2FpdHN0 YXR1cyAqd3MpCit7CisgIGlmIChzdHJjbXAgKGRwcmludGZfc3R5bGUsIGRw cmludGZfc3R5bGVfYWdlbnQpICE9IDApCisgICAgcmV0dXJuIGJrcHRfYnJl YWtwb2ludF9oaXQgKGJsLCBhc3BhY2UsIGJwX2FkZHIsIHdzKTsKKworICBy ZXR1cm4gMDsKK30KKwogLyogRHByaW50ZiBicmVha3BvaW50X29wcyBtZXRo b2RzLiAgKi8KIAogc3RhdGljIHZvaWQKQEAgLTE1OTU3LDYgKzE1OTcwLDcg QEAgaW5pdGlhbGl6ZV9icmVha3BvaW50X29wcyAodm9pZCkKIAogICBvcHMg PSAmZHByaW50Zl9icmVha3BvaW50X29wczsKICAgKm9wcyA9IGJrcHRfYmFz ZV9icmVha3BvaW50X29wczsKKyAgb3BzLT5icmVha3BvaW50X2hpdCA9IGRw cmludGZfYnJlYWtwb2ludF9oaXQ7CiAgIG9wcy0+cmVfc2V0ID0gZHByaW50 Zl9yZV9zZXQ7CiAgIG9wcy0+cmVzb3VyY2VzX25lZWRlZCA9IGJrcHRfcmVz b3VyY2VzX25lZWRlZDsKICAgb3BzLT5wcmludF9pdCA9IGJrcHRfcHJpbnRf aXQ7Cg== --089e0158b6a696c13804e06f560d Content-Type: text/plain; charset=US-ASCII; name="dprintf-same-addr-test.txt" Content-Disposition: attachment; filename="dprintf-same-addr-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hilfh4x71 Content-length: 5072 LS0tIC9kZXYvbnVsbAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2Rw cmludGYtc2FtZS1hZGRyLmMKQEAgLTAsMCArMSwzNSBAQAorLyogVGhpcyB0 ZXN0Y2FzZSBpcyBwYXJ0IG9mIEdEQiwgdGhlIEdOVSBkZWJ1Z2dlci4KKwor ICAgQ29weXJpZ2h0IChDKSAyMDEzIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv biwgSW5jLgorICAgQ29udHJpYnV0ZWQgYnkgSHVpIFpodSAgPGh1aUBjb2Rl c291cmNlcnkuY29tPgorCisgICBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0 d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQor ICAgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyAgIHRoZSBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vu c2UsIG9yCisgICAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9u LgorCisgICBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhv cGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAgIGJ1dCBXSVRIT1VUIEFO WSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5 IG9mCisgICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisgICBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCisgICBZb3Ugc2hvdWxk IGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZQorICAgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBu b3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwor CisjaW5jbHVkZSA8c3RkaW8uaD4KKworaW50CittYWluICgpCit7CisgIGlu dCBpOworCisgIGZvciAoaT0wOyBpIDwgOTk7IGkrKykKKyAgICB7CisgICAg ICBwcmludGYoIkhlbGxvXG4iKTsJLyogdGVzdCBsaW5lICAqLworCisgICAg ICAvKiBXaXRob3V0IHRoaXMgbGluZSwgdGVzdCB3aXRoIGZwcmludGYgd2ls bCBub3Qgd29yay4gICovCisgICAgICBmcHJpbnRmIChzdGRlcnIsICJ3b3Js ZFxuIik7CisgICAgfQorCisgIHJldHVybiAwOworfQotLS0gL2Rldi9udWxs CisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvZHByaW50Zi1zYW1lLWFk ZHIuZXhwCkBAIC0wLDAgKzEsODIgQEAKKyMgICBDb3B5cmlnaHQgKEMpIDIw MTMgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisjICAgQ29udHJp YnV0ZWQgYnkgSHVpIFpodSAgPGh1aUBjb2Rlc291cmNlcnkuY29tPgorCisj IFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlz dHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJt cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlz aGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhl ciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9w dGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBp cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsLAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkg b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhl CisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFp bHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGgg dGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9y Zy9saWNlbnNlcy8+LgorCitzdGFuZGFyZF90ZXN0ZmlsZQorCitpZiBbcHJl cGFyZV9mb3JfdGVzdGluZyAiZmFpbGVkIHRvIHByZXBhcmUgZm9yIGRwcmlu dGYgd2l0aCBub24tc3RvcCIgXAorICAgICR7dGVzdGZpbGV9ICR7c3JjZmls ZX0ge2RlYnVnfV0geworICAgIHJldHVybiAtMQorfQorCitzZXQgYnBfbG9j YXRpb24gW2dkYl9nZXRfbGluZV9udW1iZXIgInRlc3QgbGluZSJdCisKK3By b2MgY29udGludWVfZHByaW50ZiB7YXJnc30geworICAgIHdpdGhfdGVzdF9w cmVmaXggJGFyZ3MgeworCWdsb2JhbCBicF9sb2NhdGlvbgorCisJZ2RiX3Rl c3QgImRwcmludGYgJGJwX2xvY2F0aW9uLFwiSGVsbG9cXG5cIiIgIkRwcmlu dGYgLioiCisJZ2RiX3Rlc3Rfbm9fb3V0cHV0IHtzZXQgJGJwbnVtMT0kYnBu dW19CisJZ2RiX2JyZWFrcG9pbnQgJGJwX2xvY2F0aW9uCisJZ2RiX3Rlc3Rf bm9fb3V0cHV0IHtzZXQgJGJwbnVtMj0kYnBudW19CisKKwlnZGJfdGVzdCAi Y29udGludWUiICJCcmVha3BvaW50IFxbMC05XF0rLCBtYWluIC4qIiAiRmly c3QgY29udGludWUiCisKKwlnZGJfdGVzdF9ub19vdXRwdXQgImNvbmRpdGlv biBcJGJwbnVtMSBpPjEwIgorCWdkYl90ZXN0X25vX291dHB1dCAiY29uZGl0 aW9uIFwkYnBudW0yIGk+MTUiCisKKwlnZGJfdGVzdCAiY29udGludWUiICJC cmVha3BvaW50IFxbMC05XF0rLCBtYWluIC4qIiAiU2Vjb25kIGNvbnRpbnVl IgorCisJZ2RiX3Rlc3QgInAgaSIgIlxbMC05XF0rID0gMTYiICJjaGVjayBp IgorICAgIH0KK30KKworaWYgIVtydW50byBtYWluXSB7CisgICAgcmV0dXJu IC0xCit9CitnZGJfdGVzdF9ub19vdXRwdXQgInNldCBkcHJpbnRmLXN0eWxl IGdkYiIgIlNldCBkcHJpbnRmIHN0eWxlIHRvIGdkYiIKK2NvbnRpbnVlX2Rw cmludGYgImdkYiIKKworaWYgIVt0YXJnZXRfaW5mbyBleGlzdHMgZ2RiLG5v aW5mZXJpb3Jpb10geworICAgIGlmICFbcnVudG8gbWFpbl0geworCXJldHVy biAtMQorICAgIH0KKyAgICBnZGJfdGVzdF9ub19vdXRwdXQgInNldCBkcHJp bnRmLXN0eWxlIGNhbGwiICJTZXQgZHByaW50ZiBzdHlsZSB0byBjYWxsIgor ICAgIGNvbnRpbnVlX2RwcmludGYgImNhbGwiCisKKyAgICBpZiAhW3J1bnRv IG1haW5dIHsKKwlyZXR1cm4gLTEKKyAgICB9CisgICAgZ2RiX3Rlc3Rfbm9f b3V0cHV0ICJzZXQgZHByaW50Zi1mdW5jdGlvbiBmcHJpbnRmIiAic2V0IGRw cmludGYtY2hhbm5lbCBzdGRlcnIiCisgICAgZ2RiX3Rlc3Rfbm9fb3V0cHV0 ICJzZXQgZHByaW50Zi1jaGFubmVsIHN0ZGVyciIgInNldCBkcHJpbnRmIGNo YW5uZWwiCisgICAgY29udGludWVfZHByaW50ZiAiZnByaW50ZiIKK30gZWxz ZSB7CisgICAgdW5zdXBwb3J0ZWQgInRlc3QgZHByaW50Zi1zdHlsZSBjYWxs IgorfQorCitpZiAhW3J1bnRvIG1haW5dIHsKKyAgICByZXR1cm4gLTEKK30K K2dkYl90ZXN0ICJkcHJpbnRmIG1haW4sXCJIZWxsb1xcblwiIiAiRHByaW50 ZiAuKiIKK3NldCBtc2cgIlNldCBkcHJpbnRmIHN0eWxlIHRvIGFnZW50Igor Z2RiX3Rlc3RfbXVsdGlwbGUgInNldCBkcHJpbnRmLXN0eWxlIGFnZW50IiAk bXNnIHsKKyAgICAtcmUgIndhcm5pbmc6IFRhcmdldCBjYW5ub3QgcnVuIGRw cmludGYgY29tbWFuZHMuKlxyXG4kZ2RiX3Byb21wdCAkIiB7CisJdW5zdXBw b3J0ZWQgJG1zZworICAgIH0KKyAgICAtcmUgIi4qJGdkYl9wcm9tcHQgJCIg eworCXBhc3MgJG1zZworCWNvbnRpbnVlX2RwcmludGYgImFnZW50IgorICAg IH0KK30K --089e0158b6a696c13804e06f560d--