From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19368 invoked by alias); 18 Apr 2013 05:37:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19359 invoked by uid 89); 18 Apr 2013 05:37:31 -0000 X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-ob0-f178.google.com (HELO mail-ob0-f178.google.com) (209.85.214.178) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Apr 2013 05:37:30 +0000 Received: by mail-ob0-f178.google.com with SMTP id ni5so2162117obc.37 for ; Wed, 17 Apr 2013 22:37:28 -0700 (PDT) X-Received: by 10.60.34.202 with SMTP id b10mr4562317oej.119.1366263448420; Wed, 17 Apr 2013 22:37:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Wed, 17 Apr 2013 22:36:48 -0700 (PDT) From: Hui Zhu Date: Thu, 18 Apr 2013 17:04:00 -0000 Message-ID: Subject: [PATCH] Let dprintf can be saved To: gdb-patches ml Content-Type: multipart/mixed; boundary=089e013cc02283469104da9bfffe X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00561.txt.bz2 --089e013cc02283469104da9bfffe Content-Type: text/plain; charset=ISO-8859-1 Content-length: 585 Hi, This patch fix http://sourceware.org/bugzilla/show_bug.cgi?id=15165 But I didn't use commands because it is not current way to setup commands of dprintf. So I add a check in save_breakpoints to let it not save dprintf commands.. If you think we need, I can put commands save code as a special function to handle it. Please help me review it. Thanks, Hui 2013-04-18 Hui Zhu PR gdb/15165 * breakpoint.c (dprintf_print_recreate): New. (save_breakpoints): Let it not save dprintf commands. (initialize_breakpoint_ops): Set dprintf_print_recreate. --089e013cc02283469104da9bfffe Content-Type: text/plain; charset=US-ASCII; name="dprintf-save.txt" Content-Disposition: attachment; filename="dprintf-save.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfnhycrg0 Content-length: 1497 LS0tIGEvZ2RiL2JyZWFrcG9pbnQuYworKysgYi9nZGIvYnJlYWtwb2ludC5j CkBAIC0xMzM2NCw2ICsxMzM2NCwxNCBAQCBkcHJpbnRmX3JlX3NldCAoc3Ry dWN0IGJyZWFrcG9pbnQgKmIpCiAgICAgdXBkYXRlX2RwcmludGZfY29tbWFu ZF9saXN0IChiKTsKIH0KIAorc3RhdGljIHZvaWQKK2RwcmludGZfcHJpbnRf cmVjcmVhdGUgKHN0cnVjdCBicmVha3BvaW50ICp0cCwgc3RydWN0IHVpX2Zp bGUgKmZwKQoreworICBmcHJpbnRmX3VuZmlsdGVyZWQgKGZwLCAiZHByaW50 ZiAlcyVzIiwgdHAtPmFkZHJfc3RyaW5nLAorCQkgICAgICB0cC0+ZXh0cmFf c3RyaW5nKTsKKyAgcHJpbnRfcmVjcmVhdGVfdGhyZWFkICh0cCwgZnApOwor fQorCiAvKiBUaGUgYnJlYWtwb2ludF9vcHMgc3RydWN0dXJlIHRvIGJlIHVz ZWQgb24gc3RhdGljIHRyYWNlcG9pbnRzIHdpdGgKICAgIG1hcmtlcnMgKGAt bScpLiAgKi8KIApAQCAtMTU0NTMsNyArMTU0NjEsNyBAQCBzYXZlX2JyZWFr cG9pbnRzIChjaGFyICpmaWxlbmFtZSwgaW50IGZyCiAgICAgaWYgKHRwLT5p Z25vcmVfY291bnQpCiAgICAgICBmcHJpbnRmX3VuZmlsdGVyZWQgKGZwLCAi ICBpZ25vcmUgJGJwbnVtICVkXG4iLCB0cC0+aWdub3JlX2NvdW50KTsKIAot ICAgIGlmICh0cC0+Y29tbWFuZHMpCisgICAgaWYgKHRwLT50eXBlICE9IGJw X2RwcmludGYgJiYgdHAtPmNvbW1hbmRzKQogICAgICAgewogCXZvbGF0aWxl IHN0cnVjdCBnZGJfZXhjZXB0aW9uIGV4OwkKIApAQCAtMTU4NTksNyArMTU4 NjcsNyBAQCBpbml0aWFsaXplX2JyZWFrcG9pbnRfb3BzICh2b2lkKQogICBv cHMtPnJlc291cmNlc19uZWVkZWQgPSBia3B0X3Jlc291cmNlc19uZWVkZWQ7 CiAgIG9wcy0+cHJpbnRfaXQgPSBia3B0X3ByaW50X2l0OwogICBvcHMtPnBy aW50X21lbnRpb24gPSBia3B0X3ByaW50X21lbnRpb247Ci0gIG9wcy0+cHJp bnRfcmVjcmVhdGUgPSBia3B0X3ByaW50X3JlY3JlYXRlOworICBvcHMtPnBy aW50X3JlY3JlYXRlID0gZHByaW50Zl9wcmludF9yZWNyZWF0ZTsKIH0KIAog LyogQ2hhaW4gY29udGFpbmluZyBhbGwgZGVmaW5lZCAiZW5hYmxlIGJyZWFr cG9pbnQiIHN1YmNvbW1hbmRzLiAgKi8K --089e013cc02283469104da9bfffe--