From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 732 invoked by alias); 15 May 2012 11:29:21 -0000 Received: (qmail 723 invoked by uid 22791); 15 May 2012 11:29:19 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 11:29:06 +0000 Received: by vbbey12 with SMTP id ey12so7522075vbb.0 for ; Tue, 15 May 2012 04:29:06 -0700 (PDT) Received: by 10.52.68.136 with SMTP id w8mr5294283vdt.74.1337081346006; Tue, 15 May 2012 04:29:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.184.2 with HTTP; Tue, 15 May 2012 04:28:25 -0700 (PDT) In-Reply-To: <4FA2B434.60706@mentor.com> References: <4FA2B434.60706@mentor.com> From: Hui Zhu Date: Tue, 15 May 2012 11:29:00 -0000 Message-ID: Subject: Re: [PATCH] Autoload-breakpoints without report-async To: Hui Zhu Cc: gdb-patches@sourceware.org, Yao Qi , Stan Shebs , Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00561.txt.bz2 Ping. Thanks, Hui On Fri, May 4, 2012 at 12:37 AM, Hui Zhu wrote: > Hi guys, > > According to the mail form Yao. =A0I thought make the autoload-breakpoint= s and > report-async function together make it too hard to review. =A0So I move t= he > function that depend on the report-async to be a series of separate patch= es > after report-async. > Then the other patches of autoload-breakpoints can be reveiw separate from > report-async. > > Thanks, > Hui > > 2012-05-04 =A0Hui Zhu =A0 > > =A0 =A0 =A0 =A0* breakpoint.c (hex2bin, unpack_varlen_hex): New extern. > =A0 =A0 =A0 =A0(autoload_breakpoints_query, autoload_breakpoints_merge, > =A0 =A0 =A0 =A0autoload_breakpoints_gdb, autoload_breakpoints_stub, > =A0 =A0 =A0 =A0autoload_breakpoints_enums, this_ubpcmd): New variable. > =A0 =A0 =A0 =A0(breakpoint_get_commands): New function. > =A0 =A0 =A0 =A0(print_one_breakpoint): Add out for b->autoload_id. > =A0 =A0 =A0 =A0(init_raw_breakpoint_without_location): Add init for autol= oad_id > =A0 =A0 =A0 =A0and autoload_inserted. > =A0 =A0 =A0 =A0(autoload_breakpoints_get_id, uploaded_bp_commands_clean, > =A0 =A0 =A0 =A0uploaded_bp_commands_add, handle_autoload_breakpoint_cmd, > =A0 =A0 =A0 =A0parse_autoload_breakpoint_definition, > =A0 =A0 =A0 =A0handle_autoload_breakpoint_cmd_to_breakpoints, > =A0 =A0 =A0 =A0parse_autoload_breakpoint_definition_to_breakpoints, > =A0 =A0 =A0 =A0clean_upload_autoload_breakpoints, > =A0 =A0 =A0 =A0show_upload_autoload_breakpoints, > =A0 =A0 =A0 =A0read_autoload_breakpoints_action, > =A0 =A0 =A0 =A0merge_uploaded_autoload_breakpoints, autoload_breakpoints_= reset, > =A0 =A0 =A0 =A0autoload_breakpoints_clean, > =A0 =A0 =A0 =A0autoload_breakpoints_number): New function. > =A0 =A0 =A0 =A0(initialize_breakpoint_ops): add command "autoload". > =A0 =A0 =A0 =A0* breakpoint.h (breakpoint): Add autoload_id and autoload_= inserted. > =A0 =A0 =A0 =A0(uploaded_bpcmd, uploaded_bp): New struct. > =A0 =A0 =A0 =A0(autoload_breakpoints_query, autoload_breakpoints_merge, > =A0 =A0 =A0 =A0autoload_breakpoints_gdb, autoload_breakpoints_stub, > =A0 =A0 =A0 =A0autoload_breakpoints_mode, breakpoint_get_commands, > =A0 =A0 =A0 =A0autoload_breakpoints_reset, autoload_breakpoints_clean, > =A0 =A0 =A0 =A0autoload_breakpoints_number, parse_autoload_breakpoint_def= inition, > =A0 =A0 =A0 =A0parse_autoload_breakpoint_definition_to_breakpoints, > =A0 =A0 =A0 =A0clean_upload_autoload_breakpoints, show_upload_autoload_br= eakpoints, > =A0 =A0 =A0 =A0merge_uploaded_autoload_breakpoints): New extern. > =A0 =A0 =A0 =A0* remote.c (PACKET_AutoloadBreakpoints): New enum. > =A0 =A0 =A0 =A0(remote_start_remote): Check PACKET_AutoloadBreakpoints, > =A0 =A0 =A0 =A0if need call autoload-breakpoints functions. > =A0 =A0 =A0 =A0(remote_pr): Add PACKET_AutoloadBreakpoints. > =A0 =A0 =A0 =A0(remote_reportasync_handler): Add handle for "QBDP". > =A0 =A0 =A0 =A0(remote_upload_autoload_breakpoints, > =A0 =A0 =A0 =A0remote_download_autoload_breakpoints): New functions. > > 2012-05-04 =A0Hui Zhu =A0 > > =A0 =A0 =A0 =A0* gdb.texinfo (Setting Breakpoints): Add set breakpoint au= toload. > =A0 =A0 =A0 =A0(Remote Serial Protocol): Add Autoload-breakpoints Format.