From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97454-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6413 invoked by alias); 6 Jan 2013 07:33:43 -0000
Received: (qmail 6405 invoked by uid 22791); 6 Jan 2013 07:33:42 -0000
X-SWARE-Spam-Status: No, hits=-4.7 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-oa0-f54.google.com (HELO mail-oa0-f54.google.com) (209.85.219.54)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Jan 2013 07:33:36 +0000
Received: by mail-oa0-f54.google.com with SMTP id n9so16563859oag.13        for <gdb-patches@sourceware.org>; Sat, 05 Jan 2013 23:33:36 -0800 (PST)
Received: by 10.60.169.171 with SMTP id af11mr31675398oec.92.1357457616383; Sat, 05 Jan 2013 23:33:36 -0800 (PST)
MIME-Version: 1.0
Received: by 10.60.84.5 with HTTP; Sat, 5 Jan 2013 23:32:56 -0800 (PST)
In-Reply-To: <20130106065027.GB3703@adacore.com>
References: <CANFwon27w-6+73nUvm-RYip2Ku8JcGRkVzJVwNrWOzsij6ES8A@mail.gmail.com> <87d2xm0wrs.fsf@fleche.redhat.com> <CANFwon1fZ0nP0rr10MDJmr7gJYqoDKiXsDAp8w=4iFU5MbekfQ@mail.gmail.com> <87obh5ypk7.fsf@fleche.redhat.com> <CANFwon2pVusoP15YcaOR63vcDz8yeCB97xpH14pgZaXwbgCBqQ@mail.gmail.com> <20130106065027.GB3703@adacore.com>
From: Hui Zhu <teawater@gmail.com>
Date: Sun, 06 Jan 2013 07:33:00 -0000
Message-ID: <CANFwon0cj+RePY7+qJ=WyCxMZ25hX9QLEZ8Cjr1LyQYGQBCzwA@mail.gmail.com>
Subject: Re: [PATCH] Add extern of output_command to utils.h
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00084.txt.bz2

On Sun, Jan 6, 2013 at 2:50 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> 2013-01-05  Hui Zhu  <hui_zhu@mentor.com>
>>
>>       * tracepoint.c: Remove extern of function output_command.
>>       * valprint.h.h (output_command): New extern.
>
> If I may, can we try to provide the names of the arguments
> in function declarations?
>
>> --- a/valprint.h
>> +++ b/valprint.h
>> @@ -205,4 +205,6 @@ extern void generic_printstr (struct ui_
>>                             int quote_char, int c_style_terminator,
>>                             const struct value_print_options *options);
>>
>> +extern void output_command (char *, int);
>> +
>
> Thanks,
> --
> Joel

OK.  I post a new version according to your comments.

Thanks,
Hui

2013-01-05  Hui Zhu  <hui_zhu@mentor.com>

	* printcmd.c: Remove define of function output_command.
	* tracepoint.c: Remove extern of function output_command.
	* valprint.h.h (output_command): New extern.

--- a/printcmd.c
+++ b/printcmd.c
@@ -172,8 +172,6 @@ static int display_number;

 /* Prototypes for exported functions.  */

-void output_command (char *, int);
-
 void _initialize_printcmd (void);

 /* Prototypes for local functions.  */
--- a/tracepoint.c
+++ b/tracepoint.c
@@ -93,11 +93,6 @@ extern void (*deprecated_readline_begin_
 extern char *(*deprecated_readline_hook) (char *);
 extern void (*deprecated_readline_end_hook) (void);

-/* GDB commands implemented in other modules:
- */
-
-extern void output_command (char *, int);
-
 /*
    Tracepoint.c:

--- a/valprint.h
+++ b/valprint.h
@@ -205,4 +205,6 @@ extern void generic_printstr (struct ui_
 			      int quote_char, int c_style_terminator,
 			      const struct value_print_options *options);

+extern void output_command (char *exp, int from_tty);
+
 #endif