From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22428 invoked by alias); 10 May 2012 15:05:11 -0000 Received: (qmail 22411 invoked by uid 22791); 10 May 2012 15:05:10 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_XP X-Spam-Check-By: sourceware.org Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 May 2012 15:04:56 +0000 Received: by wgbdr1 with SMTP id dr1so1241390wgb.12 for ; Thu, 10 May 2012 08:04:55 -0700 (PDT) Received: by 10.180.79.72 with SMTP id h8mr17001454wix.1.1336662294922; Thu, 10 May 2012 08:04:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.15.154 with HTTP; Thu, 10 May 2012 08:04:14 -0700 (PDT) In-Reply-To: <4FABAD08.5020305@redhat.com> References: <4F71C7F0.90209@mentor.com> <87iphoy2xx.fsf@fleche.redhat.com> <4F73B80C.7050703@mentor.com> <4F744956.4060500@redhat.com> <4F7D5456.9080806@mentor.com> <4F7D8715.9040509@redhat.com> <4F851A22.40809@mentor.com> <4FAB41A5.2020802@mentor.com> <4FABAD08.5020305@redhat.com> From: Hui Zhu Date: Thu, 10 May 2012 15:05:00 -0000 Message-ID: Subject: Re: [PATCH]testsuite: test for disconnected-tracing To: Pedro Alves Cc: Hui Zhu , Tom Tromey , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=f46d0442827a46057104bfaff1cb X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00346.txt.bz2 --f46d0442827a46057104bfaff1cb Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2823 On Thu, May 10, 2012 at 7:56 PM, Pedro Alves wrote: > On 05/10/2012 05:18 AM, Hui Zhu wrote: > >> On 04/11/12 13:44, Hui Zhu wrote: >>> On 04/05/12 19:50, Pedro Alves wrote: >>>> On 04/05/2012 09:14 AM, Hui Zhu wrote: >>>> >>>>> I post a new version patch according to your comments. >>>>> And I have test it with gdb-7.4 and got fail. >>>> >>>> >>>> Thanks. =A0Only a few nits remain, and this is technically ready to >>>> check in. =A0See below. >>>> >>>> However, what's the status of your copyright assignment? =A0Last I >>>> heard (and from what I see in FSF's copyright assignment records), we >>>> still can't accept changes from you on behalf of Mentor. =A0:-( >>> >>> What I got is it is OK now. =A0I will send you a mail and cc the people= that about the law. >> >> Hi Pedro, >> >> The copyright issue is OK now. > > > Yep, took a while, but it's sorted now. =A0Thanks for your patience. > >> Do you think I can check in this patch? > > > I took another look at the patch, and I now notice you didn't address > some of my early comments in : > >> Please always look at the resulting messages in gdb.sum: > .. >> There are duplicate messages here. =A0See >> . >> >> I'd lowercase the "First", etc., in the test messages. =A0It's much more= common. > > This is what I get now: > >>cat testsuite/gdb.sum| grep PASS | sort | uniq -c | sort -nr > =A0 =A0 =A02 PASS: gdb.trace/disconnected-tracing.exp: reconnect after un= load > =A0 =A0 =A02 PASS: gdb.trace/disconnected-tracing.exp: disconnect > =A0 =A0 =A01 PASS: gdb.trace/disconnected-tracing.exp: tstart > =A0 =A0 =A01 PASS: gdb.trace/disconnected-tracing.exp: trace main > =A0 =A0 =A01 PASS: gdb.trace/disconnected-tracing.exp: Third info tracepo= ints > =A0 =A0 =A01 PASS: gdb.trace/disconnected-tracing.exp: set disconnected-t= racing on > =A0 =A0 =A01 PASS: gdb.trace/disconnected-tracing.exp: set confirm off > =A0 =A0 =A01 PASS: gdb.trace/disconnected-tracing.exp: Second info tracep= oints > =A0 =A0 =A01 PASS: gdb.trace/disconnected-tracing.exp: Fourth info tracep= oints > =A0 =A0 =A01 PASS: gdb.trace/disconnected-tracing.exp: First info tracepo= ints > > Yao also made a valid comment here: > > > > that doesn't appear to have been addressed. > > -- > Pedro Alves Hi Pedro, I post a new version that lowercase the pass info and update Makefile.in according to Yao's comments. Please help me review it. Thanks, Hui 2012-05-10 Hui Zhu * gdb.trace/Makefile.in (PROGS): Add disconnected-tracing. * gdb.trace/disconnected-tracing.c: New file. * gdb.trace/disconnected-tracing.exp: New file. --f46d0442827a46057104bfaff1cb Content-Type: text/plain; charset=US-ASCII; name="disconnected-tracing.txt" Content-Disposition: attachment; filename="disconnected-tracing.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h21y5hia0 Content-length: 5564 LS0tCiB0ZXN0c3VpdGUvZ2RiLnRyYWNlL01ha2VmaWxlLmluICAgICAgICAg ICAgICB8ICAgIDYgKy0KIHRlc3RzdWl0ZS9nZGIudHJhY2UvZGlzY29ubmVj dGVkLXRyYWNpbmcuYyAgIHwgICAyMSArKysrKysrCiB0ZXN0c3VpdGUvZ2Ri LnRyYWNlL2Rpc2Nvbm5lY3RlZC10cmFjaW5nLmV4cCB8ICAgNzYgKysrKysr KysrKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDEwMCBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKLS0tIGEvdGVzdHN1aXRl L2dkYi50cmFjZS9NYWtlZmlsZS5pbgorKysgYi90ZXN0c3VpdGUvZ2RiLnRy YWNlL01ha2VmaWxlLmluCkBAIC0zLDkgKzMsOSBAQCBzcmNkaXIgPSBAc3Jj ZGlyQAogCiAuUEhPTlk6IGFsbCBjbGVhbiBtb3N0bHljbGVhbiBkaXN0Y2xl YW4gcmVhbGNsZWFuCiAKLVBST0dTID0gYXggYmFja3RyYWNlIGRlbHRyYWNl IGluZm90cmFjZSBwYWNrZXRsZW4gcGFzc2MtZHluIHBhc3Njb3VudCBcCi0J cmVwb3J0IHNhdmUtdHJhY2UgdGZpbGUgdGZpbmQgdHJhY2VjbWQgdHN2IHVu YXZhaWxhYmxlIHdoaWxlLWR5biBcCi0Jd2hpbGUtc3RlcHBpbmcKK1BST0dT ID0gYXggYmFja3RyYWNlIGRlbHRyYWNlIGRpc2Nvbm5lY3RlZC10cmFjaW5n IGluZm90cmFjZSBwYWNrZXRsZW4gXAorCXBhc3NjLWR5biBwYXNzY291bnQg cmVwb3J0IHNhdmUtdHJhY2UgdGZpbGUgdGZpbmQgdHJhY2VjbWQgdHN2IFwK Kwl1bmF2YWlsYWJsZSB3aGlsZS1keW4gd2hpbGUtc3RlcHBpbmcKIAogYWxs IGluZm8gaW5zdGFsbC1pbmZvIGR2aSBpbnN0YWxsIHVuaW5zdGFsbCBpbnN0 YWxsY2hlY2sgY2hlY2s6CiAJQGVjaG8gIk5vdGhpbmcgdG8gYmUgZG9uZSBm b3IgJEAuLi4iCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdHN1aXRlL2dkYi50 cmFjZS9kaXNjb25uZWN0ZWQtdHJhY2luZy5jCkBAIC0wLDAgKzEsMjEgQEAK Ky8qIFRoaXMgdGVzdGNhc2UgaXMgcGFydCBvZiBHREIsIHRoZSBHTlUgZGVi dWdnZXIuCisKKyAgIENvcHlyaWdodCAyMDEyIEZyZWUgU29mdHdhcmUgRm91 bmRhdGlvbiwgSW5jLgorCisgICBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0 d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQor ICAgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyAgIHRoZSBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vu c2UsIG9yCisgICAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9u LgorCisgICBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhv cGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAgIGJ1dCBXSVRIT1VUIEFO WSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5 IG9mCisgICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisgICBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCisgICBZb3Ugc2hvdWxk IGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZQorICAgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBu b3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwor CitpbnQgbWFpbiAoKQoreworICByZXR1cm4gMDsKK30KLS0tIC9kZXYvbnVs bAorKysgYi90ZXN0c3VpdGUvZ2RiLnRyYWNlL2Rpc2Nvbm5lY3RlZC10cmFj aW5nLmV4cApAQCAtMCwwICsxLDc2IEBACisjICAgQ29weXJpZ2h0IDIwMTIg RnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisjCisjIFRoaXMgcHJv Z3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUg R05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5Cisj IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9u IDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9wdGlvbikgYW55 IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmli dXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorIyBi dXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1w bGllZCB3YXJyYW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVT UyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisjIEdOVSBH ZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisjCisj IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBH ZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGggdGhpcyBwcm9n cmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNl cy8+LgorCisjIFRlc3Qgb2YgZGlzY29ubmVjdGVkLXRyYWNpbmcuCisKK2xv YWRfbGliICJ0cmFjZS1zdXBwb3J0LmV4cCI7CisKK3NldCB0ZXN0ZmlsZSAi ZGlzY29ubmVjdGVkLXRyYWNpbmciCitzZXQgZXhlY3V0YWJsZSAkdGVzdGZp bGUKK3NldCBzcmNmaWxlICR7dGVzdGZpbGV9LmMKK3NldCBiaW5maWxlICRv YmpkaXIvJHN1YmRpci8kdGVzdGZpbGUKK3NldCBleHBmaWxlICR0ZXN0Zmls ZS5leHAKK3NldCBnZGJzZXJ2ZXJfcmVjb25uZWN0X3AgMQorCitpZiB7IFtp bmZvIHByb2MgZ2RiX3JlY29ubmVjdF0gPT0gIiIgfSB7CisgICAgdW5zdXBw b3J0ZWQgInRhcmdldCBkb2VzIG5vdCBzdXBwb3J0IHJlY29ubmVjdCIKKyAg ICByZXR1cm4gLTEKK30KKworaWYgW3ByZXBhcmVfZm9yX3Rlc3RpbmcgJGV4 cGZpbGUgJGV4ZWN1dGFibGUgJHNyY2ZpbGUgXAorICAgICAgICB7ZGVidWcg bm93YXJuaW5nc31dIHsKKyAgICB1bnRlc3RlZCAiZmFpbGVkIHRvIHByZXBh cmUgZm9yIHRyYWNlIHRlc3RzIgorICAgIHJldHVybiAtMQorfQorCitpZiAh W3J1bnRvX21haW5dIHsKKyAgICBmYWlsICJjYW4ndCBydW4gdG8gbWFpbiB0 byBjaGVjayBmb3IgdHJhY2Ugc3VwcG9ydCIKKyAgICByZXR1cm4gLTEKK30K KworaWYgIVtnZGJfdGFyZ2V0X3N1cHBvcnRzX3RyYWNlXSB7CisgICAgdW5z dXBwb3J0ZWQgInRhcmdldCBkb2VzIG5vdCBzdXBwb3J0IHRyYWNlIgorICAg IHJldHVybiAtMTsKK30KKworZGVsZXRlX2JyZWFrcG9pbnRzCitnZGJfdGVz dF9ub19vdXRwdXQgInNldCBjb25maXJtIG9mZiIKK2dkYl90ZXN0X25vX291 dHB1dCAic2V0IGRpc2Nvbm5lY3RlZC10cmFjaW5nIG9uIgorZ2RiX3Rlc3Qg InRyYWNlIG1haW4iICIuKiIKK2dkYl90ZXN0X25vX291dHB1dCAidHN0YXJ0 IgorCitnZGJfdGVzdCAiaW5mbyB0cmFjZXBvaW50cyIgIi4qaW4gbWFpbiBh dC4qIiAiZmlyc3QgaW5mbyB0cmFjZXBvaW50cyIKKworZ2RiX3Rlc3QgImRp c2Nvbm5lY3QiICJFbmRpbmcgcmVtb3RlIGRlYnVnZ2luZ1xcLiIKK2lmIHsg W2dkYl9yZWNvbm5lY3RdID09IDAgfSB7CisgICAgcGFzcyAicmVjb25uZWN0 IGFmdGVyIHVubG9hZCIKK30gZWxzZSB7CisgICAgZmFpbCAicmVjb25uZWN0 IGFmdGVyIHVubG9hZCIKKyAgICByZXR1cm4gMAorfQorZ2RiX3Rlc3QgImlu Zm8gdHJhY2Vwb2ludHMiICIuKmluIG1haW4gYXQuKiIgInNlY29uZCBpbmZv IHRyYWNlcG9pbnRzIgorCitkZWxldGVfYnJlYWtwb2ludHMKK2dkYl90ZXN0 ICJpbmZvIHRyYWNlcG9pbnRzIiAiLipObyB0cmFjZXBvaW50cy4uKiIgInRo aXJkIGluZm8gdHJhY2Vwb2ludHMiCisKK2dkYl90ZXN0ICJkaXNjb25uZWN0 IiAiRW5kaW5nIHJlbW90ZSBkZWJ1Z2dpbmdcXC4iCitpZiB7IFtnZGJfcmVj b25uZWN0XSA9PSAwIH0geworICAgIHBhc3MgInJlY29ubmVjdCBhZnRlciB1 bmxvYWQiCit9IGVsc2UgeworICAgIGZhaWwgInJlY29ubmVjdCBhZnRlciB1 bmxvYWQiCisgICAgcmV0dXJuIDAKK30KK2dkYl90ZXN0ICJpbmZvIHRyYWNl cG9pbnRzIiAiLippbiBtYWluIGF0LioiICJmb3VydGggaW5mbyB0cmFjZXBv aW50cyIKKwo= --f46d0442827a46057104bfaff1cb--