From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93062-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14169 invoked by alias); 25 Jul 2012 12:57:50 -0000
Received: (qmail 14161 invoked by uid 22791); 25 Jul 2012 12:57:49 -0000
X-SWARE-Spam-Status: No, hits=-4.7 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-gh0-f169.google.com (HELO mail-gh0-f169.google.com) (209.85.160.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 12:57:37 +0000
Received: by ghrr18 with SMTP id r18so817968ghr.0        for <gdb-patches@sourceware.org>; Wed, 25 Jul 2012 05:57:36 -0700 (PDT)
Received: by 10.42.155.73 with SMTP id t9mr24345527icw.48.1343221056126; Wed, 25 Jul 2012 05:57:36 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.231.240.65 with HTTP; Wed, 25 Jul 2012 05:56:55 -0700 (PDT)
In-Reply-To: <87lii9ne95.fsf@fleche.redhat.com>
References: <CANFwon22Tt57WcsDE8rPrSjgxg62MbgsN0WrAELu9Y52RDwUGg@mail.gmail.com> <500C0A1F.8040106@redhat.com> <CANFwon2u=xV4XqKV33Fqk_1k7QQQWixMDNNjJKM01tkV4dTWxQ@mail.gmail.com> <87k3xusgan.fsf@fleche.redhat.com> <CANFwon2KzfyOzhV625S7xqMAw6+iLjmUz8oHjaC=T=PUshUZZw@mail.gmail.com> <87lii9ne95.fsf@fleche.redhat.com>
From: Hui Zhu <teawater@gmail.com>
Date: Wed, 25 Jul 2012 12:57:00 -0000
Message-ID: <CANFwon0SkNBVcLxf+PqyUzZyQJLhnPPzhPm=9qC9xAO8547Rmw@mail.gmail.com>
Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
To: Tom Tromey <tromey@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00518.txt.bz2

On Wed, Jul 25, 2012 at 3:35 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
>>> 2012-07-24  Hui Zhu  <hui_zhu@mentor.com>
>>>      * linespec.c (linespec_lexer_lex_number): Update comments,
>>>      change the return and add check to make sure the input is
>>>      the decimal numbers.
>>>      (linespec_lexer_lex_one): If linespec_lexer_lex_number return
>>>      false, call linespec_lexer_lex_string.
>
>>> +static int
>>> +linespec_lexer_lex_number (linespec_parser *parser, linespec_token *tokenp)
>>>  {
>>>    linespec_token token;
>
> After this change, I think 'token' is unused.

Oops.

>
> The patch is ok if you update it to remove this.
>
> thanks,
> Tom

I fixed it and committed this patch to trunk and 7.5.

Thanks,
Hui