From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5025 invoked by alias); 9 Sep 2013 08:41:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5013 invoked by uid 89); 9 Sep 2013 08:41:13 -0000 Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 09 Sep 2013 08:41:13 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f175.google.com Received: by mail-ob0-f175.google.com with SMTP id xn12so5618213obc.6 for ; Mon, 09 Sep 2013 01:41:10 -0700 (PDT) X-Received: by 10.182.242.37 with SMTP id wn5mr10490645obc.56.1378716070774; Mon, 09 Sep 2013 01:41:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.7.97 with HTTP; Mon, 9 Sep 2013 01:40:30 -0700 (PDT) From: Hui Zhu Date: Mon, 09 Sep 2013 08:41:00 -0000 Message-ID: Subject: [PATCH] Fix gdb.base/shreloc.exp: (msymbol) relocated functions have different addresses fail in cygwin To: gdb-patches ml Content-Type: multipart/mixed; boundary=e89a8ff1cd66a50ed704e5ef59db X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00272.txt.bz2 --e89a8ff1cd66a50ed704e5ef59db Content-Type: text/plain; charset=ISO-8859-1 Content-length: 896 Hi, I got fail with gdb.base/shreloc.exp in cygwin: shell grep -E " fn_[12]([ ^G]+.*)?$" /home/hzhu/bg/gdb/testsuite/gdb.base/shreloc.txt^M [20] A 0x0 fn_1 section .text^M [21] A 0x0 fn_2 section .text^M [35] T 0x40010e0 fn_1 section .text^M [30] T 0x4310e0 fn_2 section .text^M (gdb) PASS: gdb.base/shreloc.exp: get_msym_addrs fn_[12] FAIL: gdb.base/shreloc.exp: (msymbol) relocated functions have different addresses The reason is because the address of fn_1 and fn_2 is same. But I checked the file with nm: $ nm gdb.base/shreloc.exe | grep fn 004050c0 I __imp__fn_1 004050cc I __imp__fn_2 00000000 A _fn_1 00000000 A _fn_2 I think the behavior of GDB to output same address is right. So I make a patch to test. Please help me review it. Thanks, Hui 2013-09-09 Hui Zhu * gdb.base/shreloc.exp (get_msym_addrs): Add argument "plus_var". (check_different): Ditto. --e89a8ff1cd66a50ed704e5ef59db Content-Type: text/plain; charset=US-ASCII; name="fix-cygwin-shreloc.txt" Content-Disposition: attachment; filename="fix-cygwin-shreloc.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hldfx1v40 Content-length: 2282 LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9zaHJlbG9jLmV4cAorKysg Yi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL3NocmVsb2MuZXhwCkBAIC0xNTcs MTQgKzE1NywxOCBAQCBwcm9jIHNlbmRfZ2RiX2Rpc2NhcmQgeyBjb21tYW5k IH0gewogICAgIH0KIH0KIAotcHJvYyBnZXRfbXN5bV9hZGRycyB7IHZhciBt c3ltZmlsZSB9IHsKK3Byb2MgZ2V0X21zeW1fYWRkcnMgeyB2YXIgbXN5bWZp bGUgeyBwbHVzX3ZhciAiIiB9IH0gewogICAgICMgRXh0cmFjdCB0aGUgbGlz dCBvZiB2YWx1ZXMgZm9yIHN5bWJvbHMgbWF0Y2hpbmcgdmFyIGluIHRoZQog ICAgICMgbWluaW1hbCBzeW1ib2wgb3V0cHV0IGZpbGUKIAogICAgIGdsb2Jh bCBnZGJfcHJvbXB0IGhleAogICAgIHNldCByZXN1bHQgIiIKIAotICAgIHNl bmRfZ2RiICJzaGVsbCBncmVwIC1FIFwiICR7dmFyfShcWyBcdFxdKy4qKT9c JFwiICR7bXN5bWZpbGV9XG4iCisgICAgaWYgeyAiJHtwbHVzX3Zhcn0iID09 ICIiIH0geworCXNlbmRfZ2RiICJzaGVsbCBncmVwIC1FIFwiICR7dmFyfShc WyBcdFxdKy4qKT9cJFwiICR7bXN5bWZpbGV9XG4iCisgICAgfSBlbHNlIHsK KwlzZW5kX2dkYiAic2hlbGwgZ3JlcCAtRSBcIiAke3BsdXNfdmFyfSAuKiAk e3Zhcn0oXFsgXHRcXSsuKik/XCRcIiAke21zeW1maWxlfVxuIgorICAgIH0K IAogICAgIHdoaWxlIDEgewogCWdkYl9leHBlY3QgewpAQCAtMjAxLDEwICsy MDUsMTAgQEAgcHJvYyBjaGVja19zYW1lIHt2YXIgbXN5bWZpbGV9IHsKICAg ICB9CiB9CiAKLXByb2MgY2hlY2tfZGlmZmVyZW50IHt2YXIgbXN5bWZpbGV9 IHsKK3Byb2MgY2hlY2tfZGlmZmVyZW50IHt2YXIgbXN5bWZpbGUgeyBwbHVz X3ZhciAiIiB9IH0gewogICAgICMgQ2hlY2sgdGhhdCB0aGUgbWluaW1hbCBz eW1ib2wgdmFsdWVzIG1hdGNoaW5nIHZhciBhcmUgZGlmZmVyZW50CiAKLSAg ICBzZXQgYWRkcl9saXN0IFtsc29ydCBbZ2V0X21zeW1fYWRkcnMgIiR7dmFy fSIgIiR7bXN5bWZpbGV9Il1dCisgICAgc2V0IGFkZHJfbGlzdCBbbHNvcnQg W2dldF9tc3ltX2FkZHJzICIke3Zhcn0iICIke21zeW1maWxlfSIgIiR7cGx1 c192YXJ9Il1dCiAgICAgc2V0IHByZXYgIiIKIAogICAgIGlmIHsgW2xsZW5n dGggJHthZGRyX2xpc3R9XSA8IDIgfSB7CkBAIC0yMzYsNyArMjQwLDEyIEBA IGlmIFtzZW5kX2dkYl9kaXNjYXJkICJtYWludCBwcmludCBtc3ltYm8KIAlm YWlsICIobXN5bWJvbCkgcmVsb2NhdGVkIGV4dGVybiB2YXJzIGhhdmUgZGlm ZmVyZW50IGFkZHJlc3NlcyIKICAgICB9CiAKLSAgICBpZiB7W2NoZWNrX2Rp ZmZlcmVudCAiZm5fXFsxMlxdIiAiJHttc3ltZmlsZX0iXX0geworICAgIGlm IHsoW2lzdGFyZ2V0ICIqcGMtY3lnd2luIl0gfHwgW2lzdGFyZ2V0ICIqcGMt bWluZ3czMiJdKSB9IHsKKwlzZXQgY2hlY2tfc3RyICJUIgorICAgIH0gZWxz ZSB7CisJc2V0IGNoZWNrX3N0ciAiIgorICAgIH0KKyAgICBpZiB7W2NoZWNr X2RpZmZlcmVudCAiZm5fXFsxMlxdIiAiJHttc3ltZmlsZX0iICIke2NoZWNr X3N0cn0iXX0gewogCXBhc3MgIihtc3ltYm9sKSByZWxvY2F0ZWQgZnVuY3Rp b25zIGhhdmUgZGlmZmVyZW50IGFkZHJlc3NlcyIKICAgICB9IGVsc2Ugewog CWZhaWwgIihtc3ltYm9sKSByZWxvY2F0ZWQgZnVuY3Rpb25zIGhhdmUgZGlm ZmVyZW50IGFkZHJlc3NlcyIK --e89a8ff1cd66a50ed704e5ef59db--