From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 781 invoked by alias); 6 Dec 2012 09:46:26 -0000 Received: (qmail 772 invoked by uid 22791); 6 Dec 2012 09:46:25 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-bk0-f41.google.com (HELO mail-bk0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 09:46:16 +0000 Received: by mail-bk0-f41.google.com with SMTP id jg9so2798483bkc.0 for ; Thu, 06 Dec 2012 01:46:14 -0800 (PST) Received: by 10.204.130.210 with SMTP id u18mr283619bks.129.1354787174433; Thu, 06 Dec 2012 01:46:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.205.32.12 with HTTP; Thu, 6 Dec 2012 01:45:34 -0800 (PST) From: Hui Zhu Date: Thu, 06 Dec 2012 09:46:00 -0000 Message-ID: Subject: [PATCH] Add fseek to ui-file To: Tom Tromey , gdb-patches ml Cc: Hui Zhu Content-Type: multipart/mixed; boundary=00151747bd5447455e04d02bf85b X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00104.txt.bz2 --00151747bd5447455e04d02bf85b Content-Type: text/plain; charset=ISO-8859-1 Content-length: 802 Hi Tom, According to your comments in "[PATCH] Add CTF support to GDB [1/4] Add "-ctf" to tsave command". I make this patch to add fseek to ui-file. Please help me review it. And stdio_file_fseek has a place different from the other stdio_file functions. It check the return of fseek. If it got error, it will throw error. If you think it is OK, I will post patch for other stdio_file functions. If not, it will update this patch. Thanks, Hui 2012-12-06 Hui Zhu * ui-file.c (ui_file): Add to_fseek. (ui_file_new): Call set_ui_file_fseek. (null_file_fseek, ui_file_fseek, set_ui_file_fseek, stdio_file_fseek): New functions. (stdio_file_new): Call set_ui_file_fseek. * ui-file.h (ui_file_fseek_ftype): New typedef. (set_ui_file_fseek, ui_file_fseek): New externs. --00151747bd5447455e04d02bf85b Content-Type: text/plain; charset=US-ASCII; name="ui-file-fseek.txt" Content-Disposition: attachment; filename="ui-file-fseek.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hadp8vid0 Content-length: 4767 LS0tIGEvdWktZmlsZS5jCisrKyBiL3VpLWZpbGUuYwpAQCAtMzYsNiArMzYs NyBAQCBzdGF0aWMgdWlfZmlsZV9mbHVzaF9mdHlwZSBudWxsX2ZpbGVfZmx1 CiBzdGF0aWMgdWlfZmlsZV9kZWxldGVfZnR5cGUgbnVsbF9maWxlX2RlbGV0 ZTsKIHN0YXRpYyB1aV9maWxlX3Jld2luZF9mdHlwZSBudWxsX2ZpbGVfcmV3 aW5kOwogc3RhdGljIHVpX2ZpbGVfcHV0X2Z0eXBlIG51bGxfZmlsZV9wdXQ7 CitzdGF0aWMgdWlfZmlsZV9mc2Vla19mdHlwZSBudWxsX2ZpbGVfZnNlZWs7 CiAKIHN0cnVjdCB1aV9maWxlCiAgIHsKQEAgLTQ5LDYgKzUwLDcgQEAgc3Ry dWN0IHVpX2ZpbGUKICAgICB1aV9maWxlX2lzYXR0eV9mdHlwZSAqdG9faXNh dHR5OwogICAgIHVpX2ZpbGVfcmV3aW5kX2Z0eXBlICp0b19yZXdpbmQ7CiAg ICAgdWlfZmlsZV9wdXRfZnR5cGUgKnRvX3B1dDsKKyAgICB1aV9maWxlX2Zz ZWVrX2Z0eXBlICp0b19mc2VlazsKICAgICB2b2lkICp0b19kYXRhOwogICB9 OwogaW50IHVpX2ZpbGVfbWFnaWM7CkBAIC02OCw2ICs3MCw3IEBAIHVpX2Zp bGVfbmV3ICh2b2lkKQogICBzZXRfdWlfZmlsZV9pc2F0dHkgKGZpbGUsIG51 bGxfZmlsZV9pc2F0dHkpOwogICBzZXRfdWlfZmlsZV9yZXdpbmQgKGZpbGUs IG51bGxfZmlsZV9yZXdpbmQpOwogICBzZXRfdWlfZmlsZV9wdXQgKGZpbGUs IG51bGxfZmlsZV9wdXQpOworICBzZXRfdWlfZmlsZV9mc2VlayAoZmlsZSwg bnVsbF9maWxlX2ZzZWVrKTsKICAgcmV0dXJuIGZpbGU7CiB9CiAKQEAgLTE3 MCw2ICsxNzMsMTIgQEAgbnVsbF9maWxlX2RlbGV0ZSAoc3RydWN0IHVpX2Zp bGUgKmZpbGUpCiAgIHJldHVybjsKIH0KIAorc3RhdGljIHZvaWQKK251bGxf ZmlsZV9mc2VlayAoc3RydWN0IHVpX2ZpbGUgKiBzdHJlYW0sIGxvbmcgb2Zm c2V0LCBpbnQgd2hlbmNlKQoreworICByZXR1cm47Cit9CisKIHZvaWQgKgog dWlfZmlsZV9kYXRhIChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSkKIHsKQEAgLTIy OCw2ICsyMzcsMTIgQEAgdWlfZmlsZV9yZWFkIChzdHJ1Y3QgdWlfZmlsZSAq ZmlsZSwgY2hhcgogfQogCiB2b2lkCit1aV9maWxlX2ZzZWVrIChzdHJ1Y3Qg dWlfZmlsZSAqIGZpbGUsIGxvbmcgb2Zmc2V0LCBpbnQgd2hlbmNlKQorewor ICBmaWxlLT50b19mc2VlayAoZmlsZSwgb2Zmc2V0LCB3aGVuY2UpOworfQor Cit2b2lkCiBmcHV0c191bmZpbHRlcmVkIChjb25zdCBjaGFyICpidWYsIHN0 cnVjdCB1aV9maWxlICpmaWxlKQogewogICBmaWxlLT50b19mcHV0cyAoYnVm LCBmaWxlKTsKQEAgLTI4NCw2ICsyOTksMTIgQEAgc2V0X3VpX2ZpbGVfZnB1 dHMgKHN0cnVjdCB1aV9maWxlICpmaWxlLAogfQogCiB2b2lkCitzZXRfdWlf ZmlsZV9mc2VlayAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHVpX2ZpbGVfZnNl ZWtfZnR5cGUgKmZzZWVrKQoreworICBmaWxlLT50b19mc2VlayA9IGZzZWVr OworfQorCit2b2lkCiBzZXRfdWlfZmlsZV9kYXRhIChzdHJ1Y3QgdWlfZmls ZSAqZmlsZSwgdm9pZCAqZGF0YSwKIAkJICB1aV9maWxlX2RlbGV0ZV9mdHlw ZSAqZGVsZXRlKQogewpAQCAtNDY5LDYgKzQ5MCw3IEBAIHN0YXRpYyB1aV9m aWxlX2lzYXR0eV9mdHlwZSBzdGRpb19maWxlX2kKIHN0YXRpYyB1aV9maWxl X2RlbGV0ZV9mdHlwZSBzdGRpb19maWxlX2RlbGV0ZTsKIHN0YXRpYyBzdHJ1 Y3QgdWlfZmlsZSAqc3RkaW9fZmlsZV9uZXcgKEZJTEUgKmZpbGUsIGludCBj bG9zZV9wKTsKIHN0YXRpYyB1aV9maWxlX2ZsdXNoX2Z0eXBlIHN0ZGlvX2Zp bGVfZmx1c2g7CitzdGF0aWMgdWlfZmlsZV9mc2Vla19mdHlwZSBzdGRpb19m aWxlX2ZzZWVrOwogCiBzdGF0aWMgaW50IHN0ZGlvX2ZpbGVfbWFnaWM7CiAK QEAgLTQ5OSw2ICs1MjEsNyBAQCBzdGRpb19maWxlX25ldyAoRklMRSAqZmls ZSwgaW50IGNsb3NlX3ApCiAgIHNldF91aV9maWxlX2ZwdXRzICh1aV9maWxl LCBzdGRpb19maWxlX2ZwdXRzKTsKICAgc2V0X3VpX2ZpbGVfcmVhZCAodWlf ZmlsZSwgc3RkaW9fZmlsZV9yZWFkKTsKICAgc2V0X3VpX2ZpbGVfaXNhdHR5 ICh1aV9maWxlLCBzdGRpb19maWxlX2lzYXR0eSk7CisgIHNldF91aV9maWxl X2ZzZWVrICh1aV9maWxlLCBzdGRpb19maWxlX2ZzZWVrKTsKICAgcmV0dXJu IHVpX2ZpbGU7CiB9CiAKQEAgLTYxNiw2ICs2MzksMTggQEAgc3RkaW9fZmls ZV9pc2F0dHkgKHN0cnVjdCB1aV9maWxlICpmaWxlKQogICByZXR1cm4gKGlz YXR0eSAoc3RkaW8tPmZkKSk7CiB9CiAKK3N0YXRpYyB2b2lkIHN0ZGlvX2Zp bGVfZnNlZWsgKHN0cnVjdCB1aV9maWxlICogZmlsZSwgbG9uZyBvZmZzZXQs IGludCB3aGVuY2UpCit7CisgIHN0cnVjdCBzdGRpb19maWxlICpzdGRpbyA9 IHVpX2ZpbGVfZGF0YSAoZmlsZSk7CisKKyAgaWYgKHN0ZGlvLT5tYWdpYyAh PSAmc3RkaW9fZmlsZV9tYWdpYykKKyAgICBpbnRlcm5hbF9lcnJvciAoX19G SUxFX18sIF9fTElORV9fLAorCQkgICAgXygic3RkaW9fZmlsZV9mc2Vlazog YmFkIG1hZ2ljIG51bWJlciIpKTsKKworICBpZiAoZnNlZWsgKHN0ZGlvLT5m aWxlLCBvZmZzZXQsIHdoZW5jZSkpCisgICAgZXJyb3IgKF8oImZzZWVrIGZh aWw6ICVzIiksIHNhZmVfc3RyZXJyb3IgKGVycm5vKSk7Cit9CisKIC8qIExp a2UgZmRvcGVuKCkuICBDcmVhdGUgYSB1aV9maWxlIGZyb20gYSBwcmV2aW91 c2x5IG9wZW5lZCBGSUxFLiAgKi8KIAogc3RydWN0IHVpX2ZpbGUgKgotLS0g YS91aS1maWxlLmgKKysrIGIvdWktZmlsZS5oCkBAIC03OSw2ICs3OSwxMSBA QCB0eXBlZGVmIHZvaWQgKHVpX2ZpbGVfZGVsZXRlX2Z0eXBlKSAoc3RyCiBl eHRlcm4gdm9pZCBzZXRfdWlfZmlsZV9kYXRhIChzdHJ1Y3QgdWlfZmlsZSAq c3RyZWFtLCB2b2lkICpkYXRhLAogCQkJICAgICAgdWlfZmlsZV9kZWxldGVf ZnR5cGUgKmRlbGV0ZSk7CiAKK3R5cGVkZWYgdm9pZCAodWlfZmlsZV9mc2Vl a19mdHlwZSkgKHN0cnVjdCB1aV9maWxlICogc3RyZWFtLCBsb25nIG9mZnNl dCwKKwkJCQkgICAgaW50IHdoZW5jZSk7CitleHRlcm4gdm9pZCBzZXRfdWlf ZmlsZV9mc2VlayAoc3RydWN0IHVpX2ZpbGUgKnN0cmVhbSwKKwkJCSAgICAg ICB1aV9maWxlX2ZzZWVrX2Z0eXBlICpmc2Vlayk7CisKIGV4dGVybiB2b2lk ICp1aV9maWxlX2RhdGEgKHN0cnVjdCB1aV9maWxlICpmaWxlKTsKIAogCkBA IC0xMTMsNiArMTE4LDggQEAgZXh0ZXJuIGNoYXIgKnVpX2ZpbGVfb2JzYXZl c3RyaW5nIChzdHJ1YwogCiBleHRlcm4gbG9uZyB1aV9maWxlX3JlYWQgKHN0 cnVjdCB1aV9maWxlICpmaWxlLCBjaGFyICpidWYsIGxvbmcgbGVuZ3RoX2J1 Zik7CiAKK2V4dGVybiB2b2lkIHVpX2ZpbGVfZnNlZWsgKHN0cnVjdCB1aV9m aWxlICogZmlsZSwgbG9uZyBvZmZzZXQsIGludCB3aGVuY2UpOworCiAvKiBD cmVhdGUvb3BlbiBhIG1lbW9yeSBiYXNlZCBmaWxlLiAgQ2FuIGJlIHVzZWQg YXMgYSBzY3JhdGNoIGJ1ZmZlcgogICAgZm9yIGNvbGxlY3Rpbmcgb3V0cHV0 LiAgKi8KIGV4dGVybiBzdHJ1Y3QgdWlfZmlsZSAqbWVtX2ZpbGVvcGVuICh2 b2lkKTsK --00151747bd5447455e04d02bf85b--