From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28787 invoked by alias); 20 Apr 2013 07:04:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28773 invoked by uid 89); 20 Apr 2013 07:04:58 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-ob0-f171.google.com (HELO mail-ob0-f171.google.com) (209.85.214.171) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 20 Apr 2013 07:04:57 +0000 Received: by mail-ob0-f171.google.com with SMTP id er7so4122174obc.2 for ; Sat, 20 Apr 2013 00:04:56 -0700 (PDT) X-Received: by 10.60.34.202 with SMTP id b10mr5803159oej.119.1366441496251; Sat, 20 Apr 2013 00:04:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Sat, 20 Apr 2013 00:04:16 -0700 (PDT) In-Reply-To: <87fvymwkbi.fsf@fleche.redhat.com> References: <87fvymwkbi.fsf@fleche.redhat.com> From: Hui Zhu Date: Mon, 22 Apr 2013 00:19:00 -0000 Message-ID: Subject: Re: [PATCH] Let dprintf can be saved To: Tom Tromey Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=089e013cc022fd91b804dac57372 X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00638.txt.bz2 --089e013cc022fd91b804dac57372 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 719 On Sat, Apr 20, 2013 at 12:34 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> +static void > Hui> +dprintf_print_recreate (struct breakpoint *tp, struct ui_file *fp) > > This needs a short introductory comment. > See the other print_recreate methods for examples. Fixed. > > I think this patch could use a test case. > It could be added wherever the existing "save" tests live. OK. I will post a patch for it later. Thanks, Hui > > Tom 2013-04-18 Hui Zhu PR gdb/15165 * breakpoint.c (dprintf_print_recreate): New. (save_breakpoints): Let it not save dprintf commands. (initialize_breakpoint_ops): Set dprintf_print_recreate. --089e013cc022fd91b804dac57372 Content-Type: text/plain; charset=US-ASCII; name="dprintf-save.txt" Content-Disposition: attachment; filename="dprintf-save.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfqfy5c10 Content-length: 1603 LS0tIGEvZ2RiL2JyZWFrcG9pbnQuYworKysgYi9nZGIvYnJlYWtwb2ludC5j CkBAIC0xMzM2NCw2ICsxMzM2NCwxNiBAQCBkcHJpbnRmX3JlX3NldCAoc3Ry dWN0IGJyZWFrcG9pbnQgKmIpCiAgICAgdXBkYXRlX2RwcmludGZfY29tbWFu ZF9saXN0IChiKTsKIH0KIAorLyogSW1wbGVtZW50IHRoZSAicHJpbnRfcmVj cmVhdGUiIGJyZWFrcG9pbnRfb3BzIG1ldGhvZCBmb3IgZHByaW50Zi4gICov CisKK3N0YXRpYyB2b2lkCitkcHJpbnRmX3ByaW50X3JlY3JlYXRlIChzdHJ1 Y3QgYnJlYWtwb2ludCAqdHAsIHN0cnVjdCB1aV9maWxlICpmcCkKK3sKKyAg ZnByaW50Zl91bmZpbHRlcmVkIChmcCwgImRwcmludGYgJXMlcyIsIHRwLT5h ZGRyX3N0cmluZywKKwkJICAgICAgdHAtPmV4dHJhX3N0cmluZyk7CisgIHBy aW50X3JlY3JlYXRlX3RocmVhZCAodHAsIGZwKTsKK30KKwogLyogVGhlIGJy ZWFrcG9pbnRfb3BzIHN0cnVjdHVyZSB0byBiZSB1c2VkIG9uIHN0YXRpYyB0 cmFjZXBvaW50cyB3aXRoCiAgICBtYXJrZXJzIChgLW0nKS4gICovCiAKQEAg LTE1NDUzLDcgKzE1NDYzLDcgQEAgc2F2ZV9icmVha3BvaW50cyAoY2hhciAq ZmlsZW5hbWUsIGludCBmcgogICAgIGlmICh0cC0+aWdub3JlX2NvdW50KQog ICAgICAgZnByaW50Zl91bmZpbHRlcmVkIChmcCwgIiAgaWdub3JlICRicG51 bSAlZFxuIiwgdHAtPmlnbm9yZV9jb3VudCk7CiAKLSAgICBpZiAodHAtPmNv bW1hbmRzKQorICAgIGlmICh0cC0+dHlwZSAhPSBicF9kcHJpbnRmICYmIHRw LT5jb21tYW5kcykKICAgICAgIHsKIAl2b2xhdGlsZSBzdHJ1Y3QgZ2RiX2V4 Y2VwdGlvbiBleDsJCiAKQEAgLTE1ODU5LDcgKzE1ODY5LDcgQEAgaW5pdGlh bGl6ZV9icmVha3BvaW50X29wcyAodm9pZCkKICAgb3BzLT5yZXNvdXJjZXNf bmVlZGVkID0gYmtwdF9yZXNvdXJjZXNfbmVlZGVkOwogICBvcHMtPnByaW50 X2l0ID0gYmtwdF9wcmludF9pdDsKICAgb3BzLT5wcmludF9tZW50aW9uID0g YmtwdF9wcmludF9tZW50aW9uOwotICBvcHMtPnByaW50X3JlY3JlYXRlID0g YmtwdF9wcmludF9yZWNyZWF0ZTsKKyAgb3BzLT5wcmludF9yZWNyZWF0ZSA9 IGRwcmludGZfcHJpbnRfcmVjcmVhdGU7CiB9CiAKIC8qIENoYWluIGNvbnRh aW5pbmcgYWxsIGRlZmluZWQgImVuYWJsZSBicmVha3BvaW50IiBzdWJjb21t YW5kcy4gICovCg== --089e013cc022fd91b804dac57372--