On Sat, Apr 20, 2013 at 12:34 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> +static void > Hui> +dprintf_print_recreate (struct breakpoint *tp, struct ui_file *fp) > > This needs a short introductory comment. > See the other print_recreate methods for examples. Fixed. > > I think this patch could use a test case. > It could be added wherever the existing "save" tests live. OK. I will post a patch for it later. Thanks, Hui > > Tom 2013-04-18 Hui Zhu PR gdb/15165 * breakpoint.c (dprintf_print_recreate): New. (save_breakpoints): Let it not save dprintf commands. (initialize_breakpoint_ops): Set dprintf_print_recreate.