From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4360 invoked by alias); 7 Jul 2013 05:54:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4241 invoked by uid 89); 7 Jul 2013 05:54:19 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS,TW_RG autolearn=ham version=3.3.1 Received: from mail-ob0-f176.google.com (HELO mail-ob0-f176.google.com) (209.85.214.176) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 07 Jul 2013 05:54:17 +0000 Received: by mail-ob0-f176.google.com with SMTP id v19so4316304obq.21 for ; Sat, 06 Jul 2013 22:54:15 -0700 (PDT) X-Received: by 10.60.160.194 with SMTP id xm2mr16892481oeb.82.1373176455756; Sat, 06 Jul 2013 22:54:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.116.101 with HTTP; Sat, 6 Jul 2013 22:53:35 -0700 (PDT) In-Reply-To: <51D42272.20209@codesourcery.com> References: <51D2E749.9020604@codesourcery.com> <51D4030F.6070000@codesourcery.com> <51D42272.20209@codesourcery.com> From: Hui Zhu Date: Sun, 07 Jul 2013 05:54:00 -0000 Message-ID: Subject: Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes To: Yao Qi Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=089e0117683fdc009f04e0e58eb7 X-Virus-Found: No X-SW-Source: 2013-07/txt/msg00220.txt.bz2 --089e0117683fdc009f04e0e58eb7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 630 On Wed, Jul 3, 2013 at 9:09 PM, Yao Qi wrote: > On 07/03/2013 08:02 PM, Hui Zhu wrote: >> >> + if { $args =3D=3D "call" || $args =3D=3D "fprintf" } { >> + set foobarbazqux "foobarbazqux.*" > > > To match the double quotes, please consider: > > set foobarbazqux "\"foobarbazqux\"" > > -- > Yao (=E9=BD=90=E5=B0=A7) Post a new version about that. Thanks, Hui 2013-07-07 Hui Zhu PR gdb/15692 mi/mi-cmd-break.c (mi_argv_to_format): Handle double quotes. 2013-07-07 Hui Zhu PR gdb/15692 gdb.mi/mi-dprintf.exp: Add double quotes test. --089e0117683fdc009f04e0e58eb7 Content-Type: text/plain; charset=US-ASCII; name="dprintf-mi-handle-quotes.txt" Content-Disposition: attachment; filename="dprintf-mi-handle-quotes.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hittrsy20 Content-length: 452 LS0tIGEvZ2RiL21pL21pLWNtZC1icmVhay5jCisrKyBiL2dkYi9taS9taS1j bWQtYnJlYWsuYwpAQCAtMTI4LDYgKzEyOCw5IEBAIG1pX2FyZ3ZfdG9fZm9y bWF0IChjaGFyICoqYXJndiwgaW50IGFyZ2MKIAljYXNlICdcdic6CiAJICBv YnN0YWNrX2dyb3cgKCZvYnN0YWNrLCAiXFx2IiwgMik7CiAJICBicmVhazsK KwljYXNlICciJzoKKwkgIG9ic3RhY2tfZ3JvdyAoJm9ic3RhY2ssICJcXFwi IiwgMik7CisJICBicmVhazsKIAlkZWZhdWx0OgogCSAgaWYgKGlzcHJpbnQg KGFyZ3ZbMF1baV0pKQogCSAgICBvYnN0YWNrX2dyb3cgKCZvYnN0YWNrLCBh cmd2WzBdICsgaSwgMSk7Cg== --089e0117683fdc009f04e0e58eb7 Content-Type: text/plain; charset=US-ASCII; name="dprintf-mi-handle-quotes-test.txt" Content-Disposition: attachment; filename="dprintf-mi-handle-quotes-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hitts25l1 Content-length: 1936 LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkvbWktZHByaW50Zi5leHAKKysr IGIvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkvbWktZHByaW50Zi5leHAKQEAgLTQ4 LDcgKzQ4LDcgQEAgbWlfZ2RiX3Rlc3QgIjMtZHByaW50Zi1pbnNlcnQgMjki IFwKIG1pX2dkYl90ZXN0ICItYnJlYWstaW5zZXJ0IG1haW4iICIuKiIgIm1p IGluc2VydCBicmVha3BvaW50IG1haW4iCiBtaV9kZWxldGVfYnJlYWtwb2lu dHMKIAotbWlfZ2RiX3Rlc3QgIjQtZHByaW50Zi1pbnNlcnQgZm9vIFwiQXQg Zm9vIGVudHJ5XFxuXCIiIFwKK21pX2dkYl90ZXN0ICI0LWRwcmludGYtaW5z ZXJ0IGZvbyBcIlxcXCJmb29iYXJiYXpxdXhcXFwiIEF0IGZvbyBlbnRyeVxc blwiIiBcCiAgICAgIjRcXF5kb25lLGJrcHQ9XHtudW1iZXI9XCIuKlwiLHR5 cGU9XCJkcHJpbnRmXCIuKmZ1bmM9XCJmb29cIixmaWxlPVwiLiptaS1kcHJp bnRmLmNcIixmdWxsbmFtZT1cIi4qbWktZHByaW50Zi5jXCIsbGluZT1cIi4q XCIuKiIgIm1pIGluc2VydCBkcHJpbnRmIGZvbyIKIAogbWlfZ2RiX3Rlc3Qg IjUtZHByaW50Zi1pbnNlcnQgJGRwX2xvY2F0aW9uMSBcImFyZz0lZCwgZz0l ZFxcblwiIGFyZyBnIiBcCkBAIC02NSwxMCArNjUsMTYgQEAgcHJvYyBtaV9j b250aW51ZV9kcHJpbnRmIHthcmdzfSB7CiAgICAgd2l0aF90ZXN0X3ByZWZp eCAkYXJncyB7CiAJZ2xvYmFsIG1pX2dkYl9wcm9tcHQKIAorCWlmIHsgJGFy Z3MgPT0gImNhbGwiIHx8ICRhcmdzID09ICJmcHJpbnRmIiB9IHsKKwkgICAg c2V0IGZvb2JhcmJhenF1eCAiXCJmb29iYXJiYXpxdXhcIiIKKwl9IGVsc2Ug eworCSAgICBzZXQgZm9vYmFyYmF6cXV4ICJcXFxcXCJmb29iYXJiYXpxdXhc XFxcXCIiCisJfQorCiAJbWlfcnVuX2NtZAogCXNldCBtc2cgIm1pIDFzdCBk cHJpbnRmIgogCWdkYl9leHBlY3QgewotICAgICAgICAgICAgLXJlICIuKkF0 IGZvbyBlbnRyeS4qYXJnPTEyMzQsIGc9MTIzNCIgeworICAgICAgICAgICAg LXJlICIuKiRmb29iYXJiYXpxdXggQXQgZm9vIGVudHJ5Liphcmc9MTIzNCwg Zz0xMjM0IiB7CiAJCXBhc3MgJG1zZwogCSAgICB9CiAJICAgIC1yZSAiLiok bWlfZ2RiX3Byb21wdCQiIHsKQEAgLTgzLDcgKzg5LDcgQEAgcHJvYyBtaV9j b250aW51ZV9kcHJpbnRmIHthcmdzfSB7CiAJc2V0IG1zZyAibWkgMm5kIGRw cmludGYiCiAJbWlfc2VuZF9yZXN1bWluZ19jb21tYW5kICJleGVjLWNvbnRp bnVlIiAiJG1zZyBjb250aW51ZSIKIAlnZGJfZXhwZWN0IHsKLSAgICAgICAg ICAgIC1yZSAiLipBdCBmb28gZW50cnkuKmFyZz0xMjM1LCBnPTIyMjIiIHsK KyAgICAgICAgICAgIC1yZSAiLiokZm9vYmFyYmF6cXV4IEF0IGZvbyBlbnRy eS4qYXJnPTEyMzUsIGc9MjIyMiIgewogCQlwYXNzICRtc2cKIAkgICAgfQog CSAgICAtcmUgIi4qJG1pX2dkYl9wcm9tcHQkIiB7Cg== --089e0117683fdc009f04e0e58eb7--