From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12396 invoked by alias); 16 Apr 2013 09:31:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12387 invoked by uid 89); 16 Apr 2013 09:31:58 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-oa0-f51.google.com (HELO mail-oa0-f51.google.com) (209.85.219.51) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Apr 2013 09:31:57 +0000 Received: by mail-oa0-f51.google.com with SMTP id k14so273361oag.38 for ; Tue, 16 Apr 2013 02:31:56 -0700 (PDT) X-Received: by 10.182.66.11 with SMTP id b11mr496413obt.62.1366104716261; Tue, 16 Apr 2013 02:31:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Tue, 16 Apr 2013 02:31:16 -0700 (PDT) In-Reply-To: <83ppy19cph.fsf@gnu.org> References: <51665508.5050706@mentor.com> <516655D7.3000403@mentor.com> <83ppy19cph.fsf@gnu.org> From: Hui Zhu Date: Tue, 16 Apr 2013 15:39:00 -0000 Message-ID: Subject: Re: [PATCH] store trace default-collect to target [5/6] doc To: Eli Zaretskii , Yao Qi Cc: Hui Zhu , gdb-patches ml Content-Type: multipart/mixed; boundary=e89a8fb1eac656c49004da770a28 X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00467.txt.bz2 --e89a8fb1eac656c49004da770a28 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1365 Hi Eli, Thanks for your review. On Fri, Apr 12, 2013 at 1:52 AM, Eli Zaretskii wrote: >> Date: Thu, 11 Apr 2013 14:19:03 +0800 >> From: Hui Zhu >> >> This patch is doc update for "QTDDCsrc" and "qTDC". > > Thanks. > >> +@item QTDDCsrc:@var{bytes} >> +@cindex define default collect, remote request >> +@cindex @samp{QTDDCsrc} packet >> +@var{bytes} is the string, encoded in hexadecimal. >> +It specify a source string of default collect. > ^^^^^^^ > "specifies" > > By the way, why is it called a "source" string? Because it is same with QTDPsrc: string, encoded in hexadecimal. I think it is not very good for this part now. So I removed it. > >> +These packets request default collect on the target. Replies to >> +this packet generally take the form of the @code{QTDDCsrc} packet that >> +define default collect. > ^^^^^^ > "defines" Fixed. > >> +Replies: >> +@table @samp >> +@item DC@var{bytes} >> +@var{bytes} is the string, encoded in hexadecimal. It take the form of >> +the @code{QTDDCsrc} packet that define default collect.^^^^ > ^^^^^^ > "takes" and "defines" Fixed. > > OK with those changes. Post a new version. Please help me review. Best, Hui 2013-04-16 Hui Zhu * gdb.texinfo (Tracepoint Packets) Add "QTDDCsrc" and "qTDC". --e89a8fb1eac656c49004da770a28 Content-Type: text/plain; charset=US-ASCII; name="defc-doc.txt" Content-Disposition: attachment; filename="defc-doc.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfkvg6jr0 Content-length: 2859 LS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC00NSw2ICs0NSwxNCBAQCBzaG93 IHJlbW90ZSB0cmFjZS1zdGF0dXMtcGFja2V0CiAgICoqIFRoZSAtdHJhY2Ut c2F2ZSBNSSBjb21tYW5kIGNhbiBvcHRpb25hbGx5IHNhdmUgdHJhY2UgYnVm ZmVyIGluIENvbW1vbgogICAgICBUcmFjZSBGb3JtYXQgbm93LgogCisqIE5l dyByZW1vdGUgcGFja2V0cworCitRVEREQ3NyYworICAgRG93bmxvYWQgdHJh Y2UgZGVmYXVsdCBjb2xsZWN0IHN0cmluZyB0byB0YXJnZXQuCisKK3FUREMK KyAgIFJlcXVlc3QgdGFyZ2V0IHVwbG9hZCB0cmFjZSBkZWZhdWx0IGNvbGxl Y3QuCisKICoqKiBDaGFuZ2VzIGluIEdEQiA3LjYKIAogKiBUYXJnZXQgcmVj b3JkIGhhcyBiZWVuIHJlbmFtZWQgdG8gcmVjb3JkLWZ1bGwuCi0tLSBhL2Rv Yy9nZGIudGV4aW5mbworKysgYi9kb2MvZ2RiLnRleGluZm8KQEAgLTM3ODI1 LDggKzM3ODI1LDEwIEBAIGVuY29kZWQpLiAgQHZhbHVle0dEQk59IHdpbGwg Y29udGludWUgdG8KIEBpdGVteCBRVERQCiBAaXRlbXggUVREUHNyYwogQGl0 ZW14IFFURFYKK0BpdGVteCBRVEREQ3NyYwogQGl0ZW14IHFUZlAKIEBpdGVt eCBxVGZWCitAaXRlbXggcVREQwogQGl0ZW14IFFURnJhbWUKIEBpdGVteCBx VE1pbkZUUElMZW4KIApAQCAtMzg0MTUsNiArMzg0MTcsMjIgQEAgdGhlIG9w dGlvbiBvZiBub3QgdXNpbmcgdGhpcyBwYWNrZXQgZm9yCiB0YXJnZXQgc2hv dWxkIHNpbXBseSBjcmVhdGUgdGhlIHRyYWNlIHN0YXRlIHZhcmlhYmxlcyBh cyB0aGV5IGFyZQogbWVudGlvbmVkIGluIGV4cHJlc3Npb25zLgogCitAaXRl bSBRVEREQ3NyYzpAdmFye2J5dGVzfQorQGNpbmRleCBkZWZpbmUgZGVmYXVs dCBjb2xsZWN0LCByZW1vdGUgcmVxdWVzdAorQGNpbmRleCBAc2FtcHtRVERE Q3NyY30gcGFja2V0CitAdmFye2J5dGVzfSBpcyB0aGUgc3RyaW5nLCBlbmNv ZGVkIGluIGhleGFkZWNpbWFsLgorSXQgc3BlY2lmaWVzIGEgc3RyaW5nIG9m IGRlZmF1bHQgY29sbGVjdC4KK1RoZSB0YXJnZXQgZG9lcyBub3QgbmVlZCB0 byBkbyBhbnl0aGluZyB3aXRoIHNvdXJjZSBzdHJpbmdzIGV4Y2VwdAorcmVw b3J0IHRoZW0gYmFjayBhcyBwYXJ0IG9mIHRoZSByZXBsaWVzIHRvIHRoZSBA c2FtcHtxVERDfSBxdWVyeSBwYWNrZXRzLgorCitSZXBsaWVzOgorQHRhYmxl IEBzYW1wCitAaXRlbSBPSworVGhlIHBhY2tldCB3YXMgdW5kZXJzdG9vZCBh bmQgY2FycmllZCBvdXQuCitAaXRlbSAgQHd7fQorVGhlIHBhY2tldCB3YXMg bm90IHJlY29nbml6ZWQuCitAZW5kIHRhYmxlCisKIEBpdGVtIFFURnJhbWU6 QHZhcntufQogQGNpbmRleCBAc2FtcHtRVEZyYW1lfSBwYWNrZXQKIFNlbGVj dCB0aGUgQHZhcntufSd0aCB0cmFjZXBvaW50IGZyYW1lIGZyb20gdGhlIGJ1 ZmZlciwgYW5kIHVzZSB0aGUKQEAgLTM4NjcwLDYgKzM4Njg4LDI0IEBAIGFu ZCBtdWx0aXBsZSBAY29kZXtxVHNWfSB0byBnZXQgYWRkaXRpb24KIHRoZXNl IHBhY2tldHMgZm9sbG93IHRoZSBzeW50YXggb2YgdGhlIEBjb2Rle1FURFZ9 IHBhY2tldHMgdGhhdCBkZWZpbmUKIHRyYWNlIHN0YXRlIHZhcmlhYmxlcy4K IAorQGl0ZW0gcVREQworQGNpbmRleCBAc2FtcHtxVERDfSBwYWNrZXQKK0Bp dGVteCBxVERDCitAY2luZGV4IEBzYW1we3FUREN9IHBhY2tldAorVGhlc2Ug cGFja2V0cyByZXF1ZXN0IGRlZmF1bHQgY29sbGVjdCBvbiB0aGUgdGFyZ2V0 LiAgUmVwbGllcyB0bwordGhpcyBwYWNrZXQgZ2VuZXJhbGx5IHRha2UgdGhl IGZvcm0gb2YgdGhlIEBjb2Rle1FURERDc3JjfSBwYWNrZXQgdGhhdAorZGVm aW5lcyBkZWZhdWx0IGNvbGxlY3QuCisKK1JlcGxpZXM6CitAdGFibGUgQHNh bXAKK0BpdGVtIERDQHZhcntieXRlc30KK0B2YXJ7Ynl0ZXN9IGlzIHRoZSBz dHJpbmcsIGVuY29kZWQgaW4gaGV4YWRlY2ltYWwuICBJdCB0YWtlcyB0aGUg Zm9ybSBvZgordGhlIEBjb2Rle1FURERDc3JjfSBwYWNrZXQgdGhhdCBkZWZp bmVzIGRlZmF1bHQgY29sbGVjdC4KKworQGl0ZW0gIEB3e30KK1RoZSBwYWNr ZXQgd2FzIG5vdCByZWNvZ25pemVkLgorQGVuZCB0YWJsZQorCiBAaXRlbSBx VGZTVE0KIEBpdGVteCBxVHNTVE0KIEBhbmNob3J7cVRmU1RNfQo= --e89a8fb1eac656c49004da770a28--