From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14581 invoked by alias); 6 Sep 2011 08:22:50 -0000 Received: (qmail 14568 invoked by uid 22791); 6 Sep 2011 08:22:48 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Sep 2011 08:22:34 +0000 Received: by fxg9 with SMTP id 9so4830254fxg.0 for ; Tue, 06 Sep 2011 01:22:33 -0700 (PDT) Received: by 10.223.85.154 with SMTP id o26mr1380207fal.72.1315297353297; Tue, 06 Sep 2011 01:22:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.112.68 with HTTP; Tue, 6 Sep 2011 01:21:53 -0700 (PDT) In-Reply-To: References: From: Hui Zhu Date: Tue, 06 Sep 2011 08:50:00 -0000 Message-ID: Subject: Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory To: Tom Tromey Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=001517402656846e8704ac41878c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00084.txt.bz2 --001517402656846e8704ac41878c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 775 On Fri, Aug 19, 2011 at 22:14, Tom Tromey wrote: >>>>>> ">" =3D=3D Hui Zhu writes: > > Tom> This test seems odd to me. =A0Why does the lvalue-ness of the value > Tom> matter? > >>> I don't understand your means, could you do some explain? > > I just don't understand why a check of the VALUE_LVAL is necessary. > Does something go wrong in the other cases? =A0It doesn't seem to me that > it should. > > Tom > Got it. I make a new patch remove the line: >> + if ((VALUE_LVAL (val_args[i]) =3D=3D lval_internalvar >> + || VALUE_LVAL (val_args[i]) =3D=3D not_lval) Please help me review it. Thanks, Hui 2011-09-06 Hui Zhu * printcmd.c (ui_printf): Add a handler for TYPE_CODE_ARRAY. --001517402656846e8704ac41878c Content-Type: text/plain; charset=US-ASCII; name="fix-v-string.txt" Content-Disposition: attachment; filename="fix-v-string.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gs8m034i0 Content-length: 2347 LS0tCiBwcmludGNtZC5jIHwgICA0NyArKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI2 IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQoKLS0tIGEvcHJpbnRj bWQuYworKysgYi9wcmludGNtZC5jCkBAIC0yMzQzLDMyICsyMzQzLDM3IEBA IHVpX3ByaW50ZiAoY2hhciAqYXJnLCBzdHJ1Y3QgdWlfZmlsZSAqc3QKIAlz d2l0Y2ggKGFyZ2NsYXNzW2ldKQogCSAgewogCSAgY2FzZSBzdHJpbmdfYXJn OgotCSAgICB7Ci0JICAgICAgZ2RiX2J5dGUgKnN0cjsKLQkgICAgICBDT1JF X0FERFIgdGVtOwotCSAgICAgIGludCBqOworICAgICAgICAgICAgaWYgKFRZ UEVfQ09ERSAoY2hlY2tfdHlwZWRlZiAodmFsdWVfdHlwZSAodmFsX2FyZ3Nb aV0pKSkKKwkJICAgID09IFRZUEVfQ09ERV9BUlJBWSkKKwkgICAgICBmcHJp bnRmX2ZpbHRlcmVkIChzdHJlYW0sIGN1cnJlbnRfc3Vic3RyaW5nLAorCQkJ CShjaGFyICopIHZhbHVlX2NvbnRlbnRzICh2YWxfYXJnc1tpXSkpOworCSAg ICBlbHNlCisJICAgICAgeworCSAgICAgICAgZ2RiX2J5dGUgKnN0cjsKKwkg ICAgICAgIENPUkVfQUREUiB0ZW07CisJICAgICAgICBpbnQgajsKIAotCSAg ICAgIHRlbSA9IHZhbHVlX2FzX2FkZHJlc3MgKHZhbF9hcmdzW2ldKTsKKwkg ICAgICAgIHRlbSA9IHZhbHVlX2FzX2FkZHJlc3MgKHZhbF9hcmdzW2ldKTsK IAotCSAgICAgIC8qIFRoaXMgaXMgYSAlcyBhcmd1bWVudC4gIEZpbmQgdGhl IGxlbmd0aCBvZiB0aGUgc3RyaW5nLiAgKi8KLQkgICAgICBmb3IgKGogPSAw OzsgaisrKQotCQl7Ci0JCSAgZ2RiX2J5dGUgYzsKKwkgICAgICAgIC8qIFRo aXMgaXMgYSAlcyBhcmd1bWVudC4gIEZpbmQgdGhlIGxlbmd0aCBvZiB0aGUg c3RyaW5nLiAgKi8KKwkgICAgICAgIGZvciAoaiA9IDA7OyBqKyspCisJCSAg eworCQkgICAgZ2RiX2J5dGUgYzsKIAotCQkgIFFVSVQ7Ci0JCSAgcmVhZF9t ZW1vcnkgKHRlbSArIGosICZjLCAxKTsKLQkJICBpZiAoYyA9PSAwKQotCQkg ICAgYnJlYWs7Ci0JCX0KKwkJICAgIFFVSVQ7CisJCSAgICByZWFkX21lbW9y eSAodGVtICsgaiwgJmMsIDEpOworCQkgICAgaWYgKGMgPT0gMCkKKwkJICAg ICAgYnJlYWs7CisJCSAgfQogCi0JICAgICAgLyogQ29weSB0aGUgc3RyaW5n IGNvbnRlbnRzIGludG8gYSBzdHJpbmcgaW5zaWRlIEdEQi4gICovCi0JICAg ICAgc3RyID0gKGdkYl9ieXRlICopIGFsbG9jYSAoaiArIDEpOwotCSAgICAg IGlmIChqICE9IDApCi0JCXJlYWRfbWVtb3J5ICh0ZW0sIHN0ciwgaik7Ci0J ICAgICAgc3RyW2pdID0gMDsKKwkgICAgICAgIC8qIENvcHkgdGhlIHN0cmlu ZyBjb250ZW50cyBpbnRvIGEgc3RyaW5nIGluc2lkZSBHREIuICAqLworCSAg ICAgICAgc3RyID0gKGdkYl9ieXRlICopIGFsbG9jYSAoaiArIDEpOworCSAg ICAgICAgaWYgKGogIT0gMCkKKwkJICByZWFkX21lbW9yeSAodGVtLCBzdHIs IGopOworCSAgICAgICAgc3RyW2pdID0gMDsKIAotICAgICAgICAgICAgICBm cHJpbnRmX2ZpbHRlcmVkIChzdHJlYW0sIGN1cnJlbnRfc3Vic3RyaW5nLCAo Y2hhciAqKSBzdHIpOwotCSAgICB9CisgICAgICAgICAgICAgICAgZnByaW50 Zl9maWx0ZXJlZCAoc3RyZWFtLCBjdXJyZW50X3N1YnN0cmluZywgKGNoYXIg Kikgc3RyKTsKKwkgICAgICB9CiAJICAgIGJyZWFrOwogCSAgY2FzZSB3aWRl X3N0cmluZ19hcmc6CiAJICAgIHsK --001517402656846e8704ac41878c--