On Fri, Aug 19, 2011 at 22:14, Tom Tromey wrote: >>>>>> ">" == Hui Zhu writes: > > Tom> This test seems odd to me.  Why does the lvalue-ness of the value > Tom> matter? > >>> I don't understand your means, could you do some explain? > > I just don't understand why a check of the VALUE_LVAL is necessary. > Does something go wrong in the other cases?  It doesn't seem to me that > it should. > > Tom > Got it. I make a new patch remove the line: >> + if ((VALUE_LVAL (val_args[i]) == lval_internalvar >> + || VALUE_LVAL (val_args[i]) == not_lval) Please help me review it. Thanks, Hui 2011-09-06 Hui Zhu * printcmd.c (ui_printf): Add a handler for TYPE_CODE_ARRAY.