From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26959 invoked by alias); 12 Dec 2012 11:01:12 -0000 Received: (qmail 26946 invoked by uid 22791); 12 Dec 2012 11:01:11 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-bk0-f41.google.com (HELO mail-bk0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 11:01:05 +0000 Received: by mail-bk0-f41.google.com with SMTP id jg9so247382bkc.0 for ; Wed, 12 Dec 2012 03:01:04 -0800 (PST) Received: by 10.204.130.210 with SMTP id u18mr315489bks.129.1355310063976; Wed, 12 Dec 2012 03:01:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.226.140 with HTTP; Wed, 12 Dec 2012 03:00:22 -0800 (PST) In-Reply-To: <87vcc9el7d.fsf@fleche.redhat.com> References: <87txryx36w.fsf@fleche.redhat.com> <87lid9x6hl.fsf@fleche.redhat.com> <87vcc9el7d.fsf@fleche.redhat.com> From: Hui Zhu Date: Wed, 12 Dec 2012 11:01:00 -0000 Message-ID: Subject: Re: [PATCH] Add fseek to ui-file To: Tom Tromey Cc: gdb-patches ml , Hui Zhu Content-Type: multipart/mixed; boundary=00151747bd54ec802104d0a5b6fd X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00378.txt.bz2 --00151747bd54ec802104d0a5b6fd Content-Type: text/plain; charset=ISO-8859-1 Content-length: 737 On Tue, Dec 11, 2012 at 3:55 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> Post a patch for that. Please help me review it. > > I think _p is not a super choice for a suffix. > It already has a meaning in gdb. > "_ptr" or most anything else would be better. > > Tom Post a new version. Please help me review it. Best, Hui 2012-12-12 Hui Zhu * ui-file.c (ui_file): Add to_fseek. (ui_file_new): Call set_ui_file_fseek. (null_file_fseek, ui_file_fseek, set_ui_file_fseek, stdio_file_fseek): New functions. (stdio_file_new): Call set_ui_file_fseek. * ui-file.h (ui_file_fseek_ftype): New typedef. (set_ui_file_fseek, ui_file_fseek): New externs. --00151747bd54ec802104d0a5b6fd Content-Type: text/plain; charset=US-ASCII; name="ui-file-fseek.txt" Content-Disposition: attachment; filename="ui-file-fseek.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hamcl5640 Content-length: 4742 LS0tIGEvdWktZmlsZS5jCisrKyBiL3VpLWZpbGUuYwpAQCAtMzYsNiArMzYs NyBAQCBzdGF0aWMgdWlfZmlsZV9mbHVzaF9mdHlwZSBudWxsX2ZpbGVfZmx1 CiBzdGF0aWMgdWlfZmlsZV9kZWxldGVfZnR5cGUgbnVsbF9maWxlX2RlbGV0 ZTsKIHN0YXRpYyB1aV9maWxlX3Jld2luZF9mdHlwZSBudWxsX2ZpbGVfcmV3 aW5kOwogc3RhdGljIHVpX2ZpbGVfcHV0X2Z0eXBlIG51bGxfZmlsZV9wdXQ7 CitzdGF0aWMgdWlfZmlsZV9mc2Vla19mdHlwZSBudWxsX2ZpbGVfZnNlZWs7 CiAKIHN0cnVjdCB1aV9maWxlCiAgIHsKQEAgLTQ5LDYgKzUwLDcgQEAgc3Ry dWN0IHVpX2ZpbGUKICAgICB1aV9maWxlX2lzYXR0eV9mdHlwZSAqdG9faXNh dHR5OwogICAgIHVpX2ZpbGVfcmV3aW5kX2Z0eXBlICp0b19yZXdpbmQ7CiAg ICAgdWlfZmlsZV9wdXRfZnR5cGUgKnRvX3B1dDsKKyAgICB1aV9maWxlX2Zz ZWVrX2Z0eXBlICp0b19mc2VlazsKICAgICB2b2lkICp0b19kYXRhOwogICB9 OwogaW50IHVpX2ZpbGVfbWFnaWM7CkBAIC02OCw2ICs3MCw3IEBAIHVpX2Zp bGVfbmV3ICh2b2lkKQogICBzZXRfdWlfZmlsZV9pc2F0dHkgKGZpbGUsIG51 bGxfZmlsZV9pc2F0dHkpOwogICBzZXRfdWlfZmlsZV9yZXdpbmQgKGZpbGUs IG51bGxfZmlsZV9yZXdpbmQpOwogICBzZXRfdWlfZmlsZV9wdXQgKGZpbGUs IG51bGxfZmlsZV9wdXQpOworICBzZXRfdWlfZmlsZV9mc2VlayAoZmlsZSwg bnVsbF9maWxlX2ZzZWVrKTsKICAgcmV0dXJuIGZpbGU7CiB9CiAKQEAgLTE3 MCw2ICsxNzMsMTIgQEAgbnVsbF9maWxlX2RlbGV0ZSAoc3RydWN0IHVpX2Zp bGUgKmZpbGUpCiAgIHJldHVybjsKIH0KIAorc3RhdGljIGludAorbnVsbF9m aWxlX2ZzZWVrIChzdHJ1Y3QgdWlfZmlsZSAqc3RyZWFtLCBsb25nIG9mZnNl dCwgaW50IHdoZW5jZSkKK3sKKyAgcmV0dXJuIDA7Cit9CisKIHZvaWQgKgog dWlfZmlsZV9kYXRhIChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSkKIHsKQEAgLTIy Nyw2ICsyMzYsMTIgQEAgdWlfZmlsZV9yZWFkIChzdHJ1Y3QgdWlfZmlsZSAq ZmlsZSwgY2hhcgogICByZXR1cm4gZmlsZS0+dG9fcmVhZCAoZmlsZSwgYnVm LCBsZW5ndGhfYnVmKTsgCiB9CiAKK2ludAordWlfZmlsZV9mc2VlayAoc3Ry dWN0IHVpX2ZpbGUgKmZpbGUsIGxvbmcgb2Zmc2V0LCBpbnQgd2hlbmNlKQor eworICByZXR1cm4gZmlsZS0+dG9fZnNlZWsgKGZpbGUsIG9mZnNldCwgd2hl bmNlKTsKK30KKwogdm9pZAogZnB1dHNfdW5maWx0ZXJlZCAoY29uc3QgY2hh ciAqYnVmLCBzdHJ1Y3QgdWlfZmlsZSAqZmlsZSkKIHsKQEAgLTI4NCw2ICsy OTksMTIgQEAgc2V0X3VpX2ZpbGVfZnB1dHMgKHN0cnVjdCB1aV9maWxlICpm aWxlLAogfQogCiB2b2lkCitzZXRfdWlfZmlsZV9mc2VlayAoc3RydWN0IHVp X2ZpbGUgKmZpbGUsIHVpX2ZpbGVfZnNlZWtfZnR5cGUgKmZzZWVrX3B0cikK K3sKKyAgZmlsZS0+dG9fZnNlZWsgPSBmc2Vla19wdHI7Cit9CisKK3ZvaWQK IHNldF91aV9maWxlX2RhdGEgKHN0cnVjdCB1aV9maWxlICpmaWxlLCB2b2lk ICpkYXRhLAogCQkgIHVpX2ZpbGVfZGVsZXRlX2Z0eXBlICpkZWxldGVfcHRy KQogewpAQCAtNDY5LDYgKzQ5MCw3IEBAIHN0YXRpYyB1aV9maWxlX2lzYXR0 eV9mdHlwZSBzdGRpb19maWxlX2kKIHN0YXRpYyB1aV9maWxlX2RlbGV0ZV9m dHlwZSBzdGRpb19maWxlX2RlbGV0ZTsKIHN0YXRpYyBzdHJ1Y3QgdWlfZmls ZSAqc3RkaW9fZmlsZV9uZXcgKEZJTEUgKmZpbGUsIGludCBjbG9zZV9wKTsK IHN0YXRpYyB1aV9maWxlX2ZsdXNoX2Z0eXBlIHN0ZGlvX2ZpbGVfZmx1c2g7 CitzdGF0aWMgdWlfZmlsZV9mc2Vla19mdHlwZSBzdGRpb19maWxlX2ZzZWVr OwogCiBzdGF0aWMgaW50IHN0ZGlvX2ZpbGVfbWFnaWM7CiAKQEAgLTQ5OSw2 ICs1MjEsNyBAQCBzdGRpb19maWxlX25ldyAoRklMRSAqZmlsZSwgaW50IGNs b3NlX3ApCiAgIHNldF91aV9maWxlX2ZwdXRzICh1aV9maWxlLCBzdGRpb19m aWxlX2ZwdXRzKTsKICAgc2V0X3VpX2ZpbGVfcmVhZCAodWlfZmlsZSwgc3Rk aW9fZmlsZV9yZWFkKTsKICAgc2V0X3VpX2ZpbGVfaXNhdHR5ICh1aV9maWxl LCBzdGRpb19maWxlX2lzYXR0eSk7CisgIHNldF91aV9maWxlX2ZzZWVrICh1 aV9maWxlLCBzdGRpb19maWxlX2ZzZWVrKTsKICAgcmV0dXJuIHVpX2ZpbGU7 CiB9CiAKQEAgLTYxNiw2ICs2MzksMTggQEAgc3RkaW9fZmlsZV9pc2F0dHkg KHN0cnVjdCB1aV9maWxlICpmaWxlKQogICByZXR1cm4gKGlzYXR0eSAoc3Rk aW8tPmZkKSk7CiB9CiAKK3N0YXRpYyBpbnQKK3N0ZGlvX2ZpbGVfZnNlZWsg KHN0cnVjdCB1aV9maWxlICpmaWxlLCBsb25nIG9mZnNldCwgaW50IHdoZW5j ZSkKK3sKKyAgc3RydWN0IHN0ZGlvX2ZpbGUgKnN0ZGlvID0gdWlfZmlsZV9k YXRhIChmaWxlKTsKKworICBpZiAoc3RkaW8tPm1hZ2ljICE9ICZzdGRpb19m aWxlX21hZ2ljKQorICAgIGludGVybmFsX2Vycm9yIChfX0ZJTEVfXywgX19M SU5FX18sCisJCSAgICBfKCJzdGRpb19maWxlX2ZzZWVrOiBiYWQgbWFnaWMg bnVtYmVyIikpOworCisgIHJldHVybiBmc2VlayAoc3RkaW8tPmZpbGUsIG9m ZnNldCwgd2hlbmNlKTsKK30KKwogLyogTGlrZSBmZG9wZW4oKS4gIENyZWF0 ZSBhIHVpX2ZpbGUgZnJvbSBhIHByZXZpb3VzbHkgb3BlbmVkIEZJTEUuICAq LwogCiBzdHJ1Y3QgdWlfZmlsZSAqCi0tLSBhL3VpLWZpbGUuaAorKysgYi91 aS1maWxlLmgKQEAgLTc5LDYgKzc5LDExIEBAIHR5cGVkZWYgdm9pZCAodWlf ZmlsZV9kZWxldGVfZnR5cGUpIChzdHIKIGV4dGVybiB2b2lkIHNldF91aV9m aWxlX2RhdGEgKHN0cnVjdCB1aV9maWxlICpzdHJlYW0sIHZvaWQgKmRhdGEs CiAJCQkgICAgICB1aV9maWxlX2RlbGV0ZV9mdHlwZSAqZGVsZXRlKTsKIAor dHlwZWRlZiBpbnQgKHVpX2ZpbGVfZnNlZWtfZnR5cGUpIChzdHJ1Y3QgdWlf ZmlsZSAqIHN0cmVhbSwgbG9uZyBvZmZzZXQsCisJCQkJICAgaW50IHdoZW5j ZSk7CitleHRlcm4gdm9pZCBzZXRfdWlfZmlsZV9mc2VlayAoc3RydWN0IHVp X2ZpbGUgKnN0cmVhbSwKKwkJCSAgICAgICB1aV9maWxlX2ZzZWVrX2Z0eXBl ICpmc2Vla19wdHIpOworCiBleHRlcm4gdm9pZCAqdWlfZmlsZV9kYXRhIChz dHJ1Y3QgdWlfZmlsZSAqZmlsZSk7CiAKIApAQCAtMTEzLDYgKzExOCw4IEBA IGV4dGVybiBjaGFyICp1aV9maWxlX29ic2F2ZXN0cmluZyAoc3RydWMKIAog ZXh0ZXJuIGxvbmcgdWlfZmlsZV9yZWFkIChzdHJ1Y3QgdWlfZmlsZSAqZmls ZSwgY2hhciAqYnVmLCBsb25nIGxlbmd0aF9idWYpOwogCitleHRlcm4gaW50 IHVpX2ZpbGVfZnNlZWsgKHN0cnVjdCB1aV9maWxlICogZmlsZSwgbG9uZyBv ZmZzZXQsIGludCB3aGVuY2UpOworCiAvKiBDcmVhdGUvb3BlbiBhIG1lbW9y eSBiYXNlZCBmaWxlLiAgQ2FuIGJlIHVzZWQgYXMgYSBzY3JhdGNoIGJ1ZmZl cgogICAgZm9yIGNvbGxlY3Rpbmcgb3V0cHV0LiAgKi8KIGV4dGVybiBzdHJ1 Y3QgdWlfZmlsZSAqbWVtX2ZpbGVvcGVuICh2b2lkKTsK --00151747bd54ec802104d0a5b6fd--