From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id t2uLLvZ/yGZrlBEAWB0awg (envelope-from ) for ; Fri, 23 Aug 2024 08:26:30 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=O8G5p9U8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A95CA1E0D0; Fri, 23 Aug 2024 08:26:30 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 86BAB1E0AC for ; Fri, 23 Aug 2024 08:26:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 114E938708FC for ; Fri, 23 Aug 2024 12:26:28 +0000 (GMT) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 94C95385E837 for ; Fri, 23 Aug 2024 12:25:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94C95385E837 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 94C95385E837 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724415963; cv=none; b=xdMISZlCXm7I0AKNJIUG7F6GTheUgoWgf1sOainkylI1W8jmrBIFclUOcuiR2jZaL5x1TGKpnXIxEdkVyGpfUfUKm3d33Uz1rpXuLoBifpPUnBVlA+FfqIhNJejmPo6vBarV+n0k3b0dh4+kxChNBwPAUaqyb2i0k2up1SoKhEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724415963; c=relaxed/simple; bh=buidezvvTmJXDEOxPjsUNcQXCW5IecQlQuFvANOP3qs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=nYtkeYRrjx0ttd2yT9XYT3w8FWO45BM+gjAMqIrK/36WbZxJOLZPtDhTPjP6MUZe6ignuFEAgud2DoRIF5DHooUZRk93IjEpOmFOc2bv2zlObphjNJd993DnDO8upLSe0CF8QWjXXQwqOxYd1Dkz8FlrzmX2GfUeJSR2MYzNOV8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-371a92d8c90so941167f8f.3 for ; Fri, 23 Aug 2024 05:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724415958; x=1725020758; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jxlxTuFj8C/HVf+tOqhfowspRLoqyyOniwZKQtQ0vqE=; b=O8G5p9U8KTN+Odq/vE6Oy1oDBbSoFOGpOMGaXJSpt/u36WBbtpZt63Y8DAnWjogMga Oi09n3YZTS4LanY2JVg5by/sAcUYbkWm7U5RDmoVk7yZpyEjRjsfss5DShe0m8254dsx xtKdxrNyak3OeYOb/khIIRgIJga7iDMZCSd+U7PZ3aGiJzgTRcw4Cohe599U+U+nHq2Z e19LZpaBf2F9L4vRat2pnTGsTsSucaIgksb7hsb7MM2e3RFXX1itVvK9tkPSmdtyqglB W/J4KGkAczBP7TDxwS+BmnSaR2aNP7uV/WmWtoXBKwqTG2CrQR8/ylR4dh8ejv4hJsQ8 J66w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724415958; x=1725020758; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jxlxTuFj8C/HVf+tOqhfowspRLoqyyOniwZKQtQ0vqE=; b=XxMwIBRVuhjd+s2qLvgi4nWP6MRdSXIG3HXbU6JE1pEMfU06BZ3lsHd/MLy5q0CzjO RYziLZrVcW09IaIgNjLBBGNj5gMdvoL+dYvH+bamDxSNQXvGYmaM5aSYbiTSWhzuH4da Yw3zxMNEbVrqyEE8NcE5BAAoYlU0nnrCZ9v3ulYB7jdPoTmLrPpSLxdR3+vFhIC8IPZ0 KflYXXZ6uFZ7F9TypG3zUhJG/CwGRFQaGQdk5g8qVxXsyPclQrabpjV2R+pcQisPxSO7 ead64xvXYnuAoBX/esx9AvTLocckHHlJzl4Y8m1b8DBryALn6gaBhFdY21YZTdeEbLzZ J6jA== X-Gm-Message-State: AOJu0YxdnMjzodTYYBzNNHegKdrzZxQzOCe8yRlRyG+97a4kmkC2ynYZ czpTXRx/hrDJGIa7aBxB99l32DggeSz2zbP1zQda3zioEzZxAPwHwMzbYzLwbx364GuDGs4l0Us 8rEZmIEJX85GRIe9fo0OcVz5pwFBi2uyV X-Google-Smtp-Source: AGHT+IFg/+9znPLNTpomdLwMjnwaQ2yb1rJ/bQ5+Loq8Vz3ez29wSEZjoK6i1DC6W3Yc0qYHPHhPE7NOjBnMuvb5J9E= X-Received: by 2002:adf:f649:0:b0:364:348:9170 with SMTP id ffacd0b85a97d-373118fb8b5mr1232025f8f.54.1724415957209; Fri, 23 Aug 2024 05:25:57 -0700 (PDT) MIME-Version: 1.0 References: <20240802164306.252264-1-achronop@gmail.com> <9388437d-557d-45df-8513-d0a91a8e97a7@redhat.com> <23584087-2048-4904-825a-48b0f9d60ebb@redhat.com> <1d10c73b-0c94-46b5-a1a3-310bb48eed16@redhat.com> In-Reply-To: <1d10c73b-0c94-46b5-a1a3-310bb48eed16@redhat.com> From: Alex Chronopoulos Date: Fri, 23 Aug 2024 15:25:45 +0300 Message-ID: Subject: Re: [PATCH v6] Change message when reaching end of reverse history. To: "gdb-patches@sourceware.org" Cc: Guinevere Larsen Content-Type: multipart/alternative; boundary="000000000000931c05062058e01d" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --000000000000931c05062058e01d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Since it takes some time, could you go on and land this one? I will have coordinated with Tom by the next time it's needed. On Tue, Aug 13, 2024 at 9:26=E2=80=AFPM Guinevere Larsen wrote: > I'm CC-ing Tom Tromey, as he's the one who usually talks about this in th= e > list. Tom, Could you take care of this? > > -- > Cheers, > Guinevere Larsen > She/Her/Hers > > On 8/13/24 3:18 PM, Alex Chronopoulos wrote: > > Hooray \o/ > Thank you for the reviews. > I would like to push myself, how can I get write-after-approval rights? > > On Tue, Aug 13, 2024 at 2:55=E2=80=AFPM Guinevere Larsen > wrote: > >> On 8/13/24 5:52 AM, Metzger, Markus T wrote: >> > Hello Alex, >> > >> >>> In a record session, when we move backward, GDB switches from normal >> >>> execution to simulation. Moving forward again, the emulation continu= es >> >>> until the end of the reverse history. When the end is reached, the >> >>> execution stops, and a warning message is shown. This message has be= en >> >>> modified to indicate that the forward emulation has reached the end, >> but >> >>> the execution can continue as normal, and the recording will also >> continue. >> >>> >> >>> Before this patch, the warning message shown in that case was the >> same as >> >>> in the reverse case. This meant that when the end of history was >> reached in >> >>> either backward or forward emulation, the same message was displayed= : >> >>> >> >>> "No more reverse-execution history." >> >>> >> >>> This message has changed for these two cases. Backward emulation: >> >>> >> >>> "Reached end of recorded history; stopping. >> >>> Backward execution from here not possible." >> >>> >> >>> Forward emulation: >> >>> >> >>> "Reached end of recorded history; stopping. >> >>> Following forward execution will be added to history." >> >>> >> >>> The reason for this change is that the initial message was deceiving= , >> for >> >>> the forward case, making the user believe that forward debugging >> could not >> >>> continue. >> >>> >> >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31224 >> >>> --- >> >> Hi! I think this is good to go in, but I would like Markus to chime i= n >> >> before pushing, since he mantains the other record subsystem, so for >> now >> >> >> >> Reviewed-By: Guinevere Larsen >> > OK for btrace. >> >> Awesome! Alex, feel free to change my tag to: Approved-By: Guinevere >> Larsen >> >> Do you already have write after approval rights for the repo? If not, do >> you plan to send more patches, so it makes sense to go after it? If not, >> I can push this for you :) >> >> -- >> Cheers, >> Guinevere Larsen >> She/Her/Hers >> >> > >> > Markus. >> > Intel Deutschland GmbH >> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany >> > Tel: +49 89 99 8853-0, www.intel.de >> > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon >> Silva >> > Chairperson of the Supervisory Board: Nicole Lau >> > Registered Office: Munich >> > Commercial Register: Amtsgericht Muenchen HRB 186928 >> >> --000000000000931c05062058e01d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Since it takes some time, could you go on and land this on= e? I will have coordinated with Tom by the next time it's needed.
=
On Tue= , Aug 13, 2024 at 9:26=E2=80=AFPM Guinevere Larsen <blarsen@redhat.com> wrote:
=20 =20 =20
I'm CC-ing Tom Tromey, as he's the one who usually talks about this in the list. Tom, Could you take care of this?
--=20
Cheers,
Guinevere Larsen
She/Her/Hers
On 8/13/24 3:18 PM, Alex Chronopoulos wrote:
=20
Hooray \o/
Thank you for the reviews.
I would like to push myself, how can I get write-after-= approval rights?

On Tue, Aug 13, 2024 at 2:55=E2=80=AFPM Guinevere Larsen <blarsen@redhat.com> wrote:
On 8/13/24 5:52 AM, Metzger, Markus T wrote:
> Hello Alex,
>
>>> In a record session, when we move backward, GDB switches from normal
>>> execution to simulation. Moving forward again, the emulation continues
>>> until the end of the reverse history. When the end is reached, the
>>> execution stops, and a warning message is shown. This message has been
>>> modified to indicate that the forward emulation has reached the end, but
>>> the execution can continue as normal, and the recording will also continue.
>>>
>>> Before this patch, the warning message shown in that case was the same as
>>> in the reverse case. This meant that when the end of history was reached in
>>> either backward or forward emulation, the same message was displayed:
>>>
>>> "No more reverse-execution history."
>>>
>>> This message has changed for these two cases. Backward emulation:
>>>
>>> "Reached end of recorded history; stopping.
>>> Backward execution from here not possible."
>>>
>>> Forward emulation:
>>>
>>> "Reached end of recorded history; stopping.
>>> Following forward execution will be added to history."
>>>
>>> The reason for this change is that the initial message was deceiving, for
>>> the forward case, making the user believe that forward debugging could not
>>> continue.
>>>
>>> Bug: https://sourcewar= e.org/bugzilla/show_bug.cgi?id=3D31224
>>> ---
>> Hi! I think this is good to go in, but I would like Markus to chime in
>> before pushing, since he mantains the other record subsystem, so for now
>>
>> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
> OK for btrace.

Awesome! Alex, feel free to change my tag to: Approved-By: Guinevere
Larsen <blarsen@redhat.com>

Do you already have write after approval rights for the repo? If not, do
you plan to send more patches, so it makes sense to go after it? If not,
I can push this for you :)

--
Cheers,
Guinevere Larsen
She/Her/Hers

>
> Markus.
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

--000000000000931c05062058e01d--