From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hzhGOv/GDWY/7CEAWB0awg (envelope-from ) for ; Wed, 03 Apr 2024 17:15:43 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=HyICUcih; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E24141E0C0; Wed, 3 Apr 2024 17:15:43 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B91501E030 for ; Wed, 3 Apr 2024 17:15:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43D023847725 for ; Wed, 3 Apr 2024 21:15:41 +0000 (GMT) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 6641E3847725 for ; Wed, 3 Apr 2024 21:15:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6641E3847725 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6641E3847725 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712178921; cv=none; b=AAs3E7Sdw2c5IQXfSS0xZ869J9oxGBCdABwt+Ang1nwISOIjaOoLY+YoJtNKVARTtKla754VhhmUX0V8g89ivFnWEvU6BHamCGDD1SOlpS2c556gmufHFheXCBZffDORpfjG9CGXpL3DOlraPgAsVFlW3WoXnEeyYoI5DDlrdM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712178921; c=relaxed/simple; bh=KO+PFDMm3EDuP3A2feH98wa2rAr5h1mZmGekzEQ93Fg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=CX4Zuecra2Te6UjTu1CGrj6tSSZQUXqcRsk5izCkxqjrJzHK3vRNpdTcF4ZUG47vJlQP3eq38yRY5M19LefNv7QzpmsC7/Guuh5IUNV1Q6sQa85Gix0kTo4J0S3DeGSH7/lZImctWcoLMSquzi3/H3Q4FP7Ss9j9BseWCfyzzoQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4148c6132b4so8587065e9.1 for ; Wed, 03 Apr 2024 14:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712178914; x=1712783714; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k/eVTDjKBSLNkCN0pnI6p0W1MFdfRMnu/seUFvY2XAw=; b=HyICUcihJbZ78V+0WJyyvxtnhIUvIRSDiCC6HwqdWJDDOYlXTrGQC7ELI7zQEaAFgz +J51ksJF9kXxOFz9cJjspQTzHomsqZrbxX4Yfu4mBSDiH1QOkA4wyH4jiF9NqSpgfA7w 0KDMiiqYL1ha5Oeq2jy24M8lMiV8DZJfBpho7+Id9jkbXgERCYQmEjM4Xqpay3Yjj4S1 dsd+BLZbnbw9VhNOJdO/qIJg3OnJiA21POiC+RLwsnYXYzsgTvrl/nID6pXf7JKmCJQ/ dkijy3jptNewTfBwojXRcdcCEc0lTFQmHXkSxVmZrYK27Sakk2teaLSIWmTGgJB6KKJP 20+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712178914; x=1712783714; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k/eVTDjKBSLNkCN0pnI6p0W1MFdfRMnu/seUFvY2XAw=; b=cm2W3wPlbVHGPouoIVqYzhq9TL/XtYCznjQBTTNqWoyildOD56CCa27A3kLtsEZGL6 AwuJKJrDVYCE/UwO1W0LqnSEibVpS/cSjGu07WljLygBdrzsWJfe6YIGoruW+VHUbJpG DlOe0ZVimzxfTpxEvu1Uah9c1jgt9ObpJWRgww8WeKdpnKGBsQCLYAxwqwtGH9efZxC3 0kjEpUrHu3EtEg4SPUFSIZIPm+1bk2+rJep0COsdPNCYtZt1UhhKyeOO7GElUVQHVSLQ 9nnPXctU3Nwv/R9teRS/odvh5603oj+itk5rG13CSf33UM20zfW+Q5n1/NZ/TBARKlvF rkmg== X-Forwarded-Encrypted: i=1; AJvYcCUDDlSSmmH3I4IFd7egcIAibrHDs8lHGmI1E1ZTL4hQwwMFobWLCwlzESjvSgJrghEB4nA5vRF5mNnscU4loxgIJyqj7wIRR3/owA== X-Gm-Message-State: AOJu0Yz0BekDq/3Be6JpEY/s1Syvav/7VQFnXLaOTmVwdM4NwcMu+4Dm +AVNuASFtj5yJOWb0lgwTb8OfMV0Ulk60YZHHG1AGVYDPTNaBpQGcdYxqM2PtZ5IvkKWj/wPKZH 9F9qyXlxiLKvVrzkBFSw14p05aeo= X-Google-Smtp-Source: AGHT+IFC8vJ6qfWHSIA/mSsWEldjKskz9cgs+zXaZ2Zp2fztuzGp1bWhznUDq7Voqu37Vah80AZy1tNHeLXjD4a+iko= X-Received: by 2002:a05:600c:5118:b0:416:1e4c:c579 with SMTP id o24-20020a05600c511800b004161e4cc579mr691450wms.6.1712178914145; Wed, 03 Apr 2024 14:15:14 -0700 (PDT) MIME-Version: 1.0 References: <20240313204830.2521708-1-achronop@gmail.com> <50e7e7f5-024b-4ac8-be5c-948ad2f41e73@redhat.com> In-Reply-To: From: Alex Chronopoulos Date: Wed, 3 Apr 2024 23:15:02 +0200 Message-ID: Subject: Re: [PATCH] Change message when reaching end of reverse history. To: Guinevere Larsen Cc: "Metzger, Markus T" , "Eli Zaretskii (eliz@gnu.org)" , "gdb-patches@sourceware.org" Content-Type: multipart/alternative; boundary="000000000000f83e61061537b79d" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --000000000000f83e61061537b79d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you, Guinevere. My understanding is that you are referring to the forward case. Does it mean we keep the backward case as is? "No more history" sounds good to me. If that were the case, would the suggested forward message become: "No more history, recording will continue"? On Wed, Apr 3, 2024 at 7:54=E2=80=AFPM Guinevere Larsen wrote: > On 3/14/24 14:26, Alex Chronopoulos wrote: > > > I think "reached beginning of ~" makes sense, but that wouldn't fix the > > confusion about whether GDB can continue executing (and recording) on > > its own. > > > > On the other hand, I worry just saying "switching to recording mode" > > might seem too arbitrary for users, if they don't know the context of > > the commit message. > > That's correct. The current issue in the forward case is that execution c= an > continue. GDB will halt at the beginning of the reverse history because > emulation cannot proceed. However, execution can resume in the 'normal' > mode, > and recording can also continue. I was attempting to inform the user that= a > different type of execution would be possible to continue debugging. > Backward > execution does not encounter the same issue because reaching the end of > history > signifies the end of the reverse execution. I am unsure how to convey all > these > points with fewer words unless we opt for less specificity. Please sugges= t > something in the preferred direction. > > Markus, Alex, > > Sorry about the last 2 weeks of silence, I had 2 weeks of vacation I had > to take. > > Back to the complicated wording, I asked a couple (non GDB developer) > friends to get end users perspectives. One said that "switching to > recording mode" was very confusing, since they thought GDB was already in > recording mode. After some brainstorming, we came up with "recording will > continue" as a way to express that the program can still execute forward > > We can continue using the old "No more reverse-execution history." to > explain why record more, or we can shorten it to "no more history", "no > more recorded history", or some other variation. > > What do you think? > > > Thank you in advance, > Alex > > On Thu, Mar 14, 2024 at 11:26=E2=80=AFAM Guinevere Larsen > wrote: > >> On 14/03/2024 07:37, Metzger, Markus T wrote: >> > Hello Alex, >> > >> > I like the idea, but I find the wording a bit verbose. Can we find >> something shorter? >> > E.g. "reached beginning of reverse-execution history" vs "reached end >> of ~". >> > Not sure if that's clear enough that we're recording again. We could >> also omit >> > the "reached end of ~" part and just say "switching to recording mode"= . >> >> I think "reached beginning of ~" makes sense, but that wouldn't fix the >> confusion about whether GDB can continue executing (and recording) on >> its own. >> >> On the other hand, I worry just saying "switching to recording mode" >> might seem too arbitrary for users, if they don't know the context of >> the commit message. >> >> I wonder if good documentation can offset the second issue, though... >> >> > >> >> if (uiout->is_mi_like_p ()) >> >> uiout->field_string ("reason", async_reason_lookup >> >> (EXEC_ASYNC_NO_HISTORY)); >> >> + else if (execution_direction =3D=3D EXEC_FORWARD) >> >> + uiout->text ("\nNo more reverse-execution history for emulation.= " >> >> + "Going forward will continue executing and >> recording.\n"); >> >> else >> >> - uiout->text ("\nNo more reverse-execution history.\n"); >> >> + { >> >> + gdb_assert (execution_direction =3D=3D EXEC_REVERSE); >> >> + uiout->text ("\nNo more reverse-execution history.\n"); >> >> + } >> > We should probably give MI a similar indication, although that would >> likely >> > break existing MI consumers. Not sure how opt-in is handled in MI. >> >> I don't know either, but relatively easy change would be to add a new >> field to the mi response to show direction when recording is enabled, so >> mi consumers could decide how to handle a no-history stop. >> >> Or we could announce the change on GDB 15 release and hold off on >> merging this after 15 branched? Not sure if this is the right process, >> though. >> >> I had a suggestion after FOSDEM to have GDB indicate the direction of >> execution for every command when recording is enabled, and adding that >> to MI would be a step in that direction (again, leaving it up to MI >> consumers on how to report it to users). what do you think? >> >> > >> > regards, >> > Markus. >> > >> >> -----Original Message----- >> >> From: Alex Chronopoulos >> >> Sent: Wednesday, March 13, 2024 9:49 PM >> >> To: gdb-patches@sourceware.org >> >> Cc: Alex Chronopoulos >> >> Subject: [PATCH] Change message when reaching end of reverse history. >> >> >> >> In a record session, when we move backward, GDB switches from normal >> >> execution to simulation. Moving forward again, the emulation continue= s >> >> until the end of the reverse history. When the end is reached, the >> >> execution stops, and a warning message is shown. This message has bee= n >> >> modified to indicate that the forward emulation has reached the end, >> but >> >> the execution can continue as normal, and the recording will also >> continue. >> >> >> >> Before this patch, the warning message shown in that case was the sam= e >> as >> >> in the reverse case. This meant that when the end of history was >> reached in >> >> either backward or forward emulation, the same message was displayed: >> >> >> >> "No more reverse-execution history." >> >> >> >> This message remains for backward emulation. However, in forward >> >> emulation, >> >> it has been modified to: >> >> >> >> "No more reverse-execution history for emulation. Going forward will >> >> continue executing and recording." >> >> >> >> The reason for this change is that the initial message was deceiving, >> >> making the user believe that forward debugging could not continue. >> >> >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31224 >> >> --- >> >> gdb/NEWS | 5 ++++ >> >> gdb/infrun.c | 8 ++++- >> >> gdb/testsuite/gdb.btrace/non-stop.exp | 30 ++++++++++++------= - >> >> gdb/testsuite/gdb.reverse/break-precsave.exp | 4 +-- >> >> gdb/testsuite/gdb.reverse/break-reverse.exp | 2 +- >> >> .../gdb.reverse/machinestate-precsave.exp | 2 +- >> >> 6 files changed, 36 insertions(+), 15 deletions(-) >> >> >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> >> index 2638b3e0d9c..f2e85776a53 100644 >> >> --- a/gdb/NEWS >> >> +++ b/gdb/NEWS >> >> @@ -13,6 +13,11 @@ >> >> the background, resulting in faster startup. This can be controll= ed >> >> using "maint set dwarf synchronous". >> >> >> >> +* In a record session, when a forward emulation reaches the end of t= he >> >> reverse >> >> + history, the warning message has been changed to indicate that the >> end of >> >> the >> >> + history has been reached. It also specifies that the forward >> execution can >> >> + continue, and the recording will also continue. >> >> + >> >> * Changed commands >> >> >> >> disassemble >> >> diff --git a/gdb/infrun.c b/gdb/infrun.c >> >> index bbb98f6dcdb..e129eb0582f 100644 >> >> --- a/gdb/infrun.c >> >> +++ b/gdb/infrun.c >> >> @@ -9244,8 +9244,14 @@ print_no_history_reason (struct ui_out *uiout) >> >> { >> >> if (uiout->is_mi_like_p ()) >> >> uiout->field_string ("reason", async_reason_lookup >> >> (EXEC_ASYNC_NO_HISTORY)); >> >> + else if (execution_direction =3D=3D EXEC_FORWARD) >> >> + uiout->text ("\nNo more reverse-execution history for emulation.= " >> >> + "Going forward will continue executing and >> recording.\n"); >> >> else >> >> - uiout->text ("\nNo more reverse-execution history.\n"); >> >> + { >> >> + gdb_assert (execution_direction =3D=3D EXEC_REVERSE); >> >> + uiout->text ("\nNo more reverse-execution history.\n"); >> >> + } >> >> } >> >> >> >> /* Print current location without a level number, if we have changed >> >> diff --git a/gdb/testsuite/gdb.btrace/non-stop.exp >> >> b/gdb/testsuite/gdb.btrace/non-stop.exp >> >> index 62c940e4cd6..7ce3008c120 100644 >> >> --- a/gdb/testsuite/gdb.btrace/non-stop.exp >> >> +++ b/gdb/testsuite/gdb.btrace/non-stop.exp >> >> @@ -79,7 +79,7 @@ proc gdb_cont_to_bp_line { line threads nthreads } = { >> >> $nthreads >> >> } >> >> >> >> -proc gdb_cont_to_no_history { threads cmd nthreads } { >> >> +proc gdb_cont_to_no_history_backward { threads cmd nthreads } { >> >> gdb_cont_to $threads $cmd \ >> >> [multi_line \ >> >> "No more reverse-execution history\." \ >> >> @@ -89,6 +89,16 @@ proc gdb_cont_to_no_history { threads cmd nthreads= } >> >> { >> >> $nthreads >> >> } >> >> >> >> +proc gdb_cont_to_no_history_forward { threads cmd nthreads } { >> >> + gdb_cont_to $threads $cmd \ >> >> + [multi_line \ >> >> + "No more reverse-execution history for emulation\. Goin= g >> forward >> >> will continue executing and recording\." \ >> >> + "\[^\\\r\\\n\]*" \ >> >> + "\[^\\\r\\\n\]*" \ >> >> + ] \ >> >> + $nthreads >> >> +} >> >> + >> >> # trace the code between the two breakpoints >> >> with_test_prefix "prepare" { >> >> gdb_cont_to_bp_line "$srcfile:$bp_1" all 2 >> >> @@ -176,14 +186,14 @@ with_test_prefix "reverse-step" { >> >> with_test_prefix "continue" { >> >> with_test_prefix "thread 1" { >> >> with_test_prefix "continue" { >> >> - gdb_cont_to_no_history 1 "continue" 1 >> >> + gdb_cont_to_no_history_forward 1 "continue" 1 >> >> gdb_test "thread apply 1 info record" \ >> >> ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" >> >> gdb_test "thread apply 2 info record" \ >> >> ".*Replay in progress\. At instruction 5\." >> >> } >> >> with_test_prefix "reverse-continue" { >> >> - gdb_cont_to_no_history 1 "reverse-continue" 1 >> >> + gdb_cont_to_no_history_backward 1 "reverse-continue" 1 >> >> gdb_test "thread apply 1 info record" \ >> >> ".*Replay in progress\. At instruction 1\." >> >> gdb_test "thread apply 2 info record" \ >> >> @@ -193,14 +203,14 @@ with_test_prefix "continue" { >> >> >> >> with_test_prefix "thread 2" { >> >> with_test_prefix "continue" { >> >> - gdb_cont_to_no_history 2 "continue" 1 >> >> + gdb_cont_to_no_history_forward 2 "continue" 1 >> >> gdb_test "thread apply 1 info record" \ >> >> ".*Replay in progress\. At instruction 1\." >> >> gdb_test "thread apply 2 info record" \ >> >> ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" >> >> } >> >> with_test_prefix "reverse-continue" { >> >> - gdb_cont_to_no_history 2 "reverse-continue" 1 >> >> + gdb_cont_to_no_history_backward 2 "reverse-continue" 1 >> >> gdb_test "thread apply 1 info record" \ >> >> ".*Replay in progress\. At instruction 1\." >> >> gdb_test "thread apply 2 info record" \ >> >> @@ -215,8 +225,8 @@ with_test_prefix "no progress" { >> >> gdb_test "thread apply 1 record goto end" ".*" >> >> gdb_test "thread apply 2 record goto begin" ".*" >> >> >> >> - gdb_cont_to_no_history 1 "continue" 1 >> >> - gdb_cont_to_no_history 1 "step" 1 >> >> + gdb_cont_to_no_history_forward 1 "continue" 1 >> >> + gdb_cont_to_no_history_forward 1 "step" 1 >> >> gdb_test "thread apply 1 info record" \ >> >> ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" >> >> gdb_test "thread apply 2 info record" \ >> >> @@ -227,8 +237,8 @@ with_test_prefix "no progress" { >> >> gdb_test "thread apply 1 record goto begin" ".*" >> >> gdb_test "thread apply 2 record goto end" ".*" >> >> >> >> - gdb_cont_to_no_history 2 "continue" 1 >> >> - gdb_cont_to_no_history 2 "step" 1 >> >> + gdb_cont_to_no_history_forward 2 "continue" 1 >> >> + gdb_cont_to_no_history_forward 2 "step" 1 >> >> gdb_test "thread apply 1 info record" \ >> >> ".*Replay in progress\. At instruction 1\." >> >> gdb_test "thread apply 2 info record" \ >> >> @@ -238,7 +248,7 @@ with_test_prefix "no progress" { >> >> with_test_prefix "all" { >> >> gdb_test "thread apply all record goto begin" ".*" >> >> >> >> - gdb_cont_to_no_history all "continue" 2 >> >> + gdb_cont_to_no_history_forward all "continue" 2 >> >> gdb_test "thread apply 1 info record" \ >> >> ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" >> >> gdb_test "thread apply 2 info record" \ >> >> diff --git a/gdb/testsuite/gdb.reverse/break-precsave.exp >> >> b/gdb/testsuite/gdb.reverse/break-precsave.exp >> >> index b9d94681247..6d3b95933d4 100644 >> >> --- a/gdb/testsuite/gdb.reverse/break-precsave.exp >> >> +++ b/gdb/testsuite/gdb.reverse/break-precsave.exp >> >> @@ -73,7 +73,7 @@ proc precsave_tests {} { >> >> -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt >> $" >> >> { >> >> pass "go to end of main forward" >> >> } >> >> - -re "No more reverse-execution history.* end of main .*$gdb_prom= pt >> >> $" { >> >> + -re "No more reverse-execution history for emulation. Going >> forward >> >> will continue executing and recording.* end of main .*$gdb_prompt $" = { >> >> pass "go to end of main forward" >> >> } >> >> } >> >> @@ -103,7 +103,7 @@ proc precsave_tests {} { >> >> -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt >> $" >> >> { >> >> pass "end of record log" >> >> } >> >> - -re "No more reverse-execution history.* end of main .*$gdb_prom= pt >> >> $" { >> >> + -re "No more reverse-execution history for emulation. Going >> forward >> >> will continue executing and recording.* end of main .*$gdb_prompt $" = { >> >> pass "end of record log" >> >> } >> >> } >> >> diff --git a/gdb/testsuite/gdb.reverse/break-reverse.exp >> >> b/gdb/testsuite/gdb.reverse/break-reverse.exp >> >> index 1dd327ca654..bf74d6f7d07 100644 >> >> --- a/gdb/testsuite/gdb.reverse/break-reverse.exp >> >> +++ b/gdb/testsuite/gdb.reverse/break-reverse.exp >> >> @@ -80,7 +80,7 @@ gdb_test_multiple "continue" "end of record log" { >> >> -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt >> $" { >> >> pass "end of record log" >> >> } >> >> - -re "No more reverse-execution history.* end of main >> .*$gdb_prompt $" { >> >> + -re "No more reverse-execution history for emulation. Going >> forward will >> >> continue executing and recording.* end of main .*$gdb_prompt $" { >> >> pass "end of record log" >> >> } >> >> } >> >> diff --git a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp >> >> b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp >> >> index 19c5934bfdf..693c304bc18 100644 >> >> --- a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp >> >> +++ b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp >> >> @@ -85,7 +85,7 @@ gdb_test_multiple "continue" "go to end of main >> >> forward" { >> >> -re ".*Breakpoint $decimal,.*$srcfile:$endmain.*$gdb_prompt $" = { >> >> pass "go to end of main forward" >> >> } >> >> - -re "No more reverse-execution history.* end main .*$gdb_prompt >> $" { >> >> + -re "No more reverse-execution history for emulation. Going >> forward will >> >> continue executing and recording.* end main .*$gdb_prompt $" { >> >> pass "go to end of main forward" >> >> } >> >> } >> >> -- >> >> 2.42.0 >> > Intel Deutschland GmbH >> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany >> > Tel: +49 89 99 8853-0, www.intel.de >> > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon >> Silva >> > Chairperson of the Supervisory Board: Nicole Lau >> > Registered Office: Munich >> > Commercial Register: Amtsgericht Muenchen HRB 186928 >> > >> >> -- >> Cheers, >> Guinevere Larsen >> She/Her/Hers >> >> --000000000000f83e61061537b79d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you, Guinevere.

My und= erstanding is that you are referring to the forward case. Does it mean we k= eep the backward case as is?

"No more history= " sounds good to me. If that were the case, would the suggested forwar= d message become: "No more history, recording will continue"?
=



On Wed, Apr 3, 2024 at 7:54=E2=80=AFPM = Guinevere Larsen <blarsen@redhat.c= om> wrote:
=20
> I think "reached beginning of ~" ma= kes sense, but that wouldn't fix the
> confusion about whether GDB can continue executing (and recording) on
> its own.
>
> On the other hand, I worry just saying "switching to recording mode"
> might seem too arbitrary for users, if they don't know the context of
> the commit message.

That's correct. The current issue in the forward case is that execution can
continue. GDB will halt at the beginning of the reverse history because
emulation cannot proceed. However, execution can resume in the 'normal' mode,
and recording can also continue. I was attempting to inform the user that a
different type of execution would be possible to continue debugging. Backward
execution does not encounter the same issue because reaching the end of history
signifies the end of the reverse execution. I am unsure how to convey all these
points with fewer words unless we opt for less specificity. Please suggest
something in the preferred direction.

Markus, Alex,

Sorry about the last 2 weeks of silence, I had 2 weeks of vacation I had to take.

Back to the complicated wording, I asked a couple (non GDB developer) friends to get end users perspectives. One said that "switching to recording mode" was very confusing, since the= y thought GDB was already in recording mode. After some brainstorming, we came up with "recording will continue" as= a way to express that the program can still execute forward

We can continue using the old "No more reverse-execution history." to explain why record more, or we can shorten it to &q= uot;no more history", "no more recorded history", or some oth= er variation.

What do you think?


Thank you in advance,
Alex

On Thu, Mar 14, 2024 at 11:26=E2=80=AFAM Guinevere Larsen <blarsen@redhat.com> wrote:
On 14/03/2024 07:37, Metzger, Markus T wrote:
> Hello Alex,
>
> I like the idea, but I find the wording a bit verbose.=C2= =A0 Can we find something shorter?
> E.g. "reached beginning of reverse-execution history&= quot; vs "reached end of ~".
> Not sure if that's clear enough that we're recordi= ng again.=C2=A0 We could also omit
> the "reached end of ~" part and just say "s= witching to recording mode".

I think "reached beginning of ~" makes sense, but tha= t wouldn't fix the
confusion about whether GDB can continue executing (and recording) on
its own.

On the other hand, I worry just saying "switching to recording mode"
might seem too arbitrary for users, if they don't know the context of
the commit message.

I wonder if good documentation can offset the second issue, though...

>
>>=C2=A0 =C2=A0 if (uiout->is_mi_like_p ())
>>=C2=A0 =C2=A0 =C2=A0 uiout->field_string ("reas= on", async_reason_lookup
>> (EXEC_ASYNC_NO_HISTORY));
>> +=C2=A0 else if (execution_direction =3D=3D EXEC_FORWA= RD)
>> +=C2=A0 =C2=A0 uiout->text ("\nNo more reverse= -execution history for emulation. "
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"= ;Going forward will continue executing and recording.\n");
>>=C2=A0 =C2=A0 else
>> -=C2=A0 =C2=A0 uiout->text ("\nNo more reverse= -execution history.\n");
>> +=C2=A0 =C2=A0 {
>> +=C2=A0 =C2=A0 =C2=A0 gdb_assert (execution_direction = =3D=3D EXEC_REVERSE);
>> +=C2=A0 =C2=A0 =C2=A0 uiout->text ("\nNo more = reverse-execution history.\n");
>> +=C2=A0 =C2=A0 }
> We should probably give MI a similar indication, although that would likely
> break existing MI consumers.=C2=A0 Not sure how opt-in is handled in MI.

I don't know either, but relatively easy change would be to add a new
field to the mi response to show direction when recording is enabled, so
mi consumers could decide how to handle a no-history stop.

Or we could announce the change on GDB 15 release and hold off on
merging this after 15 branched? Not sure if this is the right process,
though.

I had a suggestion after FOSDEM to have GDB indicate the direction of
execution for every command when recording is enabled, and adding that
to MI would be a step in that direction (again, leaving it up to MI
consumers on how to report it to users). what do you think?

>
> regards,
> Markus.
>
>> -----Original Message-----
>> From: Alex Chronopoulos <achronop@gmail.com>
>> Sent: Wednesday, March 13, 2024 9:49 PM
>> To: gdb-patches@sourceware.org
>> Cc: Alex Chronopoulos <achronop@gmail.com>
>> Subject: [PATCH] Change message when reaching end of reverse history.
>>
>> In a record session, when we move backward, GDB switches from normal
>> execution to simulation. Moving forward again, the emulation continues
>> until the end of the reverse history. When the end is reached, the
>> execution stops, and a warning message is shown. This message has been
>> modified to indicate that the forward emulation has reached the end, but
>> the execution can continue as normal, and the recording will also continue.
>>
>> Before this patch, the warning message shown in that case was the same as
>> in the reverse case. This meant that when the end of history was reached in
>> either backward or forward emulation, the same message was displayed:
>>
>> "No more reverse-execution history."
>>
>> This message remains for backward emulation. However, in forward
>> emulation,
>> it has been modified to:
>>
>> "No more reverse-execution history for emulation. Going forward will
>> continue executing and recording."
>>
>> The reason for this change is that the initial message was deceiving,
>> making the user believe that forward debugging could not continue.
>>
>> Bug: https://sourceware.= org/bugzilla/show_bug.cgi?id=3D31224
>> ---
>> gdb/NEWS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 5 ++++
>> gdb/infrun.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 |=C2=A0 8 ++++-
>> gdb/testsuite/gdb.btrace/non-stop.exp=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| 30 ++++++++++++-------
>> gdb/testsuite/gdb.reverse/break-precsave.exp=C2=A0 |= =C2=A0 4 +--
>> gdb/testsuite/gdb.reverse/break-reverse.exp=C2=A0 =C2= =A0|=C2=A0 2 +-
>> .../gdb.reverse/machinestate-precsave.exp=C2=A0 =C2=A0= =C2=A0|=C2=A0 2 +-
>> 6 files changed, 36 insertions(+), 15 deletions(-)
>>
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index 2638b3e0d9c..f2e85776a53 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -13,6 +13,11 @@
>>=C2=A0 =C2=A0 the background, resulting in faster start= up.=C2=A0 This can be controlled
>>=C2=A0 =C2=A0 using "maint set dwarf synchronous&q= uot;.
>>
>> +* In a record session, when a forward emulation reaches the end of the
>> reverse
>> +=C2=A0 history, the warning message has been changed = to indicate that the end of
>> the
>> +=C2=A0 history has been reached.=C2=A0 It also specif= ies that the forward execution can
>> +=C2=A0 continue, and the recording will also continue= .
>> +
>> * Changed commands
>>
>> disassemble
>> diff --git a/gdb/infrun.c b/gdb/infrun.c
>> index bbb98f6dcdb..e129eb0582f 100644
>> --- a/gdb/infrun.c
>> +++ b/gdb/infrun.c
>> @@ -9244,8 +9244,14 @@ print_no_history_reason (struct ui_out *uiout)
>> {
>>=C2=A0 =C2=A0 if (uiout->is_mi_like_p ())
>>=C2=A0 =C2=A0 =C2=A0 uiout->field_string ("reas= on", async_reason_lookup
>> (EXEC_ASYNC_NO_HISTORY));
>> +=C2=A0 else if (execution_direction =3D=3D EXEC_FORWA= RD)
>> +=C2=A0 =C2=A0 uiout->text ("\nNo more reverse= -execution history for emulation. "
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"= ;Going forward will continue executing and recording.\n");
>>=C2=A0 =C2=A0 else
>> -=C2=A0 =C2=A0 uiout->text ("\nNo more reverse= -execution history.\n");
>> +=C2=A0 =C2=A0 {
>> +=C2=A0 =C2=A0 =C2=A0 gdb_assert (execution_direction = =3D=3D EXEC_REVERSE);
>> +=C2=A0 =C2=A0 =C2=A0 uiout->text ("\nNo more = reverse-execution history.\n");
>> +=C2=A0 =C2=A0 }
>> }
>>
>> /* Print current location without a level number, if we have changed
>> diff --git a/gdb/testsuite/gdb.btrace/non-stop.exp
>> b/gdb/testsuite/gdb.btrace/non-stop.exp
>> index 62c940e4cd6..7ce3008c120 100644
>> --- a/gdb/testsuite/gdb.btrace/non-stop.exp
>> +++ b/gdb/testsuite/gdb.btrace/non-stop.exp
>> @@ -79,7 +79,7 @@ proc gdb_cont_to_bp_line { line threads nthreads } {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $nthreads
>> }
>>
>> -proc gdb_cont_to_no_history { threads cmd nthreads } {
>> +proc gdb_cont_to_no_history_backward { threads cmd nthreads } {
>>=C2=A0 =C2=A0 =C2=A0 gdb_cont_to $threads $cmd \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [multi_line \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= "No more reverse-execution history\." \
>> @@ -89,6 +89,16 @@ proc gdb_cont_to_no_history { threads cmd nthreads }
>> {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $nthreads
>> }
>>
>> +proc gdb_cont_to_no_history_forward { threads cmd nthreads } {
>> +=C2=A0 =C2=A0 gdb_cont_to $threads $cmd \
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 [multi_line \
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"= ;No more reverse-execution history for emulation\. Going forward
>> will continue executing and recording\." \
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"= ;\[^\\\r\\\n\]*" \
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"= ;\[^\\\r\\\n\]*" \
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ] \
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 $nthreads
>> +}
>> +
>> # trace the code between the two breakpoints
>> with_test_prefix "prepare" {
>>=C2=A0 =C2=A0 =C2=A0 gdb_cont_to_bp_line "$srcfile= :$bp_1" all 2
>> @@ -176,14 +186,14 @@ with_test_prefix "reverse-step" {
>> with_test_prefix "continue" {
>>=C2=A0 =C2=A0 =C2=A0 with_test_prefix "thread 1&qu= ot; {
>>=C2=A0 =C2=A0 =C2=A0 with_test_prefix "continue&qu= ot; {
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history 1 = "continue" 1
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_fo= rward 1 "continue" 1
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*"
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Replay in progress\.=C2=A0 At instruction 5\."
>>=C2=A0 =C2=A0 =C2=A0 }
>>=C2=A0 =C2=A0 =C2=A0 with_test_prefix "reverse-con= tinue" {
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history 1 "reverse-continue" 1
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_ba= ckward 1 "reverse-continue" 1
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Replay in progress\.=C2=A0 At instruction 1\."
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 info record" \
>> @@ -193,14 +203,14 @@ with_test_prefix "continue&= quot; {
>>
>>=C2=A0 =C2=A0 =C2=A0 with_test_prefix "thread 2&qu= ot; {
>>=C2=A0 =C2=A0 =C2=A0 with_test_prefix "continue&qu= ot; {
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history 2 = "continue" 1
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_fo= rward 2 "continue" 1
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Replay in progress\.=C2=A0 At instruction 1\."
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*"
>>=C2=A0 =C2=A0 =C2=A0 }
>>=C2=A0 =C2=A0 =C2=A0 with_test_prefix "reverse-con= tinue" {
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history 2 "reverse-continue" 1
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_ba= ckward 2 "reverse-continue" 1
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Replay in progress\.=C2=A0 At instruction 1\."
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 info record" \
>> @@ -215,8 +225,8 @@ with_test_prefix "no progress= " {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 record goto end" ".*"
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 record goto begin" ".*"
>>
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history 1 = "continue" 1
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history 1 = "step" 1
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_fo= rward 1 "continue" 1
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_fo= rward 1 "step" 1
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*"
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 info record" \
>> @@ -227,8 +237,8 @@ with_test_prefix "no progress= " {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 record goto begin" ".*"
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 record goto end" ".*"
>>
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history 2 = "continue" 1
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history 2 = "step" 1
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_fo= rward 2 "continue" 1
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_fo= rward 2 "step" 1
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Replay in progress\.=C2=A0 At instruction 1\."
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 info record" \
>> @@ -238,7 +248,7 @@ with_test_prefix "no progress= " {
>>=C2=A0 =C2=A0 =C2=A0 with_test_prefix "all" {=
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply all record goto begin" ".*"
>>
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history al= l "continue" 2
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_cont_to_no_history_fo= rward all "continue" 2
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 1 info record" \
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= .*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*"
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gdb_test "threa= d apply 2 info record" \
>> diff --git a/gdb/testsuite/gdb.reverse/break-precsave.exp
>> b/gdb/testsuite/gdb.reverse/break-precsave.exp
>> index b9d94681247..6d3b95933d4 100644
>> --- a/gdb/testsuite/gdb.reverse/break-precsave.exp
>> +++ b/gdb/testsuite/gdb.reverse/break-precsave.exp
>> @@ -73,7 +73,7 @@ proc precsave_tests {} {
>>=C2=A0 =C2=A0 =C2=A0 -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt $"
>> {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pass "go to end= of main forward"
>>=C2=A0 =C2=A0 =C2=A0 }
>> -=C2=A0 =C2=A0 -re "No more reverse-execution his= tory.* end of main .*$gdb_prompt
>> $" {
>> +=C2=A0 =C2=A0 -re "No more reverse-execution his= tory for emulation. Going forward
>> will continue executing and recording.* end of main .*$gdb_prompt $" {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pass "go to end= of main forward"
>>=C2=A0 =C2=A0 =C2=A0 }
>>=C2=A0 =C2=A0 =C2=A0 }
>> @@ -103,7 +103,7 @@ proc precsave_tests {} {
>>=C2=A0 =C2=A0 =C2=A0 -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt $"
>> {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pass "end of re= cord log"
>>=C2=A0 =C2=A0 =C2=A0 }
>> -=C2=A0 =C2=A0 -re "No more reverse-execution his= tory.* end of main .*$gdb_prompt
>> $" {
>> +=C2=A0 =C2=A0 -re "No more reverse-execution his= tory for emulation. Going forward
>> will continue executing and recording.* end of main .*$gdb_prompt $" {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pass "end of re= cord log"
>>=C2=A0 =C2=A0 =C2=A0 }
>>=C2=A0 =C2=A0 =C2=A0 }
>> diff --git a/gdb/testsuite/gdb.reverse/break-reverse.exp
>> b/gdb/testsuite/gdb.reverse/break-reverse.exp
>> index 1dd327ca654..bf74d6f7d07 100644
>> --- a/gdb/testsuite/gdb.reverse/break-reverse.exp
>> +++ b/gdb/testsuite/gdb.reverse/break-reverse.exp
>> @@ -80,7 +80,7 @@ gdb_test_multiple "continue&quo= t; "end of record log" {
>>=C2=A0 =C2=A0 =C2=A0 -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt $" {
>>=C2=A0 =C2=A0 =C2=A0 pass "end of record log"=
>>=C2=A0 =C2=A0 =C2=A0 }
>> -=C2=A0 =C2=A0 -re "No more reverse-execution his= tory.* end of main .*$gdb_prompt $" {
>> +=C2=A0 =C2=A0 -re "No more reverse-execution his= tory for emulation. Going forward will
>> continue executing and recording.* end of main .*$gdb_prompt $" {
>>=C2=A0 =C2=A0 =C2=A0 pass "end of record log"=
>>=C2=A0 =C2=A0 =C2=A0 }
>> }
>> diff --git a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp
>> b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp
>> index 19c5934bfdf..693c304bc18 100644
>> --- a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp
>> +++ b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp
>> @@ -85,7 +85,7 @@ gdb_test_multiple "continue&quo= t; "go to end of main
>> forward" {
>>=C2=A0 =C2=A0 =C2=A0 -re ".*Breakpoint $decimal,.*$srcfile:$endmain.*$gdb_prompt $"=C2=A0 {
>>=C2=A0 =C2=A0 =C2=A0 pass "go to end of main forwa= rd"
>>=C2=A0 =C2=A0 =C2=A0 }
>> -=C2=A0 =C2=A0 -re "No more reverse-execution his= tory.* end main .*$gdb_prompt $" {
>> +=C2=A0 =C2=A0 -re "No more reverse-execution his= tory for emulation. Going forward will
>> continue executing and recording.* end main .*$gdb_prompt $" {
>>=C2=A0 =C2=A0 =C2=A0 pass "go to end of main forwa= rd"
>>=C2=A0 =C2=A0 =C2=A0 }
>> }
>> --
>> 2.42.0
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
>

--
Cheers,
Guinevere Larsen
She/Her/Hers

--000000000000f83e61061537b79d--