From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3W70L5aju2aj9gUAWB0awg (envelope-from ) for ; Tue, 13 Aug 2024 14:19:02 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=AwQWQfK4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9EE371E0D0; Tue, 13 Aug 2024 14:19:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5FC941E08C for ; Tue, 13 Aug 2024 14:19:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BFFA0385841E for ; Tue, 13 Aug 2024 18:18:59 +0000 (GMT) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id C1FF43858C35 for ; Tue, 13 Aug 2024 18:18:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1FF43858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1FF43858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723573120; cv=none; b=ONUKAtT6gBoir9RWHAa5wmyZn0xyElrA0b9F7TZvYgv0iiXsBWGMKYe3j+USkKt/mFmxYuvntUIG9rs/SxEar2JvmFz6D1hsX2e0Sq4uYZ5cwC8LvUoI5VlZbu3Guiq6kkqP6W38jql897DPqbhfOXVr28xuBRGvsOFZOi8xOyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723573120; c=relaxed/simple; bh=yPn17Xn6UHGYoXj+oJibmaASZShNezyYH7ETBzkt48w=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=P/VfiFZ6SEEnxZxF1YLq7fJISrYwNgMYbIqs1Je84TGoi7cyRHdvCGCRtJ49ewbIES8xzvvFdIz2BMyyxgt3bTf+RGplLkPuuuMnBCEZucbWMpRF/FSSmJdXET4KUoAB4ettTtWtNAHx/fE0p+8yHvw95lZrkT3CyrJO0Txgx0c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-52fc4388a64so8058073e87.1 for ; Tue, 13 Aug 2024 11:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723573116; x=1724177916; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yPn17Xn6UHGYoXj+oJibmaASZShNezyYH7ETBzkt48w=; b=AwQWQfK4gmNWQMZGCxFguDhl5xNOc2l2thS97M3Zh4ZpYHZpwCrANIEQjEaAbwxdlA JS1RnUpKXYYK5VlrQYZu1CU06N0lNdG4eKwBAIIk7cbW3NENRXBzuT1xhtE/XmkiDZKP 4M9wGz1vdmkacXE7lY/haB8+1yanCyKwl8B5iA5J2h/HmvUU4VedUiglqAa2WEQpIkAH etjPKhg5B9C4GWGFrCgGfXGBLzUn2QA1l1odasxEqxqOs0Cibc7C6X8PJ4z05oEgZ4Oz irs0KqY/FgEKzRTMcWgSNtZqmhXU0LulS4nRpeyVlrCc6lCMCBcOSSFe1wfUJGT8n7ma cPhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723573116; x=1724177916; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yPn17Xn6UHGYoXj+oJibmaASZShNezyYH7ETBzkt48w=; b=LnGV3NgKjfDKK58M2MpjETWkw8AvkH3lb/kilxQGMw0SF4MJIhpHxwS72znE14Ko7X WQuzhkevn7Z/QLQ2u9AzGJjRk6r/HbrXjnWHYHo0xIBXaURA3Sc4lWHoW3DoK5TBNWn9 3Lukg/MPu+6ih6dgkM9bTFmfvw94MgEMI8MoleT4cqMtwYGpo9sj8tzB4td3Uas4/o+K /qWH+bMRkd4N/yh7FrpcCtKI+PzpAfcKS9SwZzgA3e4d6t1Dr1Tsavr5UrqFQCgzrMuS ohE243W/AB/EuzNhLkYMdLyg6cT9VRtGwM1Nf6xMMR7z1pLkfjd9sB7hMYZKxQVPLQUz jyyA== X-Forwarded-Encrypted: i=1; AJvYcCXR5GT1NzWleDEoiXn/0gwktji5PWIKol+vaml6C92coLypWaBI1dggKZ4gSxpiE6o/Ogtn1simKXOXD7ut6VGsgAJiiYzGvJnLww== X-Gm-Message-State: AOJu0Yw8i+orACcXwuFrmoFbzSb7yCnakSDc11MH/Cs/9kxDAuqbkhQ7 C1t0+vTSBTtXJqLYkP9MJ1nix5vYi3K2pmWHwR9Zo+WKjy4N5AVP/ZsL71cneLLd7EfRWtjBjKx BgCdHaT09rX7F1Pba07cQRWstb4w= X-Google-Smtp-Source: AGHT+IFgmzZIRcqlmXzmI+A14joAem/yHpSguY3wizm+TDgnBoC/Pyt/0snmhcgmE+wmLLEidS/g0si7ohF1uvDWE5o= X-Received: by 2002:a05:6512:b0e:b0:52c:d645:eda7 with SMTP id 2adb3069b0e04-532eda7973cmr133527e87.18.1723573115331; Tue, 13 Aug 2024 11:18:35 -0700 (PDT) MIME-Version: 1.0 References: <20240802164306.252264-1-achronop@gmail.com> <9388437d-557d-45df-8513-d0a91a8e97a7@redhat.com> <23584087-2048-4904-825a-48b0f9d60ebb@redhat.com> In-Reply-To: <23584087-2048-4904-825a-48b0f9d60ebb@redhat.com> From: Alex Chronopoulos Date: Tue, 13 Aug 2024 21:18:23 +0300 Message-ID: Subject: Re: [PATCH v6] Change message when reaching end of reverse history. To: Guinevere Larsen Cc: "Metzger, Markus T" , "gdb-patches@sourceware.org" Content-Type: multipart/alternative; boundary="00000000000048b0d8061f94a357" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --00000000000048b0d8061f94a357 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hooray \o/ Thank you for the reviews. I would like to push myself, how can I get write-after-approval rights? On Tue, Aug 13, 2024 at 2:55=E2=80=AFPM Guinevere Larsen wrote: > On 8/13/24 5:52 AM, Metzger, Markus T wrote: > > Hello Alex, > > > >>> In a record session, when we move backward, GDB switches from normal > >>> execution to simulation. Moving forward again, the emulation continue= s > >>> until the end of the reverse history. When the end is reached, the > >>> execution stops, and a warning message is shown. This message has bee= n > >>> modified to indicate that the forward emulation has reached the end, > but > >>> the execution can continue as normal, and the recording will also > continue. > >>> > >>> Before this patch, the warning message shown in that case was the sam= e > as > >>> in the reverse case. This meant that when the end of history was > reached in > >>> either backward or forward emulation, the same message was displayed: > >>> > >>> "No more reverse-execution history." > >>> > >>> This message has changed for these two cases. Backward emulation: > >>> > >>> "Reached end of recorded history; stopping. > >>> Backward execution from here not possible." > >>> > >>> Forward emulation: > >>> > >>> "Reached end of recorded history; stopping. > >>> Following forward execution will be added to history." > >>> > >>> The reason for this change is that the initial message was deceiving, > for > >>> the forward case, making the user believe that forward debugging coul= d > not > >>> continue. > >>> > >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31224 > >>> --- > >> Hi! I think this is good to go in, but I would like Markus to chime in > >> before pushing, since he mantains the other record subsystem, so for n= ow > >> > >> Reviewed-By: Guinevere Larsen > > OK for btrace. > > Awesome! Alex, feel free to change my tag to: Approved-By: Guinevere > Larsen > > Do you already have write after approval rights for the repo? If not, do > you plan to send more patches, so it makes sense to go after it? If not, > I can push this for you :) > > -- > Cheers, > Guinevere Larsen > She/Her/Hers > > > > > Markus. > > Intel Deutschland GmbH > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > Tel: +49 89 99 8853-0, www.intel.de > > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon > Silva > > Chairperson of the Supervisory Board: Nicole Lau > > Registered Office: Munich > > Commercial Register: Amtsgericht Muenchen HRB 186928 > > --00000000000048b0d8061f94a357 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hooray \o/
Thank you for the reviews.
<= div class=3D"gmail-row gmail-messageRow gmail-sameAuthor gmail-chat gmail-s= elf gmail-type_buffer_msg gmail-userParent"><= span class=3D"gmail-content">I would like to push myself, how can I get write-after-approval rights?

On Tue, Aug 13, 2024 at 2:55= =E2=80=AFPM Guinevere Larsen <blar= sen@redhat.com> wrote:
On 8/13/24 5:52 AM, Metzger, Markus T wrote:
> Hello Alex,
>
>>> In a record session, when we move backward, GDB switches from = normal
>>> execution to simulation. Moving forward again, the emulation c= ontinues
>>> until the end of the reverse history. When the end is reached,= the
>>> execution stops, and a warning message is shown. This message = has been
>>> modified to indicate that the forward emulation has reached th= e end, but
>>> the execution can continue as normal, and the recording will a= lso continue.
>>>
>>> Before this patch, the warning message shown in that case was = the same as
>>> in the reverse case. This meant that when the end of history w= as reached in
>>> either backward or forward emulation, the same message was dis= played:
>>>
>>> "No more reverse-execution history."
>>>
>>> This message has changed for these two cases. Backward emulati= on:
>>>
>>> "Reached end of recorded history; stopping.
>>> Backward execution from here not possible."
>>>
>>> Forward emulation:
>>>
>>> "Reached end of recorded history; stopping.
>>> Following forward execution will be added to history." >>>
>>> The reason for this change is that the initial message was dec= eiving, for
>>> the forward case, making the user believe that forward debuggi= ng could not
>>> continue.
>>>
>>> Bug: https://sourceware.org/bugz= illa/show_bug.cgi?id=3D31224
>>> ---
>> Hi! I think this is good to go in, but I would like Markus to chim= e in
>> before pushing, since he mantains the other record subsystem, so f= or now
>>
>> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
> OK for btrace.

Awesome! Alex, feel free to change my tag to: Approved-By: Guinevere
Larsen <blarsen@= redhat.com>

Do you already have write after approval rights for the repo? If not, do you plan to send more patches, so it makes sense to go after it? If not, I can push this for you :)

--
Cheers,
Guinevere Larsen
She/Her/Hers

>
> Markus.
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon = Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

--00000000000048b0d8061f94a357--