From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24029 invoked by alias); 19 Jan 2020 16:18:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24009 invoked by uid 89); 19 Jan 2020 16:18:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Get-Message-Sender-Via:user X-HELO: nhostc02.canaca.com Received: from nhostc02.canaca.com (HELO nhostc02.canaca.com) (66.49.205.157) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Jan 2020 16:18:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=myosotissp.com; s=default; h=Content-Type:Cc:To:Subject:Message-ID:Date: From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DVBKunuVs4JNEDEQEo7s2b9XnNWsMzjKeMzQBFO+q/I=; b=fyd0bcyrP9lXTVKKxxFJzQytM vAohRfImZJaBRaK4kIvw0oYSf97x1sZfynQThLkKUb9QjuIi66sCqVSj58APm/6K/jw0CYN0ncms4 T9ZN1fQTW4bvkVJWJ0FTdvKMWyIsf2UML+cfq0QjkI9BjL2hElO8Cy2Dv+o+jEkxikWUWcfdw27ZE 8m9YLO3z7NUo+3JbKBq11Ry7PLaMLZXgg6um9MPWL6ahsV4cWR4fgy3BHcJxuBRlRjNmmQgtRxDQQ UZytZJ8ATdwqe/HKhqAhoMnV+OE1XiaX40MVE6c4lIENMC4TZZBzu7L2803cI/nmCSsqRpMM/CIHl bk/oEWsrA==; Received: from mail-ed1-f54.google.com ([209.85.208.54]:38619) by nhostc02.canaca.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1itDHC-0008GW-Fl for gdb-patches@sourceware.org; Sun, 19 Jan 2020 11:18:14 -0500 Received: by mail-ed1-f54.google.com with SMTP id i16so27166265edr.5 for ; Sun, 19 Jan 2020 08:18:14 -0800 (PST) MIME-Version: 1.0 References: <79aec7d1-787d-1693-c0b7-b8bb53cdf3b4@simark.ca> <70d20408-1f27-560c-aa9e-a496624e1113@simark.ca> In-Reply-To: <70d20408-1f27-560c-aa9e-a496624e1113@simark.ca> From: Mark Williams Date: Sun, 19 Jan 2020 16:31:00 -0000 Message-ID: Subject: Re: [PATCH] Fix toplevel types with -fdebug-types-section To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="00000000000085d7c7059c80855f" X-SW-Source: 2020-01/txt/msg00583.txt.bz2 --00000000000085d7c7059c80855f Content-Type: text/plain; charset="UTF-8" Content-length: 68 New patch, with more detail in the commit message, and a test case. --00000000000085d7c7059c80855f Content-Type: application/octet-stream; name="0001-gdb-Fix-toplevel-types-with-fdebug-types-section.patch" Content-Disposition: attachment; filename="0001-gdb-Fix-toplevel-types-with-fdebug-types-section.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k5l83ggk0 Content-length: 6572 RnJvbSBmYWM4YWM5NTU5ZjJiOTczMjVmMGZhYjMzMTVhZmM1MDg4ZDZjMzhk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBtd2lsbGlhbXMgPG13 aWxsaWFtc0BmYi5jb20+CkRhdGU6IFN1biwgMTkgSmFuIDIwMjAgMDg6MDk6 NTkgLTA4MDAKU3ViamVjdDogW1BBVENIXSBnZGI6IEZpeCB0b3BsZXZlbCB0 eXBlcyB3aXRoIC1mZGVidWctdHlwZXMtc2VjdGlvbgoKV2hlbiBkZWJ1Z2dp bmcgYSBwcm9ncmFtIGNvbXBpbGVkIHdpdGggLWZkZWJ1Zy10eXBlcy1zZWN0 aW9uLApvbmx5IHRoZSBmaXJzdCB0b3AtbGV2ZWwgdHlwZSBpbiBlYWNoIGZp bGUgaXMgdmlzaWJsZSB0byBnZGIuCgpUaGUgcHJvYmxlbSB3YXMgY2F1c2Vk IGJ5IG1vdmluZyB0aGUgYXNzaWdubWVudCB0byBsaXN0X2luX3Njb3BlCmZy b20gcHJvY2Vzc19mdWxsX2NvbXBfdW5pdCBhbmQgcHJvY2Vzc19mdWxsX3R5 cGVfdW5pdCB0bwpzdGFydF9zeW10YWIuIFRoaXMgd2FzIGZpbmUgZm9yIHBy b2Nlc3NfZnVsbF9jb21wX3VuaXQsIGJlY2F1c2UKc3ltdGFicyBhbmQgY29t cCB1bml0cyBhcmUgb25lLXRvLW9uZS4gQnV0IHRoZXJlIGNhbiBiZSBtYW55 IHR5cGUKdW5pdHMgcGVyIHN5bXRhYiAob25lIGZvciBlYWNoIHR5cGUpLCBh bmQgd2Ugb25seSBjYWxsIHN0YXJ0X3N5bXRhYgpmb3IgdGhlIGZpcnN0IG9u ZS4gVGhpcyBhZGRzIHRoZSBuZWNlc3NhcnkgYXNzaWdubWVudHMgb24gdGhl IHBhdGhzCndoZXJlIHN0YXJ0X3N5bXRhYiBpcyBub3QgY2FsbGVkLgoKZ2Ri L0NoYW5nZWxvZwoyMDIwLTAxLTE5IE1hcmsgV2lsbGlhbXMgPG1hcmtAbXlv c290aXNzcC5jb20+CgoJUFIgZ2RiLzI0NDgwCgkqIGR3YXJmMnJlYWQuYyBh ZGQgbWlzc2luZyBhc3NpbmdtZW50cyB0byBsaXN0X2luX3Njb3BlIHdoZW4K CXN0YXJ0X3N5bXRhYiB3YXMgYWxyZWFkeSBjYWxsZWQuCgpnZGIvdGVzdHN1 aXRlL0NoYW5nZWxvZwoyMDIwLTAxLTE5IE1hcmsgV2lsbGlhbXMgPG1hcmtA bXlvc290aXNzcC5jb20+CgoJUFIgZ2RiLzI0NDgwCgkqIGR3NC10b3BsZXZl bC10eXBlcy5leHAgVGVzdCBmb3IgdG9wIGxldmVsIHR5cGVzCgkqIGR3NC10 b3BsZXZlbC10eXBlcy5jYyBUZXN0IGZvciB0b3AgbGV2ZWwgdHlwZXMKLS0t CiBnZGIvZHdhcmYycmVhZC5jICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgMiArKwogLi4uL2dkYi5kd2FyZjIvZHc0LXRvcGxldmVsLXR5cGVz LmNjICAgICAgICAgIHwgMjEgKysrKysrKysrKysKIC4uLi9nZGIuZHdhcmYy L2R3NC10b3BsZXZlbC10eXBlcy5leHAgICAgICAgICB8IDM1ICsrKysrKysr KysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNTggaW5zZXJ0aW9ucygr KQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdkYi90ZXN0c3VpdGUvZ2RiLmR3YXJm Mi9kdzQtdG9wbGV2ZWwtdHlwZXMuY2MKIGNyZWF0ZSBtb2RlIDEwMDY0NCBn ZGIvdGVzdHN1aXRlL2dkYi5kd2FyZjIvZHc0LXRvcGxldmVsLXR5cGVzLmV4 cAoKZGlmZiAtLWdpdCBhL2dkYi9kd2FyZjJyZWFkLmMgYi9nZGIvZHdhcmYy cmVhZC5jCmluZGV4IGQxYjY1YjdiYzMuLmM4ZjBkMjdmOTEgMTAwNjQ0Ci0t LSBhL2dkYi9kd2FyZjJyZWFkLmMKKysrIGIvZ2RiL2R3YXJmMnJlYWQuYwpA QCAtMTE3NjIsNiArMTE3NjIsNyBAQCBkd2FyZjJfY3U6OnNldHVwX3R5cGVf dW5pdF9ncm91cHMgKHN0cnVjdCBkaWVfaW5mbyAqZGllKQogCQkJICAgIENP TVBVTklUX0RJUk5BTUUgKGN1c3QpLAogCQkJICAgIGNvbXB1bml0X2xhbmd1 YWdlIChjdXN0KSwKIAkJCSAgICAwLCBjdXN0KSk7CisJICBsaXN0X2luX3Nj b3BlID0gZ2V0X2J1aWxkZXIgKCktPmdldF9maWxlX3N5bWJvbHMgKCk7CiAJ fQogICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTExODEzLDYgKzExODE0LDcg QEAgZHdhcmYyX2N1OjpzZXR1cF90eXBlX3VuaXRfZ3JvdXBzIChzdHJ1Y3Qg ZGllX2luZm8gKmRpZSkKIAkJCUNPTVBVTklUX0RJUk5BTUUgKGN1c3QpLAog CQkJY29tcHVuaXRfbGFuZ3VhZ2UgKGN1c3QpLAogCQkJMCwgY3VzdCkpOwor ICAgICAgbGlzdF9pbl9zY29wZSA9IGdldF9idWlsZGVyICgpLT5nZXRfZmls ZV9zeW1ib2xzICgpOwogCiAgICAgICBhdXRvICZmaWxlX25hbWVzID0gbGlu ZV9oZWFkZXItPmZpbGVfbmFtZXMgKCk7CiAgICAgICBmb3IgKGkgPSAwOyBp IDwgZmlsZV9uYW1lcy5zaXplICgpOyArK2kpCmRpZmYgLS1naXQgYS9nZGIv dGVzdHN1aXRlL2dkYi5kd2FyZjIvZHc0LXRvcGxldmVsLXR5cGVzLmNjIGIv Z2RiL3Rlc3RzdWl0ZS9nZGIuZHdhcmYyL2R3NC10b3BsZXZlbC10eXBlcy5j YwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi5lYmI5 ZWE3ZjE2Ci0tLSAvZGV2L251bGwKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIu ZHdhcmYyL2R3NC10b3BsZXZlbC10eXBlcy5jYwpAQCAtMCwwICsxLDIxIEBA CisvKiBUaGlzIHRlc3RjYXNlIGlzIHBhcnQgb2YgR0RCLCB0aGUgR05VIGRl YnVnZ2VyLgorCisgICBDb3B5cmlnaHQgMjAxNiBGcmVlIFNvZnR3YXJlIEZv dW5kYXRpb24sIEluYy4KKworICAgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29m dHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkK KyAgIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVi bGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisgICB0aGUgRnJlZSBTb2Z0 d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNl bnNlLCBvcgorICAgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lv bi4KKworICAgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBo b3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgICBidXQgV0lUSE9VVCBB TlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50 eSBvZgorICAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFS VElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorICAgR05VIEdlbmVyYWwgUHVi bGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworICAgWW91IHNob3Vs ZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVi bGljIExpY2Vuc2UKKyAgIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYg bm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LiAgKi8K Kworc3RydWN0IFgge30geDsKK3N0cnVjdCBZIHt9IHk7CitzdHJ1Y3QgWiB7 fSB6OworaW50IG1haW4oKSB7fQpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0 ZS9nZGIuZHdhcmYyL2R3NC10b3BsZXZlbC10eXBlcy5leHAgYi9nZGIvdGVz dHN1aXRlL2dkYi5kd2FyZjIvZHc0LXRvcGxldmVsLXR5cGVzLmV4cApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi43MGRjMjRjYmE1 Ci0tLSAvZGV2L251bGwKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuZHdhcmYy L2R3NC10b3BsZXZlbC10eXBlcy5leHAKQEAgLTAsMCArMSwzNSBAQAorIyBD b3B5cmlnaHQgMjAxMC0yMDIwIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwg SW5jLgorCisjIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3Ug Y2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVy IHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2Ug YXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRp b247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChh dCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMg cHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdp bGwgYmUgdXNlZnVsLAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdp dGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJDSEFO VEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0Uu ICBTZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBt b3JlIGRldGFpbHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBh IGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisjIGFs b25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93 d3cuZ251Lm9yZy9saWNlbnNlcy8+LgorCisjIFRlc3QgZHdhcmY0IHNpZ25h dHVyZWQgdHlwZXMgKERXX1RBR190eXBlX3VuaXQpLgorCitzdGFuZGFyZF90 ZXN0ZmlsZSAuY2MKKworIyBUaGlzIHRlc3QgaXMgaW50ZW5kZWQgZm9yIHRh cmdldHMgd2hpY2ggc3VwcG9ydCBEV0FSRi00LgorIyBTaW5jZSB3ZSBwYXNz IGFuIGV4cGxpY2l0IC1nZHdhcmYtNCAtZmRlYnVnLXR5cGVzLXNlY3Rpb24g dG8gdGhlIGNvbXBpbGVyLAorIyB3ZSBsZXQgdGhhdCBiZSB0aGUgdGVzdCBv ZiB3aGV0aGVyIHRoZSB0YXJnZXQgc3VwcG9ydHMgaXQuCisKK2lmIHsgW3By ZXBhcmVfZm9yX3Rlc3RpbmcgImZhaWxlZCB0byBwcmVwYXJlIiAiJHt0ZXN0 ZmlsZX0iIFwKKwkgICRzcmNmaWxlIHtkZWJ1ZyBjKysgYWRkaXRpb25hbF9m bGFncz0tZ2R3YXJmLTQgYWRkaXRpb25hbF9mbGFncz0tZmRlYnVnLXR5cGVz LXNlY3Rpb259XSB9IHsKKyAgICByZXR1cm4gLTEKK30KKworaWYgIVtydW50 b19tYWluXSB7CisgICAgcmV0dXJuIC0xCit9CisKK2dkYl90ZXN0ICJwdHlw ZSBYIiAidHlwZSA9IHN0cnVjdCBYIHsuKiIKK2dkYl90ZXN0ICJwdHlwZSBZ IiAidHlwZSA9IHN0cnVjdCBZIHsuKiIKK2dkYl90ZXN0ICJwdHlwZSBaIiAi dHlwZSA9IHN0cnVjdCBaIHsuKiIKLS0gCjIuMTcuMQoK --00000000000085d7c7059c80855f--