From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id d9YME/u7fGJQ0QUAWB0awg (envelope-from ) for ; Thu, 12 May 2022 03:49:15 -0400 Received: by simark.ca (Postfix, from userid 112) id 3DD651E220; Thu, 12 May 2022 03:49:15 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=I4An/R57; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C2BE61E01D for ; Thu, 12 May 2022 03:49:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE136385142A for ; Thu, 12 May 2022 07:49:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE136385142A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652341753; bh=U9rV3UxYrhlYz38rW0Bz3IPO160kmOWPZb4MKcmxyfw=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=I4An/R57R64s42qzPv17Addl0T1QsT1hWzwHxux9UvWLYRBY4rBBFsniWVec5qtfz SWNxF7VbyNNrvfV465N5D/3TvuIkgu7kpvVtZ7SIXiVaPCj/fP5buThQovyjq6yDjd /rKwZ0aTQpaPHqmRjB6eLqINqs+4cpJjydWjLCSw= Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id DD479384F015; Thu, 12 May 2022 07:47:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD479384F015 Received: by mail-ed1-x52c.google.com with SMTP id z19so5212677edx.9; Thu, 12 May 2022 00:47:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U9rV3UxYrhlYz38rW0Bz3IPO160kmOWPZb4MKcmxyfw=; b=wnmMyShTrBM7Nrj1mB0MgVpO6ahHs0cAEHlBexUA+tu5Ate8twiuzi3GiuDatoBy9H G+4aA+HOpLC22OBGsMN0oFE4jZaAn3I/CZwCxNdGcFgoVwSvVD+x5zJt2UGlmX2mpUHR nTS49fQZRUTBfdymWq1fG3irjb1k+TBZ/2sfAJHkiaS6LUt0xVMh2pdH48I57dUCJxFv wNzzl0f2MCh5fKcUVCOtEhrWbbpea2MrgH/gcyzdTFep9kHm3MGAV6jss1tVdiCgp6Bs wPz4iTVjTS/oyYDi4zjcguCxLFda7kVHyxFRvyMet75oV17Fb840GB2pO9pnoMCb3QZx 10Bw== X-Gm-Message-State: AOAM533wq8D3/qcJM5Vv8/fr+2XdVYNXbLqVRCFmEhdpApqL0ymeNSs4 qx9PuOitn+vWH36kjmMCUFhRxoIS5yC6Xj18b0qWbsFNTiZSww== X-Google-Smtp-Source: ABdhPJxHDkcYjRmdid4r9wGDrtK5jLpryvSv+bfsrq3pwyDO8yZb/iZRUNhAPLDynvHgw3Dq3+3G+uLRVSzta/FMcDI= X-Received: by 2002:a05:6402:2363:b0:425:bc13:4c8b with SMTP id a3-20020a056402236300b00425bc134c8bmr33759476eda.140.1652341672642; Thu, 12 May 2022 00:47:52 -0700 (PDT) MIME-Version: 1.0 References: <87y1z8szsv.fsf@igel.home> In-Reply-To: <87y1z8szsv.fsf@igel.home> Date: Thu, 12 May 2022 10:47:16 +0300 Message-ID: Subject: Re: [PATCH 2/2] gas/write: extend fx_pcrel_adjust to 16 bits To: Andreas Schwab , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Dmitry Selyutin via Gdb-patches Reply-To: Dmitry Selyutin Cc: Luke Kenneth Casson Leighton , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Wed, May 11, 2022 at 9:13 PM Andreas Schwab wrote: > It's probably better to swap the fx_size and fx_pcrel_adjust fields, so > that fx_pcrel_adjust is aligned on a 16 bit boundary. Thank you for your suggestion! After thinking about it for a while, I suggest moving the fx_pcrel_adjust (16 bits) field to the top, then putting fx_size (8 bits), then the rest. Also, I'd replace `unsigned fx_unused : 2` with a simple `unsigned : 2`, I think this way we can make it even clearer that these bits are spare. But perhaps this should go as a separate change.