From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60353 invoked by alias); 29 Mar 2016 19:56:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60341 invoked by uid 89); 29 Mar 2016 19:56:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 29 Mar 2016 19:56:25 +0000 Received: by mail-ob0-f177.google.com with SMTP id m7so23772926obh.3 for ; Tue, 29 Mar 2016 12:56:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=67PnfYjRorAv6Zkntm8mNKg9IkdKeMQDxwolbV9Mct8=; b=aJEwu91nRRvbAO0qJ8oZm1ef5P/OFv/2sXojhfqpA9OGOJ624FDetAetxyvVTSLSY/ QDlj6i3RcAL9nK17BfLDCu277OaNBGRzNoMvaQdlRnP9ikjINLkUa+NP+ny8BJ06a08+ 4m8+q8+ZP8baBEWxPNG3MUldDnlpwuQiG3aA1fvDPaLPK8nTbL4BAVVzcm6HUZMHuzwS SzG1itf3+ifUs/S107Kp0YKmd3DsuJIaRZh0r7NqK3ulEASM3teMT0JCuLLknMzOVgGL kQioFNPQ/ABLNA9sawFWUDi9oJvKdgCQnXAsZV8AkY/HzDo6wX4GY10IbBBcctB9UkaU FswA== X-Gm-Message-State: AD7BkJJ3HTRz/sngtKnPL76J1lPN7oQ5HGuGvvXZYmIzLbVurKA+z45ggjJMe/WVxrIjpq18cphJ+c66lcikLw== MIME-Version: 1.0 X-Received: by 10.202.45.200 with SMTP id t191mr2269466oit.128.1459281383402; Tue, 29 Mar 2016 12:56:23 -0700 (PDT) Received: by 10.76.11.70 with HTTP; Tue, 29 Mar 2016 12:56:23 -0700 (PDT) In-Reply-To: <56FAD2EA.50003@redhat.com> References: <1459275473-11718-1-git-send-email-jcmvbkbc@gmail.com> <56FAD2EA.50003@redhat.com> Date: Tue, 29 Mar 2016 19:56:00 -0000 Message-ID: Subject: Re: [PATCH v2] gdb: xtensa: fix frame initialization when PC is invalid From: Max Filippov To: Pedro Alves Cc: gdb-patches@sourceware.org, Maxim Grigoriev , Woody LaRue , Marc Gauthier Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-03/txt/msg00535.txt.bz2 On Tue, Mar 29, 2016 at 10:09 PM, Pedro Alves wrote: > On 03/29/2016 07:17 PM, Max Filippov wrote: >> - op1 = read_memory_integer (pc, 1, byte_order); >> - if (XTENSA_IS_ENTRY (gdbarch, op1)) >> + if (safe_read_memory_integer (pc, 1, byte_order, &op1) >> + && XTENSA_IS_ENTRY (gdbarch, op1)) >> { > > I'm surprised if this compiles without an "incompatible pointer type" > warning/error? safe_read_memory_integer's last parameter is > 'LONGEST *', while op1 is 'char', AFAICS. So you need to change op1 > to be a LONGEST to match. You're right, sorry. I've checked that it builds and works, but I've missed that it was configured with --disable-werror. -- Thanks. -- Max