From: Max Filippov <jcmvbkbc@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org, Woody LaRue <larue@cadence.com>
Subject: Re: [PATCH RESEND] gdb: xtensa: fix register counters for xtensa-linux
Date: Sun, 13 Jan 2019 20:08:00 -0000 [thread overview]
Message-ID: <CAMo8Bf+tQ7EKYnPqLjWUprE5eBc38eERBHRxuD=1cKo5fKUSDQ@mail.gmail.com> (raw)
In-Reply-To: <10b845bb829586d6784b53e87dabe8ab@polymtl.ca>
On Sun, Jan 13, 2019 at 11:43 AM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 2019-01-13 14:33, Max Filippov wrote:
> > On Sun, Jan 13, 2019 at 8:32 AM Simon Marchi <simon.marchi@polymtl.ca>
> > wrote:
> >>
> >> On 2019-01-13 03:36, Max Filippov wrote:
> >> > In the original code (prior to 37d9e0623102) num_regs was the smallest
> >> > of
> >> > the number of the first pseudo register or the first privileged
> >> > register, and
> >> > num_pseudo_regs was the total number of registers minus num_regs.
> >> > The register table is constructed so that pseudo registers are always
> >> > at the
> >> > end of it, so num_regs was always equal to num_nonpriv_regs.
> >> > I'd like to restore this in xtensa-linux gdb, and what I do is I
> >> > increase
> >> > num_pseudo_regs by the difference of num_regs and num_nonpriv regs
> >> > and set num_regs equal to num_nonpriv_regs to maintain the above
> >> > equations.
> >>
> >> "num_regs == num_nonpriv_regs": is this only true for Linux, because
> >> we
> >> don't have access to privileged registers (and therefore there are 0
> >> nonpriv registers)?
> >
> > Correct.
> >
> >> For bare-metal, num_regs would be greater than num_nonpriv_regs?
> >
> > Correct.
>
> Ok. For the record, the patch LGTM, but I am not sure if you are waiting
> for a review from Woody in CC?
I'm cc'ing Woody as he's the maintainer of the xtensa gdb in
Cadence/Tensilica. This patch is a resend of an old bugfix,
I guess he'd reply if there was any concern first time I sent it.
--
Thanks.
-- Max
next prev parent reply other threads:[~2019-01-13 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 1:43 Max Filippov
[not found] ` <b818ab1d-3f7f-9132-9c1b-b9b3b2a931e4@ericsson.com>
[not found] ` <CAMo8BfKWJj8=UBiM90p0x9g00K-qQ-47rr5mmbfpQ4KAD5azjg@mail.gmail.com>
2019-01-13 16:32 ` Simon Marchi
2019-01-13 19:33 ` Max Filippov
2019-01-13 19:43 ` Simon Marchi
2019-01-13 20:08 ` Max Filippov [this message]
2019-01-13 21:36 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMo8Bf+tQ7EKYnPqLjWUprE5eBc38eERBHRxuD=1cKo5fKUSDQ@mail.gmail.com' \
--to=jcmvbkbc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=larue@cadence.com \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox