From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128756 invoked by alias); 9 Nov 2018 17:57:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127797 invoked by uid 89); 9 Nov 2018 17:57:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=H*f:sk:404ed12, H*r:sk:e18-v6s, H*r:906, Hx-spam-relays-external:209.85.208.66 X-HELO: mail-ed1-f66.google.com Received: from mail-ed1-f66.google.com (HELO mail-ed1-f66.google.com) (209.85.208.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Nov 2018 17:57:22 +0000 Received: by mail-ed1-f66.google.com with SMTP id e18-v6so2464117eds.2 for ; Fri, 09 Nov 2018 09:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail-gwu-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ncX84clEmmXMiwyZHzeASEmCBKiv6FYzbW0i/rVsTBs=; b=s1GE1ppbeLBfT287T/ZaV/d/9fc1HEARkWavOBGKJfWh7MWvKmB1Xn1qpasQpOB3DK dcPpTpvtyXCWISIIkS50j/lSV5mEeQersVCQ1zrH4EgH1UxO5WryTDBSNybY4nqiiz12 rcN9MIzLVg2dC4C2DfIyI9QLixbxTEx9Omk9ADTCpqH6HMDRYzVGxY8QEExHj+ZxQgj+ ZxBfb2wA+koXjRA1n3xy/q88UrAfhSzmBx9c3JhEb1cwQxqxm1X0kRhV1sVK+H3zVASD a6XbFWiUTbIvQAwUiQvbstEGQemJT/+FnTyZk/pVvcx2Tx0Ie73uWnHvjOLIJfjeYH+n YZXg== MIME-Version: 1.0 Received: by 2002:a17:906:7632:0:0:0:0 with HTTP; Fri, 9 Nov 2018 09:57:19 -0800 (PST) In-Reply-To: <6fa2e271-40d3-7b9c-1056-c180b2f61b98@redhat.com> References: <404ed12c-79ec-7731-c013-47e7001e15a5@mentor.com> <6fa2e271-40d3-7b9c-1056-c180b2f61b98@redhat.com> From: Eric Gallager Date: Fri, 09 Nov 2018 17:57:00 -0000 Message-ID: Subject: Re: Small typo in iconv.m4 To: Jeff Law Cc: Hafiz Abid Qadeer , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-11/txt/msg00165.txt.bz2 On 11/7/18, Jeff Law wrote: > On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote: >> Hi All, >> I was investigating a character set related problem with windows hosted >> GDB and I tracked it down to a typo in iconv.m4. This typo caused >> libiconv detection to fail and related support was not built into gdb. >> >> The problem is with the following line. >> CPPFLAGS="$LIBS $INCICONV" >> which should have been >> CPPFLAGS="$CPPFLAGS $INCICONV" >> >> OK to commit the attached patch? >> >> 2018-11-06 Hafiz Abid Qadeer >> >> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. >> Append $INCICONV to it. >> * gcc/configure: Regenerate. >> * libcpp/configure: Likewise. >> * libstdc++-v3/configure: Likewise. >> * intl/configure: Likewise. >> >> Thanks, >> > THanks. I wasn't sure if you had commit privs, so I went ahead and > installed the patch. > > Jeff > Does this have any effect on GCC bug 78251? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251 Or any of the related bugs under "See Also" for that matter?