Re: [PATCH 5/5] Add x32 support to amd64_analyze_stack_align

Mark Kettenis
2012-06-16T15:16:21Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

> Date: Sat, 16 Jun 2012 07:41:47 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
>
> On Sat, Jun 16, 2012 at 4:27 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >> Date: Wed, 13 Jun 2012 16:08:25 -0700
> >> From: "H.J. Lu" <hongjiu.lu@intel.com>
> >>
> >> Hi,
> >>
> >> This patch adds support to amd64_analyze_stack_align.  OK to install?
> >
> > Sorry, no.  I think this function is complex enough as it is now.
> > Please create a seperate function for x32.  That may lead to some code
> > duplication, but that is better than increasing the complexity of this
> > already complex function.
> >
>
> This patch adds amd64_x32_analyze_stack_align and uses it
> for x32. OK to install?

Thanks, yes, this is fine.

> --
> H.J.
> ---
> * amd64-tdep.c (amd64_x32_analyze_stack_align): New function.
> (amd64_analyze_prologue): Call amd64_x32_analyze_stack_align
> for x32.