From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Adu3M9sM/2XnIRMAWB0awg (envelope-from ) for ; Sat, 23 Mar 2024 13:09:47 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Yx1UuzzH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C556E1E0C0; Sat, 23 Mar 2024 13:09:47 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9D78C1E08C for ; Sat, 23 Mar 2024 13:09:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD5713858D37 for ; Sat, 23 Mar 2024 17:09:44 +0000 (GMT) Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by sourceware.org (Postfix) with ESMTPS id C2DDF3858D28 for ; Sat, 23 Mar 2024 17:09:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2DDF3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2DDF3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1135 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711213767; cv=none; b=aDZXIOj2/bhx3S5+6DzznWKzVEk78G7X7uBoV7R3jUPycuGaJ6g2fS9LRbV7P9/AWWogbemT26tCmt/MLgNs0CVMEJHsezeZJOe7z6EjrAWI1nYoI8k4/4898JbAi7O8kSkvAVs0TVzGtO2z7VYYkp2c59bzrdwHoBAPr4HeK88= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711213767; c=relaxed/simple; bh=NGvxriesJOIl71hVNF1ZIP4pq2Sx9SbBuz1cMP3xhXY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=S3cuc5fMEZdAcXrYPJmFkPb8EVzI3QfB+mfXPsocZrPHbSirqJ8fO4oX6ZIqpVRXrXkHuRjz3GL548JkYEmhsDNAtOVnMxzkSHtzI2E+MmR6AAghuY59nIkmRMop0aYVHuODJ3tHoc1kaTZZKX1VMNYz8b7N6xwz7gBetM+Tghg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-60a434ea806so34434567b3.3 for ; Sat, 23 Mar 2024 10:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711213764; x=1711818564; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1wyxH2kmOaseIlSDLMMafMsBEM/lkrOzQfLeRVmTTWo=; b=Yx1UuzzHQn3tD+XwfcCTLuC0mhOFIJ4gY9Wqit2T/U3GFKMJn67hPUDlmkhyTjhKnG cUTIjw3T9ZmNQG3/u8W4qyotQJsEm2odNdia6RelS97pJkIPwSQft6PazvZoj4D0g3KR 1xSX1m9drWFiJZUQPyZGQEm6oTTl6PhqmKeJUkPl0D1mehgyMRCgXfeae8GG1ZNXJBKC hQ0J1EYPZEkoPBq3VTBuhowYyALrVtYDHsEH5Ap/Cw+LAXE3xEKw69GQH57ORX5e4HhU MPiPd7G048+HSi05KVoQkEmirQZDdHIXBlPtw5boAvGyKoBYbFoxRtDUql4ml7Ig1H+i wN8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711213764; x=1711818564; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1wyxH2kmOaseIlSDLMMafMsBEM/lkrOzQfLeRVmTTWo=; b=ltJsf61iX74aq2xFpwL9fGIY82xjxh6BGMsbEvkfb6XTAGwZp8dQ7Pkiz1+G/hrx7C BuNwYG0nV7I/i1iNwyDPAMOnUCi5mCXHP/0/+YdA4vxgMGIJS6NFGYFsmrWMdXboVxXB CDalwv+lObhNw5TvHu84R6nOZO5pAp96/e1M/mCJce0RDLAqGOCE5TLmQnJMZ5G5tP/H wGQDjAsbUKj5Am8CRp9EuAx5RkL/b6JGvVhixglg3TVY/QnPNfQ7N0Ezn8H06W29NrrK mxp69T+tMO5bDMNw0Zd4nSwbF/Rv4NkAP0t2Uq+nPuiRQMnHUZfEg/HfLenreCCFSz/s B6kQ== X-Gm-Message-State: AOJu0YzXw63yfuWsolTB6DICEwaUp3woVzqeSVSRNftfpkElIOVu+jJD xveKUfYDguWbCy27QD4+pKgR0ehlzn9FGLUZ9DhSOC3ka4dthJGKesAGmX/MQkv+L//YtXHlTYk 6OU/oEnQ8ojWk4X2ZzCp8Z9eA4Ek= X-Google-Smtp-Source: AGHT+IHgSosyg0JzN6mdim5WFxXka7pQvTEYfRv1MBxcuFHtUV8O2ythK4daQ1KijcbMEhR3hoFfOIggnLmXoATjtIc= X-Received: by 2002:a81:73d4:0:b0:60a:66c0:d5fe with SMTP id o203-20020a8173d4000000b0060a66c0d5femr2988492ywc.13.1711213764455; Sat, 23 Mar 2024 10:09:24 -0700 (PDT) MIME-Version: 1.0 References: <20240320111318.117728-1-hjl.tools@gmail.com> <87edc1tcdd.fsf@redhat.com> <87bk74uckv.fsf@redhat.com> In-Reply-To: <87bk74uckv.fsf@redhat.com> From: "H.J. Lu" Date: Sat, 23 Mar 2024 10:08:48 -0700 Message-ID: Subject: Re: [PATCH v2] gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 To: Andrew Burgess Cc: gdb-patches@sourceware.org, felix.willgerodt@intel.com, jhb@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Sat, Mar 23, 2024 at 9:39=E2=80=AFAM Andrew Burgess wrote: > > Andrew Burgess writes: > > > "H.J. Lu" writes: > > > >> Since MPX isn't available for x32, we should clear X86_XSTATE_MPX bits > >> on x32. > >> > >> PR server/31511 > >> * linux-x86-low.cc (x86_linux_read_description): Clear > >> X86_XSTATE_MPX bits in xcr0 on x32. > >> --- > >> gdbserver/linux-x86-low.cc | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/gdbserver/linux-x86-low.cc b/gdbserver/linux-x86-low.cc > >> index 3af0a009052..933d1fb012a 100644 > >> --- a/gdbserver/linux-x86-low.cc > >> +++ b/gdbserver/linux-x86-low.cc > >> @@ -938,6 +938,10 @@ x86_linux_read_description (void) > >> xcr0 =3D xstateregs[(I386_LINUX_XSAVE_XCR0_OFFSET > >> / sizeof (uint64_t))]; > >> > >> + /* No MPX on x32. */ > >> + if (machine =3D=3D EM_X86_64 && !is_elf64) > >> + xcr0 &=3D ~X86_XSTATE_MPX; > > > > Hi, > > > > I have a series in flight that conflicts with this change: > > > > https://inbox.sourceware.org/gdb-patches/cover.1706801009.git.aburges= s@redhat.com > > > > And so I'm trying to resolve the conflicts. > > OK, I think I may have resolved the conflict. I'm still unable to test > x32 ABI, would you mind applying this series: > > https://inbox.sourceware.org/gdb-patches/cover.1711211528.git.aburgess@= redhat.com > > and checking that your x32 use case still behaves as you expect. The > merge of our work occurs in this patch: > > https://inbox.sourceware.org/gdb-patches/a76168beacd9bb79b72ca1a0d26995= abd770104c.1711211528.git.aburgess@redhat.com > > Also, I invite you to take a look at this additional patch which adds an > extra assert that relates to your work: > > https://inbox.sourceware.org/gdb-patches/159cadba5ba824579cbc6426cb26f4= 5228eda0a7.1711211528.git.aburgess@redhat.com > > Any feedback would be great. > I applied the whole patch series from https://patchwork.sourceware.org/project/gdb/list/?series=3D32189 Both gdb and gdbserver work on x32. Thanks. --=20 H.J.