From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95294 invoked by alias); 1 Jun 2018 16:51:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89373 invoked by uid 89); 1 Jun 2018 16:50:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS,UPPERCASE_50_75 autolearn=ham version=3.3.2 spammy=silence, DIAGNOSTIC_POP, diagnostic_pop X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f68.google.com Received: from mail-oi0-f68.google.com (HELO mail-oi0-f68.google.com) (209.85.218.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Jun 2018 16:50:10 +0000 Received: by mail-oi0-f68.google.com with SMTP id l22-v6so15309257oib.4; Fri, 01 Jun 2018 09:50:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=e1Xs4OLc7NCtTN02XXNZsOAG11UGFfrnguRoRzAOS7E=; b=mVWYMRTCP1vu3pWHJ5I/3uEb0Ge02QzoB0kC+4FLJdzkWqWlPzvu7ckzt2M7h+r7KC 9MOuAarrjiAfFSGix+qKR1uHD6nDKhESRPq6F7fXyLvBQvsXtf2WxTNb6kFiExvU0hE+ sj3WBioMc1xqDqLacTWsdrIqBke+hWDvMs2L7ObJe1nRDgWbfbly9mlum3IakR87rrzu ED1P0QYqe9HPdDRpPbfcBqwc7vj8uZlg4y7r28fRKVvbZ723Jr9R8TmWBa2cbxG1PumU cD8yRSwoTLsB+FHtxnZ4byk+iiphV602DqrwW0d0M8kF8xoEgWn47+Cj6hcfOqoGq11w OH7w== X-Gm-Message-State: APt69E2PiC6FkHCnrbeEMHFTYkzCO7W+PFwK8fWqfHFNDi7TZgY7qwtv ja5nSZ7aeCzrOSolvcBcuLw0tIXS9Or6+/lZBlk= X-Google-Smtp-Source: ADUXVKI0KbVUnw2vgIIp3WgRCq/4mEX5EVq7wdIgBp9cuAbvhhu22uxWl/qxh/KTkMYt1CJf9kM97fuM8BzjMFljf1Q= X-Received: by 2002:aca:b888:: with SMTP id i130-v6mr6929511oif.279.1527871809162; Fri, 01 Jun 2018 09:50:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:7019:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 09:50:08 -0700 (PDT) In-Reply-To: <20180601101949.GA7660@bubble.grove.modra.org> References: <20180521121557.16535-1-hjl.tools@gmail.com> <20180521121557.16535-2-hjl.tools@gmail.com> <20180601101949.GA7660@bubble.grove.modra.org> From: "H.J. Lu" Date: Fri, 01 Jun 2018 16:51:00 -0000 Message-ID: Subject: Re: [PATCH 2/3] Add DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION To: Alan Modra Cc: Nick Clifton , Binutils , GDB Content-Type: multipart/mixed; boundary="00000000000072e22b056d97605f" X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00024.txt.bz2 --00000000000072e22b056d97605f Content-Type: text/plain; charset="UTF-8" Content-length: 738 On Fri, Jun 1, 2018 at 3:19 AM, Alan Modra wrote: > On Fri, Jun 01, 2018 at 08:57:20AM +0100, Nick Clifton wrote: >> Hi H.J. >> >> > +# if __GNUC__ >= 8 >> > +# define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION \ >> > + DIAGNOSTIC_IGNORE ("-Wstringop-truncation") >> > +# endif >> > +#endif >> >> Presumably the Wstringop-truncation bug will be fixed in gcc 8.1 >> so shouldn't the test check the revision number as well ? > > Yes, it has already been fixed. > The bug is in GCC 8.1 and will be fixed in GCC 8.2. Here is the updated patch with +# if __GNUC__ == 8 && __GNUC_MINOR__ < 2 +# define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION \ + DIAGNOSTIC_IGNORE ("-Wstringop-truncation") +# endif OK for master? -- H.J. --00000000000072e22b056d97605f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION.patch" Content-Disposition: attachment; filename="0001-Add-DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jhw7a6cr0 Content-length: 3795 RnJvbSBiYjFkM2RkZDc4YWJmMjViMzBlMTFjZjI1ZTRiMmVjN2I2ZWYwNjg4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IE1vbiwgMjEgTWF5IDIwMTggMDU6 MDY6MzkgLTA3MDAKU3ViamVjdDogW1BBVENIIDEvMl0gQWRkIERJQUdOT1NU SUNfSUdOT1JFX1NUUklOR09QX1RSVU5DQVRJT04KCkFkZCBESUFHTk9TVElD X0lHTk9SRV9TVFJJTkdPUF9UUlVOQ0FUSU9OIGZvciBHQ0MgOC4xIHRvIHNp bGVuY2UKLVdzdHJpbmdvcC10cnVuY2F0aW9uIHdhcm5pbmc6CgpodHRwczov L2djYy5nbnUub3JnL2J1Z3ppbGxhL3Nob3dfYnVnLmNnaT9pZD04NTY0MwoK CSogZGlhZ25vc3RpY3MuaCAoRElBR05PU1RJQ19TVFJJTkdJRllfMSk6IE5l dy4KCShESUFHTk9TVElDX1NUUklOR0lGWSk6IExpa2V3aXNlLgoJKERJQUdO T1NUSUNfSUdOT1JFKTogUmVwbGFjZSBTVFJJTkdJRlkgd2l0aCBESUFHTk9T VElDX1NUUklOR0lGWS4KCShESUFHTk9TVElDX0lHTk9SRV9TRUxGX01PVkUp OiBEZWZpbmUgZW1wdHkgaWYgbm90IGRlZmluZWQuCgkoRElBR05PU1RJQ19J R05PUkVfREVQUkVDQVRFRF9SRUdJU1RFUik6IExpa2V3aXNlLgoJKERJQUdO T1NUSUNfSUdOT1JFX1VOVVNFRF9GVU5DVElPTik6IExpa2V3aXNlLgoJKERJ QUdOT1NUSUNfSUdOT1JFX1NXSVRDSF9ESUZGRVJFTlRfRU5VTV9UWVBFUyk6 IExpa2V3aXNlLgoJKERJQUdOT1NUSUNfSUdOT1JFX1NUUklOR09QX1RSVU5D QVRJT04pOiBOZXcuCi0tLQogaW5jbHVkZS9kaWFnbm9zdGljcy5oIHwgMzEg KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDI0IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvaW5jbHVkZS9kaWFnbm9zdGljcy5oIGIvaW5jbHVkZS9kaWFnbm9z dGljcy5oCmluZGV4IDA3MjU2NjQxNzcuLmY3NDEyZDRhMzggMTAwNjQ0Ci0t LSBhL2luY2x1ZGUvZGlhZ25vc3RpY3MuaAorKysgYi9pbmNsdWRlL2RpYWdu b3N0aWNzLmgKQEAgLTE5LDggKzE5LDEzIEBACiAjaWZkZWYgX19HTlVDX18K ICMgZGVmaW5lIERJQUdOT1NUSUNfUFVTSCBfUHJhZ21hICgiR0NDIGRpYWdu b3N0aWMgcHVzaCIpCiAjIGRlZmluZSBESUFHTk9TVElDX1BPUCBfUHJhZ21h ICgiR0NDIGRpYWdub3N0aWMgcG9wIikKKworLyogU3RyaW5naWZpY2F0aW9u LiAgKi8KKyMgZGVmaW5lIERJQUdOT1NUSUNfU1RSSU5HSUZZXzEoeCkgI3gK KyMgZGVmaW5lIERJQUdOT1NUSUNfU1RSSU5HSUZZKHgpIERJQUdOT1NUSUNf U1RSSU5HSUZZXzEgKHgpCisKICMgZGVmaW5lIERJQUdOT1NUSUNfSUdOT1JF KG9wdGlvbikgXAotICBfUHJhZ21hIChTVFJJTkdJRlkgKEdDQyBkaWFnbm9z dGljIGlnbm9yZWQgb3B0aW9uKSkKKyAgX1ByYWdtYSAoRElBR05PU1RJQ19T VFJJTkdJRlkgKEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgb3B0aW9uKSkKICNl bHNlCiAjIGRlZmluZSBESUFHTk9TVElDX1BVU0gKICMgZGVmaW5lIERJQUdO T1NUSUNfUE9QCkBAIC0zNywyNCArNDIsMzYgQEAKICMgaWYgX19oYXNfd2Fy bmluZyAoIi1XZW51bS1jb21wYXJlLXN3aXRjaCIpCiAjICBkZWZpbmUgRElB R05PU1RJQ19JR05PUkVfU1dJVENIX0RJRkZFUkVOVF9FTlVNX1RZUEVTIFwK ICAgIERJQUdOT1NUSUNfSUdOT1JFICgiLVdlbnVtLWNvbXBhcmUtc3dpdGNo IikKLSMgZWxzZQotIyAgZGVmaW5lIERJQUdOT1NUSUNfSUdOT1JFX1NXSVRD SF9ESUZGRVJFTlRfRU5VTV9UWVBFUwogIyBlbmRpZgogI2VsaWYgZGVmaW5l ZCAoX19HTlVDX18pIC8qIEdDQyAqLwogCi0jIGRlZmluZSBESUFHTk9TVElD X0lHTk9SRV9TRUxGX01PVkUKLSMgZGVmaW5lIERJQUdOT1NUSUNfSUdOT1JF X0RFUFJFQ0FURURfUkVHSVNURVIKICMgZGVmaW5lIERJQUdOT1NUSUNfSUdO T1JFX1VOVVNFRF9GVU5DVElPTiBcCiAgIERJQUdOT1NUSUNfSUdOT1JFICgi LVd1bnVzZWQtZnVuY3Rpb24iKQotIyBkZWZpbmUgRElBR05PU1RJQ19JR05P UkVfU1dJVENIX0RJRkZFUkVOVF9FTlVNX1RZUEVTCiAKLSNlbHNlIC8qIE90 aGVyIGNvbXBpbGVycyAqLworIyBpZiBfX0dOVUNfXyA9PSA4ICYmIF9fR05V Q19NSU5PUl9fIDwgMgorIyAgZGVmaW5lIERJQUdOT1NUSUNfSUdOT1JFX1NU UklOR09QX1RSVU5DQVRJT04gXAorICBESUFHTk9TVElDX0lHTk9SRSAoIi1X c3RyaW5nb3AtdHJ1bmNhdGlvbiIpCisjIGVuZGlmCisjZW5kaWYKIAorI2lm bmRlZiBESUFHTk9TVElDX0lHTk9SRV9TRUxGX01PVkUKICMgZGVmaW5lIERJ QUdOT1NUSUNfSUdOT1JFX1NFTEZfTU9WRQorI2VuZGlmCisKKyNpZm5kZWYg RElBR05PU1RJQ19JR05PUkVfREVQUkVDQVRFRF9SRUdJU1RFUgogIyBkZWZp bmUgRElBR05PU1RJQ19JR05PUkVfREVQUkVDQVRFRF9SRUdJU1RFUgorI2Vu ZGlmCisKKyNpZm5kZWYgRElBR05PU1RJQ19JR05PUkVfVU5VU0VEX0ZVTkNU SU9OCiAjIGRlZmluZSBESUFHTk9TVElDX0lHTk9SRV9VTlVTRURfRlVOQ1RJ T04KKyNlbmRpZgorCisjaWZuZGVmIERJQUdOT1NUSUNfSUdOT1JFX1NXSVRD SF9ESUZGRVJFTlRfRU5VTV9UWVBFUwogIyBkZWZpbmUgRElBR05PU1RJQ19J R05PUkVfU1dJVENIX0RJRkZFUkVOVF9FTlVNX1RZUEVTCisjZW5kaWYKIAor I2lmbmRlZiBESUFHTk9TVElDX0lHTk9SRV9TVFJJTkdPUF9UUlVOQ0FUSU9O CisjIGRlZmluZSBESUFHTk9TVElDX0lHTk9SRV9TVFJJTkdPUF9UUlVOQ0FU SU9OCiAjZW5kaWYKIAogI2VuZGlmIC8qIERJQUdOT1NUSUNTX0ggKi8KLS0g CjIuMTcuMAoK --00000000000072e22b056d97605f--