From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83564-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15861 invoked by alias); 8 Sep 2011 16:01:58 -0000
Received: (qmail 15852 invoked by uid 22791); 8 Sep 2011 16:01:56 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-qy0-f176.google.com (HELO mail-qy0-f176.google.com) (209.85.216.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Sep 2011 16:01:42 +0000
Received: by qyl16 with SMTP id 16so646536qyl.0        for <gdb-patches@sourceware.org>; Thu, 08 Sep 2011 09:01:41 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.67.220 with SMTP id s28mr660850qci.270.1315497701609; Thu, 08 Sep 2011 09:01:41 -0700 (PDT)
Received: by 10.229.97.75 with HTTP; Thu, 8 Sep 2011 09:01:41 -0700 (PDT)
In-Reply-To: <20110908153454.GE23706@host1.jankratochvil.net>
References: <20110826092539.GA23720@host1.jankratochvil.net>	<CAMe9rOpqQySk0Jdhgp9NPq6QAaa-nobrD1DBNuyHzXtNEcuZcQ@mail.gmail.com>	<20110828200640.GA10351@host1.jankratochvil.net>	<201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl>	<20110908153454.GE23706@host1.jankratochvil.net>
Date: Thu, 08 Sep 2011 17:16:00 -0000
Message-ID: <CAMe9rOrMFwy+AJKoartsK49v7OFxn+aj8ema7bToz_Bdex1X-w@mail.gmail.com>
Subject: Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-09/txt/msg00144.txt.bz2

On Thu, Sep 8, 2011 at 8:34 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Sun, 28 Aug 2011 23:05:34 +0200, Mark Kettenis wrote:
>> > From: Jan Kratochvil <jan.kratochvil@redhat.com>
>> > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*.
>>
>> Uh, that's wrong. =A0The middle part if the target triplet is supposed
>> to be the hardware vendor. =A0For i386/amd64 this is pretty much
>> meaningles, but attaching a new meaning to it would be a mistake.
>>
>> Fortunately, your diff doesn't really depend on this. =A0But I think you
>> should adjust the comments in the code.
>
> The triple x86_64-x32-linux* is a reality in binutils, gcc etc., I believ=
e if
> it should be changed GDB is not the place to start such change.
>
> And the comments should reflect the reality.
>
> OK to check it in as is?
>

I am using x86_64-x32-linux* for x32.  Instead, I
am using x86_64-*-linux* with sizeof (long) =3D=3D 4.

--=20
H.J.