From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by sourceware.org (Postfix) with ESMTPS id 64B393860C3E; Mon, 27 Jul 2020 19:32:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 64B393860C3E Received: by mail-il1-x141.google.com with SMTP id y18so5695016ilp.10; Mon, 27 Jul 2020 12:32:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TRl4Zi4iYQAqgqekSC4QkEQsIIU/sxOT0AjdZe4OkYg=; b=PYbMC6pndnEgN9QFpB427Q9iBYWKzfqzWS+x6j3qCogZegeeeKMOtkefyRn766w07Q DsWkqEJHiWhzq5MtVziIZEC4fXIi1IudHpwFUMkvEzhHXjTEl9NB8vPMxbdzYA6Bw9iQ 9VgSvdJYsLCHAgFWLe6eLs/8E+auowM8FmHSjtysC6+KqXLXlWp8DCBnXR2B9luJfBph qD6AQANTtiReObFoBak7CwyD/V/z5FyZ2f1+czJrnXnk+uJMMclIbxqvsAsmEuUHM1Oi G7mY/hKu5I1JSGcqpFjgPvE5KPywQHF9UhgTAHzsoQlm++fIbDbDQuCUysKktdSvXvEM G9kQ== X-Gm-Message-State: AOAM530XL6iolNLQE0Ev7AuyERMgp0NtrFgrWlreXu3MeiRHgpHu89q9 JHG4O7btgKmYZ5S13EPR33oSneztA5mLUFmBPO0XsGZFQl4= X-Google-Smtp-Source: ABdhPJxoex3NlVFVMDdSP3lI7LV8Ga0rqXDgpuREgGO6QPhYo3YUzIxqM4oGolbAQkj/Rbz4ThHlazuokp1sWbdeqg4= X-Received: by 2002:a92:40cc:: with SMTP id d73mr13812869ill.213.1595878360551; Mon, 27 Jul 2020 12:32:40 -0700 (PDT) MIME-Version: 1.0 References: <20200502022903.175852-1-amerey@redhat.com> <3d9da16939fa6b503188033b56d30531e03d5d2a.camel@redhat.com> <87a72ino27.fsf@tromey.com> <64517fee-8b8f-84b2-a116-c3d146ff1119@simark.ca> <87eep4hp3s.fsf@tromey.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 27 Jul 2020 12:32:04 -0700 Message-ID: Subject: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works To: Aaron Merey Cc: Tom Tromey , Simon Marchi , GCC Patches , Aaron Merey via Binutils , GDB Content-Type: multipart/mixed; boundary="000000000000c9376805ab7162c0" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 19:32:43 -0000 --000000000000c9376805ab7162c0 Content-Type: text/plain; charset="UTF-8" On Mon, Jul 27, 2020 at 12:14 PM H.J. Lu wrote: > > On Mon, Jul 27, 2020 at 9:11 AM Aaron Merey wrote: > > > > On Mon, Jul 27, 2020 at 11:32 AM H.J. Lu wrote: > > > > > > On Sat, Jul 25, 2020 at 9:01 AM H.J. Lu wrote: > > > > This caused: > > > > > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=26301 > > > > > > > > > > It is quite normal to have debuginfod headers without libdebuginfod on > > > multilib OSes. Restore AC_CHECK_LIB to check if libdebuginfod exists. > > > And always define HAVE_LIBDEBUGINFOD to 0 or 1 for > > > > > > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > > > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > > > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > > > binutils/dwarf.h:#if HAVE_LIBDEBUGINFOD > > > binutils/objdump.c:#if HAVE_LIBDEBUGINFOD > > > binutils/objdump.c:#endif /* HAVE_LIBDEBUGINFOD */ > > > binutils/readelf.c:#if HAVE_LIBDEBUGINFOD > > > binutils/readelf.c:#endif /* HAVE_LIBDEBUGINFOD */ > > > gdb/top.c:#if HAVE_LIBDEBUGINFOD > > > > > > OK for master? > > > > Thanks for spotting this. Normally PKG_CHECH_MODULES would correctly > > detect whether the .so and header are installed and build accordingly, > > but when cross compiling the AC_CHECK_LIB may be needed. > > I am not cross compiling. I am simply using "gcc -m32". The problem > is PKG_CHECK_MODULES which doesn't check if $pkg_cv_[]$1[]_LIBS > actually works. Here is the updated patch to fix PKG_CHECK_MODULES. > Any comments or objections? > > HAVE_LIBDEBUGINFOD is a separate issue. Here is the updated patch which only adds AC_TRY_LINK to PKG_CHECK_MODULES to check if $pkg_cv_[]$1[]_LIBS works. -- H.J. --000000000000c9376805ab7162c0 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-PKG_CHECK_MODULES-Check-if-pkg_cv_-1-_LIBS-works.patch" Content-Disposition: attachment; filename="0001-PKG_CHECK_MODULES-Check-if-pkg_cv_-1-_LIBS-works.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kd4wqygy0 RnJvbSA0NDY4MmNlMjk4YThjZTJiNzk1MzAzZDQwNTRlYzUzMjg0N2JmY2FlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IE1vbiwgMjcgSnVsIDIwMjAgMDg6MjQ6MTUgLTA3MDAKU3ViamVjdDogW1BBVENIXSBQS0dfQ0hF Q0tfTU9EVUxFUzogQ2hlY2sgaWYgJHBrZ19jdl9bXSQxW11fTElCUyB3b3JrcwoKSXQgaXMgcXVp dGUgbm9ybWFsIHRvIGhhdmUgaGVhZGVycyB3aXRob3V0IGxpYnJhcnkgb24gbXVsdGlsaWIgT1Nl cy4KQWRkIEFDX1RSWV9MSU5LIHRvIFBLR19DSEVDS19NT0RVTEVTIHRvIGNoZWNrIGlmICRwa2df Y3ZfW10kMVtdX0xJQlMKd29ya3MuCgpjb25maWcvCgoJUFIgYmludXRpbHMvMjYzMDEKCSogcGtn Lm00IChQS0dfQ0hFQ0tfTU9EVUxFUyk6IEFkZCBBQ19UUllfTElOSyB0byBjaGVjayBpZgoJJHBr Z19jdl9bXSQxW11fTElCUyB3b3Jrcy4KCmJpbnV0aWxzLwoKCVBSIGJpbnV0aWxzLzI2MzAxCgkq IGNvbmZpZ3VyZTogUmVnZW5lcmF0ZWQuCgpnZGIvCgoJUFIgYmludXRpbHMvMjYzMDEKCSogY29u ZmlndXJlOiBSZWdlbmVyYXRlZC4KLS0tCiBiaW51dGlscy9jb25maWd1cmUgfCAyMiArKysrKysr KysrKysrKysrKysrKysrCiBjb25maWcvcGtnLm00ICAgICAgfCAgNiArKysrKysKIGdkYi9jb25m aWd1cmUgICAgICB8IDIyICsrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwg NTAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2JpbnV0aWxzL2NvbmZpZ3VyZSBiL2JpbnV0 aWxzL2NvbmZpZ3VyZQppbmRleCBjOWZjNTEwOGUwLi40NjIwYTZiMTA1IDEwMDc1NQotLS0gYS9i aW51dGlscy9jb25maWd1cmUKKysrIGIvYmludXRpbHMvY29uZmlndXJlCkBAIC0xMjQzOSw2ICsx MjQzOSwyOCBAQCBmaQogICAgIHBrZ19mYWlsZWQ9dW50cmllZAogZmkKIAorcGtnX3NhdmVfTERG TEFHUz0iJExERkxBR1MiCitMREZMQUdTPSIkTERGTEFHUyAkcGtnX2N2X0RFQlVHSU5GT0RfTElC UyIKK2NhdCBjb25mZGVmcy5oIC0gPDxfQUNFT0YgPmNvbmZ0ZXN0LiRhY19leHQKKy8qIGVuZCBj b25mZGVmcy5oLiAgKi8KKworaW50CittYWluICgpCit7CityZXR1cm4gMDsKKyAgOworICByZXR1 cm4gMDsKK30KK19BQ0VPRgoraWYgYWNfZm5fY190cnlfbGluayAiJExJTkVOTyI7IHRoZW4gOgor ICBwa2dfZmFpbGVkPW5vCitlbHNlCisgIHBrZ19mYWlsZWQ9eWVzCitmaQorcm0gLWYgY29yZSBj b25mdGVzdC5lcnIgY29uZnRlc3QuJGFjX29iamV4dCBcCisgICAgY29uZnRlc3QkYWNfZXhlZXh0 IGNvbmZ0ZXN0LiRhY19leHQKK0xERkxBR1M9JHBrZ19zYXZlX0xERkxBR1MKKwogCiAKIGlmIHRl c3QgJHBrZ19mYWlsZWQgPSB5ZXM7IHRoZW4KZGlmZiAtLWdpdCBhL2NvbmZpZy9wa2cubTQgYi9j b25maWcvcGtnLm00CmluZGV4IDEzYTg4OTAxNzguLjQ1NTg3ZTk3YzggMTAwNjQ0Ci0tLSBhL2Nv bmZpZy9wa2cubTQKKysrIGIvY29uZmlnL3BrZy5tNApAQCAtMTQ3LDYgKzE0NywxMiBAQCBBQ19N U0dfQ0hFQ0tJTkcoW2ZvciAkMl0pCiBfUEtHX0NPTkZJRyhbJDFdW19DRkxBR1NdLCBbY2ZsYWdz XSwgWyQyXSkKIF9QS0dfQ09ORklHKFskMV1bX0xJQlNdLCBbbGlic10sIFskMl0pCiAKK2RubCBD aGVjayB3aGV0aGVyICRwa2dfY3ZfW10kMVtdX0xJQlMgd29ya3MuCitwa2dfc2F2ZV9MREZMQUdT PSIkTERGTEFHUyIKK0xERkxBR1M9IiRMREZMQUdTICRwa2dfY3ZfW10kMVtdX0xJQlMiCitBQ19U UllfTElOSyhbXSxbcmV0dXJuIDA7XSwgW3BrZ19mYWlsZWQ9bm9dLCBbcGtnX2ZhaWxlZD15ZXNd KQorTERGTEFHUz0kcGtnX3NhdmVfTERGTEFHUworCiBtNF9kZWZpbmUoW19QS0dfVEVYVF0sIFtB bHRlcm5hdGl2ZWx5LCB5b3UgbWF5IHNldCB0aGUgZW52aXJvbm1lbnQgdmFyaWFibGVzICQxW11f Q0ZMQUdTCiBhbmQgJDFbXV9MSUJTIHRvIGF2b2lkIHRoZSBuZWVkIHRvIGNhbGwgcGtnLWNvbmZp Zy4KIFNlZSB0aGUgcGtnLWNvbmZpZyBtYW4gcGFnZSBmb3IgbW9yZSBkZXRhaWxzLl0pCmRpZmYg LS1naXQgYS9nZGIvY29uZmlndXJlIGIvZ2RiL2NvbmZpZ3VyZQppbmRleCBhZGNmYTQ5YzYzLi5l YjM4YWFhY2ZjIDEwMDc1NQotLS0gYS9nZGIvY29uZmlndXJlCisrKyBiL2dkYi9jb25maWd1cmUK QEAgLTcwMzcsNiArNzAzNywyOCBAQCBmaQogICAgIHBrZ19mYWlsZWQ9dW50cmllZAogZmkKIAor cGtnX3NhdmVfTERGTEFHUz0iJExERkxBR1MiCitMREZMQUdTPSIkTERGTEFHUyAkcGtnX2N2X0RF QlVHSU5GT0RfTElCUyIKK2NhdCBjb25mZGVmcy5oIC0gPDxfQUNFT0YgPmNvbmZ0ZXN0LiRhY19l eHQKKy8qIGVuZCBjb25mZGVmcy5oLiAgKi8KKworaW50CittYWluICgpCit7CityZXR1cm4gMDsK KyAgOworICByZXR1cm4gMDsKK30KK19BQ0VPRgoraWYgYWNfZm5fY190cnlfbGluayAiJExJTkVO TyI7IHRoZW4gOgorICBwa2dfZmFpbGVkPW5vCitlbHNlCisgIHBrZ19mYWlsZWQ9eWVzCitmaQor cm0gLWYgY29yZSBjb25mdGVzdC5lcnIgY29uZnRlc3QuJGFjX29iamV4dCBcCisgICAgY29uZnRl c3QkYWNfZXhlZXh0IGNvbmZ0ZXN0LiRhY19leHQKK0xERkxBR1M9JHBrZ19zYXZlX0xERkxBR1MK KwogCiAKIGlmIHRlc3QgJHBrZ19mYWlsZWQgPSB5ZXM7IHRoZW4KLS0gCjIuMjYuMgoK --000000000000c9376805ab7162c0--