From: "H.J. Lu" <hjl.tools@gmail.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Alex Lindsay <alexlindsay239@gmail.com>,
GDB <gdb-patches@sourceware.org>
Subject: Re: Synthetic symbol leak in in elf_x86_64_get_synthetic_symtab and elf_read_minimal_symbols
Date: Fri, 11 Aug 2017 16:44:00 -0000 [thread overview]
Message-ID: <CAMe9rOrGJ0z69+ZZxCuntx6DVpitoS8kdbOdDhPra=3eEACHNA@mail.gmail.com> (raw)
In-Reply-To: <20170811154542.GK8039@1170ee0b50d5>
On Fri, Aug 11, 2017 at 8:45 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On 17-08-11 08:30:21, H.J. Lu wrote:
>> >
>> > We can only safely do this, but .name is leaked for x86_64. Other
>> > tools using bfd, like objdump, nm, and gprof may have this issue too.
>> > I'll ask binutils people on asymbol allocation and de-allocation.
>> >
>>
>> This is:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=21943
>>
>
> I opened it :)
>
>> i386 and x86-64 get_synthetic_symtab don't know if @plt should
>> be added to symbol name for a PLT entry. The first pass checks
>> if @plt is needed and extra space is allocated in the second pass.
>> We can assume @plt is needed and waste some space if it isn't.
>
> Do you plan to fix it?
>
Done.
--
H.J.
next prev parent reply other threads:[~2017-08-11 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 15:19 Alex Lindsay
2017-08-11 9:27 ` Yao Qi
2017-08-11 15:07 ` Alex Lindsay
2017-08-11 15:31 ` H.J. Lu
2017-08-11 15:46 ` Yao Qi
2017-08-11 16:44 ` H.J. Lu [this message]
2017-08-11 21:20 ` Alex Lindsay
2017-08-17 11:00 ` Yao Qi
2017-08-17 12:31 ` Philippe Waroquiers
2017-08-17 17:42 ` Pedro Alves
2017-08-17 22:32 ` [PATCH] Plug line_header leaks (Re: Synthetic symbol leak in in elf_x86_64_get_synthetic_symtab and elf_read_minimal_symbols) Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrGJ0z69+ZZxCuntx6DVpitoS8kdbOdDhPra=3eEACHNA@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=alexlindsay239@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox