From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91013-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2024 invoked by alias); 11 May 2012 20:56:50 -0000
Received: (qmail 2015 invoked by uid 22791); 11 May 2012 20:56:50 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-qa0-f41.google.com (HELO mail-qa0-f41.google.com) (209.85.216.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 20:56:37 +0000
Received: by qabg27 with SMTP id g27so1927385qab.0        for <gdb-patches@sourceware.org>; Fri, 11 May 2012 13:56:36 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.136.208 with SMTP id s16mr4916041qct.50.1336769796611; Fri, 11 May 2012 13:56:36 -0700 (PDT)
Received: by 10.229.169.130 with HTTP; Fri, 11 May 2012 13:56:36 -0700 (PDT)
In-Reply-To: <201205112031.q4BKV2s4004871@glazunov.sibelius.xs4all.nl>
References: <20120511192949.GA5070@intel.com>	<201205112031.q4BKV2s4004871@glazunov.sibelius.xs4all.nl>
Date: Fri, 11 May 2012 20:56:00 -0000
Message-ID: <CAMe9rOqwRcAUzBX4tinxMxNRAfqnyHBt+w0Yp1La_49+SWc_VQ@mail.gmail.com>
Subject: Re: PATCH: Check bfd_mach_x64_32 to set tdesc for x32 binary
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00455.txt.bz2

On Fri, May 11, 2012 at 1:31 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wr=
ote:
>> Date: Fri, 11 May 2012 12:29:49 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> This patch checks bfd_mach_x64_32 to set tdesc for x32 binary. =A0Tested
>> on Linux/x86-64. =A0OK to install?
>>
>> Thanks.
>>
>> =A0 =A0 =A0 * amd64-linux-tdep.h (tdesc_x32_linux): New.
>> =A0 =A0 =A0 (tdesc_x32_avx_linux): Likewise.
>
> You should commit this bit seperately.
>
>> diff --git a/gdb/amd64-linux-tdep.h b/gdb/amd64-linux-tdep.h
>> index 0338b6e..49bb95e 100644
>> --- a/gdb/amd64-linux-tdep.h
>> +++ b/gdb/amd64-linux-tdep.h
>> @@ -34,6 +34,8 @@
>> =A0/* Linux target description. =A0*/
>> =A0extern struct target_desc *tdesc_amd64_linux;
>> =A0extern struct target_desc *tdesc_amd64_avx_linux;
>> +extern struct target_desc *tdesc_x32_linux;
>> +extern struct target_desc *tdesc_x32_avx_linux;
>>
>> =A0/* Enum that defines the syscall identifiers for amd64 linux.
>> =A0 =A0 Used for process record/replay, these will be translated into
>>

I will do that.  Thanks.

--=20
H.J.