From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121479-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16646 invoked by alias); 1 Apr 2015 17:17:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16616 invoked by uid 89); 1 Apr 2015 17:17:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mail-ob0-f177.google.com
Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 01 Apr 2015 17:17:01 +0000
Received: by obvd1 with SMTP id d1so90065675obv.0;        Wed, 01 Apr 2015 10:16:59 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.60.51.6 with SMTP id g6mr8144137oeo.45.1427908619148; Wed, 01 Apr 2015 10:16:59 -0700 (PDT)
Received: by 10.76.54.14 with HTTP; Wed, 1 Apr 2015 10:16:59 -0700 (PDT)
In-Reply-To: <20150401165431.GL25224@vapier>
References: <CAMe9rOpDXyqznHsk_kTBqRtTFXogWNrNK40jJ5WmiA30=ZYyCg@mail.gmail.com>	<20150401165431.GL25224@vapier>
Date: Wed, 01 Apr 2015 17:17:00 -0000
Message-ID: <CAMe9rOqk16YR=zF5pwLKMygRLcrWTbdAwuZhy7gc3zvWUCGy8w@mail.gmail.com>
Subject: Re: PATCH: Update --with-system-zlib
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Binutils <binutils@sourceware.org>, GDB <gdb-patches@sourceware.org>, 	GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00067.txt.bz2

On Wed, Apr 1, 2015 at 9:54 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 01 Apr 2015 05:04, H.J. Lu wrote:
>> --- a/config/zlib.m4
>> +++ b/config/zlib.m4
>> @@ -9,8 +9,10 @@ AC_DEFUN([AM_ZLIB],
>>    zlibinc="-I\$(srcdir)/../zlib"
>>    AC_ARG_WITH(system-zlib,
>>    [AS_HELP_STRING([--with-system-zlib], [use installed libz])],
>> -  zlibdir=
>> -  zlibinc=
>> +  if test x$with_system_zlib = xyes ; then
>> +    zlibdir=
>> +    zlibinc=
>> +  fi
>>    )
>
> this is inside the 3rd arg, so normally you check $withval.  this code will
> still work as the generated shell does:
> if test "${with_system_zlib+set}" = set; then :
>   withval=$with_system_zlib; [3rd arg content]
> fi
>
>>  bfd/ChangeLog      | 4 ++++
>>  bfd/configure      | 6 ++++--
>>  binutils/ChangeLog | 4 ++++
>>  binutils/configure | 6 ++++--
>>  gas/ChangeLog      | 4 ++++
>>  gas/configure      | 6 ++++--
>>  gdb/ChangeLog      | 4 ++++
>>  gdb/configure      | 6 ++++--
>
> you need to regenerate the sim tree too
> -mike

I pushed it onto maser.

-- 
H.J.