From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Add sp_regnum_from_eax and pc_regnum_from_eax
Date: Tue, 03 Jul 2012 15:54:00 -0000 [thread overview]
Message-ID: <CAMe9rOqjtXg7YbcfpOrv0yx3_whAEubDLAKmb93yH3ehfaGb8Q@mail.gmail.com> (raw)
In-Reply-To: <201207031408.q63E8DbR009742@glazunov.sibelius.xs4all.nl>
On Tue, Jul 3, 2012 at 7:08 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Thu, 21 Jun 2012 11:14:52 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> Hi,
>>
>> Here are the first of the last 3 patches for x32 support in GDB. This
>> patch maps $pc to $eip and $sp to $esp for x32. OK to install?
>
> The pseudo register handling code is getting too complex :(. I feel
> that hiding the set_gdbarch_pc_regnum() and set_gdbarch_sp_regnum()
> calls in i386-tdep.c isn't the right approach. But I haven't found a
> better one yet :(.
>
One possibility is to set pc/sp to register name instead of regnum.
i386_gdbarch_init can map them to regnum after all pseudo registers
are finalized.
--
H.J.
next prev parent reply other threads:[~2012-07-03 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 18:15 H.J. Lu
2012-07-03 14:08 ` Mark Kettenis
2012-07-03 15:54 ` H.J. Lu [this message]
2012-07-03 17:35 ` H.J. Lu
2012-07-03 19:15 ` H.J. Lu
2012-07-03 23:56 ` H.J. Lu
2012-07-04 19:53 ` Mark Kettenis
2012-07-04 20:51 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqjtXg7YbcfpOrv0yx3_whAEubDLAKmb93yH3ehfaGb8Q@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox