From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95365-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20964 invoked by alias); 21 Oct 2012 02:06:13 -0000
Received: (qmail 20943 invoked by uid 22791); 21 Oct 2012 02:06:10 -0000
X-SWARE-Spam-Status: No, hits=-3.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 21 Oct 2012 02:06:05 +0000
Received: by mail-vc0-f169.google.com with SMTP id fl17so2164914vcb.0        for <gdb-patches@sourceware.org>; Sat, 20 Oct 2012 19:06:05 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.52.35.171 with SMTP id i11mr6511588vdj.14.1350785164833; Sat, 20 Oct 2012 19:06:04 -0700 (PDT)
Received: by 10.58.146.138 with HTTP; Sat, 20 Oct 2012 19:06:04 -0700 (PDT)
In-Reply-To: <20121021015636.GD3050@adacore.com>
References: <20121020234741.GA3626@gmail.com>	<20121021015636.GD3050@adacore.com>
Date: Sun, 21 Oct 2012 02:06:00 -0000
Message-ID: <CAMe9rOqXUa6xUS9a=RCrEu5S04VN6Y-zjKMUJ8SnUi5mt9-cEg@mail.gmail.com>
Subject: Re: [7.5] PATCH: PR backtrace/14646 [x32] backtrace doesn't work
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-10/txt/msg00373.txt.bz2

On Sat, Oct 20, 2012 at 6:56 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> This patch backports the fix from trunk to 7.5 branch.  Tested on
>> Linux/x86-64 and Linux/x32.  OK to install?
> [...]
>>       PR backtrace/14646
>>       PR gdb/14647
>>       * i386-tdep.h (gdbarch_tdep): Remove sp_regnum_from_eax and
>>       pc_regnum_from_eax.
>>       * i386-tdep.c (i386_gdbarch_init): Don't use sp_regnum_from_eax
>>       nor pc_regnum_from_eax.
>>       * amd64-tdep.c (amd64_x32_init_abi): Don't set sp_regnum_from_eax
>>       nor pc_regnum_from_eax.
>
> I'm sorry to say that I am not comfortable at all with this going
> in the 7.5 branch. If Mark is super confident, then OK, but this is
> touching sp/pc handling for all x86 and x86-64 targets. And I don't
> think that the issue this patch is fixing is that critical.
>

This patch reverts the changed made on 7.5 branch, which
brings 7.5 branch back to 7.4 branch.  It should be 100% safe.

-- 
H.J.