From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12682 invoked by alias); 20 Jul 2012 14:01:02 -0000 Received: (qmail 12648 invoked by uid 22791); 20 Jul 2012 14:00:59 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Jul 2012 14:00:45 +0000 Received: by vbkv13 with SMTP id v13so3631319vbk.0 for ; Fri, 20 Jul 2012 07:00:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.221.131 with SMTP id ic3mr4511575vcb.46.1342792844692; Fri, 20 Jul 2012 07:00:44 -0700 (PDT) Received: by 10.58.179.79 with HTTP; Fri, 20 Jul 2012 07:00:44 -0700 (PDT) In-Reply-To: <20120601182135.GA8348@host2.jankratochvil.net> References: <20120518211410.GA32107@host2.jankratochvil.net> <87396fqaf4.fsf@fleche.redhat.com> <20120601182135.GA8348@host2.jankratochvil.net> Date: Fri, 20 Jul 2012 14:01:00 -0000 Message-ID: Subject: Re: [gdb commit] [RFC patch] non-release srctrees: --enable-targets=all & 64bit & -lmcheck From: "H.J. Lu" To: Jan Kratochvil Cc: Tom Tromey , gdb-patches@sourceware.org, binutils@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00390.txt.bz2 On Fri, Jun 1, 2012 at 11:21 AM, Jan Kratochvil wrote: > On Fri, 01 Jun 2012 18:11:43 +0200, Tom Tromey wrote: >> >>>>> "Jan" == Jan Kratochvil writes: >> Jan> -lmcheck is cheap enough to never be noticed and it also finds checked in >> Jan> regressions: >> >> I'm in favor of this part. Could you separate out just the gdb part and >> put it in? > > Checked in only the gdb/ part. > > > Thanks, > Jan > > > http://sourceware.org/ml/gdb-cvs/2012-06/msg00005.html > > --- src/gdb/ChangeLog 2012/06/01 16:37:56 1.14309 > +++ src/gdb/ChangeLog 2012/06/01 18:20:16 1.14310 > @@ -1,3 +1,11 @@ > +2012-06-01 Jan Kratochvil > + > + * configure.ac (development): Define new variable. > + Call AC_CHECK_LIB for mcheck if $development. > + (ERROR_ON_WARNING): Enable it by default only if $development. > + * config.in: Regenerate. > + * configure: Regenerate. > + > 2012-06-01 Siddhesh Poyarekar > > * target.c (target_read_memory): Make LEN argument as size_t. > --- src/gdb/config.in 2012/05/11 18:20:26 1.143 > +++ src/gdb/config.in 2012/06/01 18:20:18 1.144 > --- src/gdb/configure 2012/05/20 20:35:18 1.365 > +++ src/gdb/configure 2012/06/01 18:20:18 1.366 > --- src/gdb/configure.ac 2012/05/20 20:35:19 1.176 > +++ src/gdb/configure.ac 2012/06/01 18:20:18 1.177 > @@ -18,6 +18,11 @@ > > dnl Process this file with autoconf to produce a configure script. > > +dnl Provide more thorough testing by -lmcheck. > +dnl Set it to 'true' for development snapshots, 'false' for releases or > +dnl pre-releases. > +development=true > + > AC_PREREQ(2.59)dnl > AC_INIT(main.c) > AC_CONFIG_HEADER(config.h:config.in) > @@ -640,6 +645,11 @@ > AC_SUBST(READLINE_CFLAGS) > AC_SUBST(READLINE_TEXI_INCFLAG) > > +dnl -lmcheck provides cheap enough memory mangling for debugging purposes. > +if $development; then > + AC_CHECK_LIB(mcheck, main) > +fi > + > # Generate jit-reader.h > > # This is typedeffed to GDB_CORE_ADDR in jit-reader.h > @@ -1822,8 +1832,8 @@ > *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;; > esac]) > > -# Enable -Werror by default when using gcc > -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then > +# Enable -Werror by default when using gcc. Turn it off for releases. > +if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" && $development; then > ERROR_ON_WARNING=yes > fi > This caused: http://sourceware.org/bugzilla/show_bug.cgi?id=14377 -- H.J.