From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31692 invoked by alias); 26 Aug 2011 13:48:51 -0000 Received: (qmail 31683 invoked by uid 22791); 26 Aug 2011 13:48:50 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 13:48:34 +0000 Received: by qwd6 with SMTP id 6so2468719qwd.0 for ; Fri, 26 Aug 2011 06:48:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.45.20 with SMTP id c20mr1509876qcf.224.1314366513166; Fri, 26 Aug 2011 06:48:33 -0700 (PDT) Received: by 10.229.29.7 with HTTP; Fri, 26 Aug 2011 06:48:33 -0700 (PDT) In-Reply-To: <20110826092539.GA23720@host1.jankratochvil.net> References: <20110826092539.GA23720@host1.jankratochvil.net> Date: Fri, 26 Aug 2011 13:48:00 -0000 Message-ID: Subject: Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target From: "H.J. Lu" To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00491.txt.bz2 On Fri, Aug 26, 2011 at 2:25 AM, Jan Kratochvil wrote: > Hi, > > checked in as obvious. > > There are always these FAILs in all the cases, I did not investigate them= more. > FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argc > FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argi > FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argf > FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argd > FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argarray > > Tested on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu. > > > Thanks, > Jan > > > http://sourceware.org/ml/gdb-cvs/2011-08/msg00111.html > > --- src/gdb/testsuite/ChangeLog 2011/08/18 16:19:00 =A0 =A0 1.2837 > +++ src/gdb/testsuite/ChangeLog 2011/08/26 09:20:43 =A0 =A0 1.2838 > @@ -1,3 +1,11 @@ > +2011-08-26 =A0Jan Kratochvil =A0 > + > + =A0 =A0 =A0 * gdb.trace/backtrace.exp: Use is_lp64_target to check 64bi= t target. > + =A0 =A0 =A0 * gdb.trace/collection.exp: Likewise. > + =A0 =A0 =A0 * gdb.trace/report.exp: Likewise. > + =A0 =A0 =A0 * gdb.trace/unavailable.exp: Likewise. > + =A0 =A0 =A0 * gdb.trace/while-dyn.exp: Likewise. > + > =A02011-08-18 =A0Keith Seitz =A0 > > =A0 =A0 =A0 =A0PR c++/12266 > --- src/gdb/testsuite/gdb.trace/backtrace.exp =A0 2011/01/01 15:33:50 =A0= =A0 1.18 > +++ src/gdb/testsuite/gdb.trace/backtrace.exp =A0 2011/08/26 09:20:44 =A0= =A0 1.19 > @@ -150,10 +150,10 @@ > =A0 =A0 =A0 =A0"$tdp4" \ > =A0 =A0 =A0 =A0"collect \$regs, \$args, \$locs" "^$" > > -if [istarget "x86_64-*"] then { > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} = then { > =A0 =A0 set fpreg "\$rbp" > =A0 =A0 set spreg "\$rsp" > -} elseif [istarget "i?86-*"] then { > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { > =A0 =A0 set fpreg "\$ebp" > =A0 =A0 set spreg "\$esp" > =A0} else { > --- src/gdb/testsuite/gdb.trace/collection.exp =A02011/02/16 18:07:58 =A0= =A0 1.24 > +++ src/gdb/testsuite/gdb.trace/collection.exp =A02011/08/26 09:20:44 =A0= =A0 1.25 > @@ -45,11 +45,11 @@ > =A0set ws "\[\r\n\t \]+" > =A0set cr "\[\r\n\]+" > > -if [istarget "x86_64-*"] then { > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} = then { > =A0 =A0 set fpreg "rbp" > =A0 =A0 set spreg "rsp" > =A0 =A0 set pcreg "rip" > -} elseif [istarget "i?86-*"] then { > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { > =A0 =A0 set fpreg "ebp" > =A0 =A0 set spreg "esp" > =A0 =A0 set pcreg "eip" > --- src/gdb/testsuite/gdb.trace/report.exp =A0 =A0 =A02011/03/07 20:25:57= =A0 =A0 1.19 > +++ src/gdb/testsuite/gdb.trace/report.exp =A0 =A0 =A02011/08/26 09:20:44= =A0 =A0 1.20 > @@ -159,11 +159,11 @@ > =A0 =A0 =A0 =A0"$tdp4" \ > =A0 =A0 =A0 =A0"collect \$locs" "^$" > > -if [istarget "x86_64-*"] then { > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} = then { > =A0 =A0 set fpreg "rbp" > =A0 =A0 set spreg "rsp" > =A0 =A0 set pcreg "rip" > -} elseif [istarget "i?86-*"] then { > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { > =A0 =A0 set fpreg "ebp" > =A0 =A0 set spreg "esp" > =A0 =A0 set pcreg "eip" > --- src/gdb/testsuite/gdb.trace/unavailable.exp 2011/08/05 15:17:59 =A0 = =A0 1.9 > +++ src/gdb/testsuite/gdb.trace/unavailable.exp 2011/08/26 09:20:44 =A0 = =A0 1.10 > @@ -30,11 +30,11 @@ > =A0set ws "\[\r\n\t \]+" > =A0set cr "\[\r\n\]+" > > -if [istarget "x86_64-*"] then { > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} = then { > =A0 =A0 set fpreg "rbp" > =A0 =A0 set spreg "rsp" > =A0 =A0 set pcreg "rip" > -} elseif [istarget "i?86-*"] then { > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { > =A0 =A0 set fpreg "ebp" > =A0 =A0 set spreg "esp" > =A0 =A0 set pcreg "eip" > @@ -295,12 +295,12 @@ > > =A0 =A0 # Test reading uncollected pseudo-registers. =A0The set of which > =A0 =A0 # depends on target. > - =A0 =A0if [istarget "x86_64-*"] then { > + =A0 =A0if {$pcreg =3D=3D "rip"} then { > =A0 =A0 =A0 =A0# Check the raw register first. > =A0 =A0 =A0 =A0test_register_unavailable "\$rax" > =A0 =A0 =A0 =A0test_register_unavailable "\$eax" > =A0 =A0 =A0 =A0test_register_unavailable "\$ax" > - =A0 =A0} elseif [istarget "i?86-*"] then { > + =A0 =A0} elseif {$pcreg =3D=3D "eip"} then { > =A0 =A0 =A0 =A0# Check the raw register first. > =A0 =A0 =A0 =A0test_register_unavailable "\$eax" > =A0 =A0 =A0 =A0test_register_unavailable "\$ax" > --- src/gdb/testsuite/gdb.trace/while-dyn.exp =A0 2011/01/01 15:33:50 =A0= =A0 1.18 > +++ src/gdb/testsuite/gdb.trace/while-dyn.exp =A0 2011/08/26 09:20:44 =A0= =A0 1.19 > @@ -52,9 +52,9 @@ > =A0# test while-stepping dynamically (live target) > =A0# > > -if [istarget "x86_64-*"] then { > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} = then { > =A0 =A0 set fpreg "\$rbp" > -} elseif [istarget "i?86-*"] then { > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { > =A0 =A0 set fpreg "\$ebp" > =A0} else { > =A0 =A0 set fpreg "\$fp" > That is wrong for x32. X32 isn't LP64, but has 64bit registers. --=20 H.J.