From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by sourceware.org (Postfix) with ESMTPS id AD99F3851C36; Tue, 28 Jul 2020 17:27:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD99F3851C36 Received: by mail-io1-xd44.google.com with SMTP id j8so9236810ioe.9; Tue, 28 Jul 2020 10:27:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v29mhj2uL9RmI3+Qhy/eLz1mjHb5Wyt7g2HflzBD8yg=; b=RbZQy7WXHKzZsnf8MebQ0Pt7bqzQCkQClFyYcUL3NshDadJJHYPE9mBsnAbqY0t5gk 8ov3g4BbQQZtqP9vZW/ZsWjL2lZUhLb8hdU2GgYRGXn2Bh0ICiwLnLe0+HQ5GQR1YI9v g/ZBTGDjckV2zc59YWDo+wdgcQsBgQDwuRLG7excoiSOEDYrr0qAaHgQMP0mrhK/0PVU QLzAKFfgfbzXb+2qK58bYi6bL9xTtVtZWnP83pzW8XVzwFOFW3peQmuMnZrI+RE85ZHd rPItmXNKnPSLvvawrNmbDmAfO12uOqWx3BF0xeULEvoH158103RBnfaAxUuEmpX71lsF 2LBw== X-Gm-Message-State: AOAM531win5gCKh7op6c+0dtRyjLlLNsdEyUrnmIGMj2RfXMhLpLc5Gd CmOqgMDC/PQzlhzIqg5LKLAd09WFdRAHy5A+VjQ= X-Google-Smtp-Source: ABdhPJyk55n8dF0ciXvFkV8+7a89EsDHVVal00btdWJDIzcuDho/rjeONL/RISEMq4trqGkkfvSv7KCgTUFtlyTmKJc= X-Received: by 2002:a5d:8552:: with SMTP id b18mr29925574ios.28.1595957237059; Tue, 28 Jul 2020 10:27:17 -0700 (PDT) MIME-Version: 1.0 References: <20200502022903.175852-1-amerey@redhat.com> <996bd0f9-cec5-119c-19ea-b127cf1bb95d@simark.ca> <87r1svyche.fsf@igel.home> <3209078a-429a-4be7-b151-93c3f4a53655@simark.ca> In-Reply-To: From: "H.J. Lu" Date: Tue, 28 Jul 2020 10:26:41 -0700 Message-ID: Subject: Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works To: Simon Marchi Cc: Andreas Schwab , "H.J. Lu via Binutils" , Aaron Merey , GCC Patches , Tom Tromey , GDB Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 17:27:18 -0000 On Tue, Jul 28, 2020 at 9:28 AM Simon Marchi wrote: > > On 2020-07-28 12:07 p.m., H.J. Lu via Gdb-patches wrote: > > What doesn't work with my pkg.m4 change? > > (1) It deviates from upstream. I don't think we should do this unless > absolutely needed. That's not the case here, the change is just there > because you don't want to set up pkg-config properly for cross-compiling. Since when binutils can't fix issues in other packages? > (2) I don't think it's necessarily bad to try to do a link to confirm the lib > is indeed there, but as I said earlier I don't think that doing as if the > package was not there is the right response. This can happen if you have > a mis-configured pkg-config (like you have) or a broken installation (for > example, the .pc is there but the lib is not). In either case, there's > something wrong with the build environment and I think it's more useful > to abort and tell the user rather than silently failing. > > Point 2 should be discussed upstream anyway, there's no point making a decision > local to binutils-gdb. > Unlike gdb, binutils should have as few external depecies as possible. debuginfod brings in some so many external depecies. -- H.J.