From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by sourceware.org (Postfix) with ESMTPS id 89415385E83A; Tue, 28 Jul 2020 18:31:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 89415385E83A Received: by mail-io1-xd41.google.com with SMTP id v6so6571827iow.11; Tue, 28 Jul 2020 11:31:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PV29NeFHUHZks/C7J8KdAvPfTJnM7vuSgX7uQZH8x+c=; b=jYKVhpoN4HHbOZTwZiPdv4VN3D+gpowFcNZ+UjbpJGd1r7FprggzlmZXKs7vxCr/Hw poi5S4Jp2fy9fgEbRyBOd6mB/HhjzVttX/mO3b0zQGfyHt9TunjsjMztYC76YXqs6E0G TQdKbn5oj8nCwp0eRBIWYu1EpM5diXrW+thO2pAZA3E3PlZ9IcGEBqzpYeGzuYAV0SGg F+BDN2LzJcGwhOoJgUMZK5a7T14FweB0nQtCG0Stp9XNoYE9B8M9ODGEXuCKx1wwp5gS aYah0tL9aCUW7+7tZUYRA5MuDWzrIIMHMMk14CHbn7/Jsi40kyknTr7owic0hBJyrT4Q R4iA== X-Gm-Message-State: AOAM531QN8JzOOyIey23GMz+Byd9DVQfr9rX1LirM2VQ24K3qpkCGo7t UBJBHXyAsCgQUTU3iWodG8xmjhBI6CGiTwVMClO1dgCH X-Google-Smtp-Source: ABdhPJwn+TQjSN80MqmJ4A8L45lWeDvgsad1AWAJCzLhVk8KChmBRjYb67BwTwJg6fvOEbkDgsBzylg/CXm9xbnyeLI= X-Received: by 2002:a6b:bf85:: with SMTP id p127mr30365205iof.37.1595961118893; Tue, 28 Jul 2020 11:31:58 -0700 (PDT) MIME-Version: 1.0 References: <20200502022903.175852-1-amerey@redhat.com> <996bd0f9-cec5-119c-19ea-b127cf1bb95d@simark.ca> <87r1svyche.fsf@igel.home> <3209078a-429a-4be7-b151-93c3f4a53655@simark.ca> <0421b2c2-01b4-cf84-855f-24478ade0754@simark.ca> In-Reply-To: <0421b2c2-01b4-cf84-855f-24478ade0754@simark.ca> From: "H.J. Lu" Date: Tue, 28 Jul 2020 11:31:22 -0700 Message-ID: Subject: Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works To: Simon Marchi Cc: Andreas Schwab , "H.J. Lu via Binutils" , Aaron Merey , GCC Patches , Tom Tromey , GDB Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 18:32:00 -0000 On Tue, Jul 28, 2020 at 10:43 AM Simon Marchi wrote: > > On 2020-07-28 1:26 p.m., H.J. Lu wrote: > > On Tue, Jul 28, 2020 at 9:28 AM Simon Marchi wrote: > >> > >> On 2020-07-28 12:07 p.m., H.J. Lu via Gdb-patches wrote: > >>> What doesn't work with my pkg.m4 change? > >> > >> (1) It deviates from upstream. I don't think we should do this unless > >> absolutely needed. That's not the case here, the change is just there > >> because you don't want to set up pkg-config properly for cross-compiling. > > > > Since when binutils can't fix issues in other packages? > > Like I said, we can make local changes if necessary, to fix issues. But there is > no issue to fix here, all is needed is to have a proper build environment. > > Doing an unnecessary local change just adds burden on the next person who > will sync this file with upstream, so it should not be taken lightly. I have submitted a merge request to fix it upstream. > > Unlike gdb, binutils should have as few external depecies as possible. > > debuginfod brings in some so many external depecies. > > I'm not a binutils maintainer, so that's not my role to decide about that > tradeoff... but we are talking about having an optional (only needed when > enabling support for libdebuginfod) *build* dependency on a quite standard > tool. That's not very demanding. > > If you don't want to deal with libdebuginfod, you can also just build with > --without-debuginfod. My binutils script had been working fine until pkg.m4 was added. Can it be moved to gdb directory? -- H.J.