From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16089 invoked by alias); 4 Jun 2018 12:46:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14247 invoked by uid 89); 4 Jun 2018 12:46:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*amodra, H*f:sk:2478bde, H*i:sk:2478bde X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ot0-f196.google.com Received: from mail-ot0-f196.google.com (HELO mail-ot0-f196.google.com) (74.125.82.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Jun 2018 12:46:19 +0000 Received: by mail-ot0-f196.google.com with SMTP id 92-v6so2540624otw.9; Mon, 04 Jun 2018 05:46:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=viDOJV4+AB3BcqfOfKC1fQIeyoG8umRBq7eA4Cw8Etk=; b=sG4JMgiHMzgYABJjVWF4z9RViukbjIe6nU8CDb3qZS/THI6t6nfztsqmfdIKOL8jK7 0syDnYMmKPsGESolitcZKu0GA2OCGk2Mcv2qyrBifMJj+Y+eSm9RRLKf+82oGUPqz3MF ap2GiCV+TVloOsrDxM5Qu2kE93FSm3FSg8CCKNOvau4qgcmKi3jx8WVKTwypIdSOj987 imGWmNVwy2S23LP5/jHTHO2v1iq2tg/x3jNKUomsbEWz+7vnjshviu6cspYKLgAk07W9 NbGrKp+ROOsmRB9Wk6Os0IVToMXY9bMY1hpqJynsznc2vg4ASJQdvCxQ+PnITuEWIMSE rMkg== X-Gm-Message-State: ALKqPwcxrDIcWYv5sAUzrLGVSkH5iH+/Dh0Psy8IM1+V1Ka5fz+CDuSd ebMy8IQehcFB+zKImzMDxk/guLLEM1JzVjkCT1Y= X-Google-Smtp-Source: ADUXVKKx5QUce4VnfTbruk18zvlrqm5pEZwFpDCCjt3bgIVijtRO+W/qlwy7idOkxmIleu2SXVwSW5tjF+8zTnd4rVU= X-Received: by 2002:a9d:5508:: with SMTP id l8-v6mr13276751oth.159.1528116378007; Mon, 04 Jun 2018 05:46:18 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:7019:0:0:0:0:0 with HTTP; Mon, 4 Jun 2018 05:46:17 -0700 (PDT) In-Reply-To: <2478bdec-0e72-ac94-aa97-8004999feb6e@redhat.com> References: <20180521121557.16535-1-hjl.tools@gmail.com> <20180521121557.16535-2-hjl.tools@gmail.com> <20180601101949.GA7660@bubble.grove.modra.org> <0d2578f3-f6c0-d19f-d036-fd07d1ff03d0@redhat.com> <2478bdec-0e72-ac94-aa97-8004999feb6e@redhat.com> From: "H.J. Lu" Date: Mon, 04 Jun 2018 12:46:00 -0000 Message-ID: Subject: Re: [PATCH 2/3] Add DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION To: Pedro Alves Cc: Nick Clifton , Alan Modra , Binutils , GDB Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00055.txt.bz2 On Mon, Jun 4, 2018 at 5:19 AM, Pedro Alves wrote: > On 06/04/2018 01:13 PM, Nick Clifton wrote: >> Hi H.J. >> >>> +# if __GNUC__ == 8 && __GNUC_MINOR__ < 2 >>> +# define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION \ >>> + DIAGNOSTIC_IGNORE ("-Wstringop-truncation") >>> +# endif >>> >>> OK for master? >> >> Approved - please apply. > > Please don't. This is again going against the intention of > the header. The GCC version checks should be put in the > places where the warning needs to be suppressed. > The current patch makes all current and future uses of > DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION only apply to > GCC 8.1. That is incorrect. Consider what you will > have to do to suppress some -Wstrinop-truncation warning > with DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION on GCC 8.2 or > GCC 9 or whatever. This is what my original patch intended to do. But diagnostics.h from GDB doesn't support GCC version. Should I extend it to match glibc? > Also, you can use GCC_VERSION to make the version check > a little simpler. > > Thanks, > Pedro Alves -- H.J.