From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92695 invoked by alias); 31 Mar 2015 17:04:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92649 invoked by uid 89); 31 Mar 2015 17:04:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 31 Mar 2015 17:04:19 +0000 Received: by obbec2 with SMTP id ec2so36046328obb.3; Tue, 31 Mar 2015 10:04:18 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.158.73 with SMTP id ws9mr34694775oeb.24.1427821444860; Tue, 31 Mar 2015 10:04:04 -0700 (PDT) Received: by 10.76.134.102 with HTTP; Tue, 31 Mar 2015 10:04:04 -0700 (PDT) In-Reply-To: <20150331170122.GJ25224@vapier> References: <20150326155711.GA10088@gmail.com> <20150331061337.GA30996@vapier> <20150331164107.GI25224@vapier> <20150331170122.GJ25224@vapier> Date: Tue, 31 Mar 2015 17:04:00 -0000 Message-ID: Subject: Re: [PATCH 1/8] Add --with-system-zlib in bfd From: "H.J. Lu" To: Binutils , GDB Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01060.txt.bz2 On Tue, Mar 31, 2015 at 10:01 AM, Mike Frysinger wrote: > On 31 Mar 2015 09:56, H.J. Lu wrote: >> On Tue, Mar 31, 2015 at 9:41 AM, Mike Frysinger wrote: >> > On 31 Mar 2015 03:10, H.J. Lu wrote: >> >> On Mon, Mar 30, 2015 at 11:13 PM, Mike Frysinger wrote: >> >> > On 26 Mar 2015 08:57, H.J. Lu wrote: >> >> >> --- a/bfd/configure.ac >> >> >> +++ b/bfd/configure.ac >> >> >> >> >> >> -# Link in zlib if we can. This allows us to read compressed debug sections. >> >> >> -# This is used only by compress.c. >> >> >> -AM_ZLIB >> >> >> +# Use the system's zlib library. >> >> >> +zlibdir=-L../zlib >> >> >> +zlibinc="-I\$(srcdir)/../zlib" >> >> >> +AC_ARG_WITH(system-zlib, >> >> >> +[AS_HELP_STRING([--with-system-zlib], [use installed libz])], >> >> >> +zlibdir= >> >> >> +zlibinc= >> >> >> +) >> >> > >> >> > this is wrong. the 3rd arg is whether the option was specified, not that the >> >> > option was disabled. you need to check $withval is equal to "no" (or not equal >> >> > to "yes"). >> >> >> >> That is what gcc/configure.ac has and it works for me. >> > >> > then gcc/configure.ac is also broken. whether "it works for me" is >> > irrelevant -- simply read the code and you'll see it's wrong. if you >> > pass --without-system-zlib the code wrongly behaves as if you passed >> > --with-system-zlib. >> > >> > i mention this because it is breaking my test builds. not that that >> > really matters -- the code is clearly incorrect. >> >> We should fix zlib.m4 and use it in gcc/configure.ac. > > sure; i await your patches ;). i'm not trying to point fingers here for > pointing's sake -- binutils & gdb were working before and now they're broken, > and they broke due to the zlib patches you merged. so i think it's reasonable > to expect you to drive further fixes (probably across gcc) even though the bug > has existed in gcc for sometime. Sure. I have put it in my queue. Sorry for the inconvenience. -- H.J.