Re: PATCH: Also check for `movl %esp, %ebp' for x32

H.J. Lu
2012-04-29T18:38:14Z

On Tue, Apr 24, 2012 at 9:27 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Apr 17, 2012 at 7:30 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Apr 17, 2012 at 4:43 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>>>> Date: Tue, 10 Apr 2012 13:29:53 -0700
>>>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>>>
>>>> Hi,
>>>>
>>>> X32 may use `movl %esp, %ebp' in prologue.  This patch checks it for
>>>> x32.  Tested on Linux/x86-64.  OK for trunk?
>>>
>>> Sorry, but I'm not sure it is a good idea to mix ABIs in the code like
>>> that.  Up until now, I've made a conscious attempt to keep the i386
>>> and amd64 ABIs seperated out as much as possible.  Can you post a
>>> complete diff of the -tdep.c related changes to support x32 in GDB,
>>> such that I can judge where this is heading?
>>
>> Here is the complete x32 GDB patch:
>>
>> http://sourceware.org/ml/gdb-patches/2012-04/msg00476.html
>>
>
> Hi Mark,
>
> Have you looked at my change?
>
> Thanks.

Ping.

--
H.J.