From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16343 invoked by alias); 26 Aug 2011 15:59:15 -0000 Received: (qmail 16335 invoked by uid 22791); 26 Aug 2011 15:59:14 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qy0-f169.google.com (HELO mail-qy0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 15:59:00 +0000 Received: by qyk27 with SMTP id 27so551508qyk.0 for ; Fri, 26 Aug 2011 08:59:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.189.149 with SMTP id de21mr1729417qcb.72.1314374339778; Fri, 26 Aug 2011 08:58:59 -0700 (PDT) Received: by 10.229.29.7 with HTTP; Fri, 26 Aug 2011 08:58:59 -0700 (PDT) In-Reply-To: <20110826153716.GA14293@host1.jankratochvil.net> References: <20110826092539.GA23720@host1.jankratochvil.net> <20110826153716.GA14293@host1.jankratochvil.net> Date: Fri, 26 Aug 2011 15:59:00 -0000 Message-ID: Subject: Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target From: "H.J. Lu" To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00496.txt.bz2 On Fri, Aug 26, 2011 at 8:37 AM, Jan Kratochvil wrote: > On Fri, 26 Aug 2011 15:48:33 +0200, H.J. Lu wrote: >> On Fri, Aug 26, 2011 at 2:25 AM, Jan Kratochvil wrote: >> > -if [istarget "x86_64-*"] then { >> > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target= ]} then { >> > =A0 =A0 set fpreg "\$rbp" >> > -} elseif [istarget "i?86-*"] then { >> > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { >> > =A0 =A0 set fpreg "\$ebp" >> > =A0} else { >> > =A0 =A0 set fpreg "\$fp" >> > >> >> That is wrong for x32. X32 isn't LP64, but has 64bit registers. > > I agree. =A0I tried to fix all the [is_lp64_target] vs. ![is_ilp32_target= ] cases > for x86* in the testsuite but I am not sure how x32* behaves, do you have > some qemu/kvm image with x32* toolchain? =A0I could not fina any on: > =A0 =A0 =A0 =A0http://sites.google.com/site/x32abi/ > If you use Fedora 15, you can add x32 yum repository: http://www.kernel.org/pub/linux/libs/glibc/hjl/x32/fedora/15/x86_64/ and install x32 kernel/glibc rpms. Then you can enable x32 on GCC trunk. BTW, I will upload x32 GCC binary for Fedora 15 to http://www.kernel.org/pub/linux/libs/glibc/hjl/x32/fedora/15/gcc/ It may take a while. Thanks. --=20 H.J.