From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Alan Modra <amodra@gmail.com>, Binutils <binutils@sourceware.org>,
GDB <gdb-patches@sourceware.org>, Yao Qi <qiyaoltc@gmail.com>
Subject: Re: [PATCH] GDB/opcodes: Remove arch/mach/endian disassembler assertions
Date: Mon, 07 Aug 2017 15:05:00 -0000 [thread overview]
Message-ID: <CAMe9rOoCG+pJ2aBfoT3SyYNj2TgiBz7xOhmMBrGbhpnac++gQQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1708071556260.17596@tp.orcam.me.uk>
On Mon, Aug 7, 2017 at 7:56 AM, Maciej W. Rozycki <macro@imgtec.com> wrote:
> On Mon, 7 Aug 2017, Alan Modra wrote:
>
>> > gdb/
>> > * arch-utils.c (default_print_insn): Remove arch/mach/endian
>> > assertions.
>> >
>> > opcodes/
>> > * disassemble.c (disassembler): Remove arch/mach/endian
>> > assertions.
>>
>> This is OK, obvious really.
>
> Applied now, thanks for your review.
>
> Maciej
I am checking in:
diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c
index 0058354265..11206c67a5 100644
--- a/opcodes/disassemble.c
+++ b/opcodes/disassemble.c
@@ -110,7 +110,9 @@
#endif
disassembler_ftype
-disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach,
+disassembler (enum bfd_architecture a,
+ bfd_boolean big ATTRIBUTE_UNUSED,
+ unsigned long mach ATTRIBUTE_UNUSED,
bfd *abfd ATTRIBUTE_UNUSED)
{
disassembler_ftype disassemble;
to fix
/export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c: In
function ‘disassembler’:
/export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c:113:52:
error: unused parameter ‘big’ [-Werror=unused-parameter]
disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach,
^~~
/export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c:113:71:
error: unused parameter ‘mach’ [-Werror=unused-parameter]
disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach,
^~~~
cc1: all warnings being treated as errors
make[6]: *** [Makefile:1313: disassemble.lo] Error 1
on x86.
--
H.J.
next prev parent reply other threads:[~2017-08-07 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 16:39 Maciej W. Rozycki
2017-08-03 11:04 ` Yao Qi
2017-08-03 11:36 ` Maciej W. Rozycki
2017-08-03 12:25 ` Maciej W. Rozycki
2017-08-04 10:49 ` Yao Qi
2017-08-07 13:24 ` Alan Modra
2017-08-07 14:56 ` Maciej W. Rozycki
2017-08-07 15:05 ` H.J. Lu [this message]
2017-08-07 15:15 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoCG+pJ2aBfoT3SyYNj2TgiBz7xOhmMBrGbhpnac++gQQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@imgtec.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox