From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qFEGN/bYAmY55hYAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 10:17:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Wy24TNR3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DCAEE1E0C0; Tue, 26 Mar 2024 10:17:26 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C02911E030 for ; Tue, 26 Mar 2024 10:17:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A90C385840A for ; Tue, 26 Mar 2024 14:17:24 +0000 (GMT) Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by sourceware.org (Postfix) with ESMTPS id 706AD3858C56 for ; Tue, 26 Mar 2024 14:17:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 706AD3858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 706AD3858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711462626; cv=none; b=GObPPAXDh557oLAPxmoQcNQ2IumQE4Z7uB+GwulnzXJGA7A8BeJDOQWLREw30qiikAlfr1ocmLlkjS1s+t6q+ojzwTQ5baVp8lFZvZ46xduu3IK9mqnVHPaY0QVRuxy5ge7uYAHmsfpmDV4hE6lndO1sEqvDf3w3Ub9p0Fzc4Ng= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711462626; c=relaxed/simple; bh=AqGjb4dwterbvjkv6GNANP2k0Y+pgErK63JiM5z0jpI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=SPdjlA6iPOYfWHBoJSlNHx03IrvuP0A/a0c/wGmSYr165loQC/rfFFWKAGneyY3FX37fbTjcVHOsy+uw5eqr1SexuTXmuK2B5jlUbCy6lqLyELOPhpXOV1Yr8ajBd3Q+b3HBvMpRpfl36G2PHtJeJnaHDbWxgy/XEbRM2rBQaX4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-60a0599f631so49085437b3.2 for ; Tue, 26 Mar 2024 07:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711462623; x=1712067423; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x8ID6tfrvtr8fIh8l/QE0eJqVtLp7Zd6zZHoRPUvpjs=; b=Wy24TNR3XkBFvTyuBUCvh2ouVu2/mzbAqn9GfPByrkJsN5I0inNdd7IV7d7MLSC5B/ 8UGwEfxqw3mfPja/F2FpHxOlRE6O6vbE6w4I3zq5Z4XMHMdxEB7NO8hj93WN8+BQLSRf Dqhl4ijbSkCuSxpMc3kH8y97MxKhXvnFVdWw9Zz0+AT5dN8uokSfJXK/sjC0mOeccQTV h4Mwv2DcHtRsezopB7pknQqAirrvi8XJDuSjQpCKZC5eYmk9NYGEtXmuTHY4mqMJFQQi 5gZ2j/hbo7W2Xldw4F6rir5ObJOVWVX0tLbH54VNwXeWus2gRuH45pLlNVVVP9XpMEoq nzOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711462623; x=1712067423; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x8ID6tfrvtr8fIh8l/QE0eJqVtLp7Zd6zZHoRPUvpjs=; b=TqQ1fe/k5Cpmk9ThvbXKPo7uzFsVflX8AJ/kY1VFF07pqSmR1dljcSFtpwgmq2P+5P S2y6byzhtBvinTxN5k0oxM+cBch9Y6Ax4OCQIfk10l+27FenthWJz7CakLt0UCpWNTl+ EfxLyOwghE2CqbywgM148RiufhCotb7PX5rFCys4Qnsbpx/TRgYNoaM/0fSJQ7gLIQAv 0TLyVpSWEVLGMy2OB0AO7jK4ePteR3Mk7aLEW4BLnqBjVzFbekNJnBC8zLvd9xl/C44Z TmoYGdSXIUzhDGirPR8CdLnxV0FE7hArO1KEEtIsvgy/HssAU7ldybIjurKAc66+xyKy 5FPA== X-Forwarded-Encrypted: i=1; AJvYcCXt2Mnd9mUNcJYeeqs9+Zs3qclC4MGWIdOITg2YiKPBUDHo+Swe7XHO9o3w6fMxcvMSbZcB5T/EvuJAxZW9738fFKK1rm7oG67p/g== X-Gm-Message-State: AOJu0Yw6OsZPqipYF6W3FNVyDDD2UmBo94YFlaVlYtEfOcNxoPI5EsEf SSqazPzbo8VtD49enOOAILVWWp6aONJjxsVrqL+wB7BEp7BNK5DSgUhfA6Q3dFwIYjzXW5SwrFB FXvFu0+fa3oF1sj6tK7OW3LZIyRc= X-Google-Smtp-Source: AGHT+IFV1PS0sarOBb0EhplSXSu5jx8lKsaq0n7No1Sd+gtrryE3rUEwSiQoZZX9IakUPEiEfmXIUcL4A1dVMxPJRbY= X-Received: by 2002:a05:690c:3381:b0:611:5e14:8f1c with SMTP id fl1-20020a05690c338100b006115e148f1cmr6919223ywb.38.1711462622239; Tue, 26 Mar 2024 07:17:02 -0700 (PDT) MIME-Version: 1.0 References: <8734seteht.fsf@redhat.com> <413a66aa-e035-41cf-9af4-040685f89204@simark.ca> <87a5ml5gu8.fsf@redhat.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 26 Mar 2024 07:16:26 -0700 Message-ID: Subject: Re: [PATCHv3 0/8] x86/Linux Target Description Changes To: Andrew Burgess Cc: Simon Marchi , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Tue, Mar 26, 2024 at 6:51=E2=80=AFAM H.J. Lu wrote= : > > On Tue, Mar 26, 2024 at 5:16=E2=80=AFAM Andrew Burgess wrote: > > > > Simon Marchi writes: > > > > > On 3/25/24 13:20, Andrew Burgess wrote: > > >> Andrew Burgess writes: > > >> > > >>> In v3: > > >>> > > >>> - Rebased. Nasty merge conflict with 4bb20a6244b7091 which I thi= nk > > >>> I've resolved, but am unable to test. Reposting so the author = of > > >>> that other commit can validate. > > >>> > > >>> - Initial testing looks good. Full tests are still running. > > >> > > >> Testing completed with no issues. H.J. Lu confirmed that this versi= ons > > >> didn't break the x32 behaviour. I've gone ahead and pushed these > > >> patches. > > >> > > >> If anything crops up then do let me know. > > >> > > >> Thanks, > > >> Andrew > > >> > > > > > > Hi Andrew, > > > > > > I think your series introduces some build failures with Clang. One i= s > > > easy, it's a missing `-x c++` in gdbserver/Makefile.in. > > > > Thanks for fixing this one. > > > > > > > > The other is: > > > > > > CXX nat/x86-linux-tdesc-ipa.o > > > /home/smarchi/src/binutils-gdb/gdbserver/../gdb/nat/x86-linux-tde= sc.c:167:1: error: unused function 'x86_linux_i386_tdesc_feature_mask' [-We= rror,-Wunused-function] > > > 167 | x86_linux_i386_tdesc_feature_mask () > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > It's possible that this function just needs to be moved in the same > > > "#ifdef" as where it's used, but since I didn't follow your work > > > closely, I prefer to let you fix it, in case I'm missing something. > > > > Sorry for the breakage. > > > > I pushed the patch below to resolve this issue. > > > > gdbserver from your old patch: > > https://patchwork.sourceware.org/project/gdb/list/?series=3D32189 > > works on x32. But the current master gives me: > > /export/gnu/import/git/sources/gdb/gdbserver/regcache.cc:273: A > problem internal to GDBserver has been detected. > Unknown register bnd0raw requested > > again. Never mind. I was using the wrong source. x32 works. --=20 H.J.