Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Rajendra SY <rajendra.sy@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] [PR gdb/23095] Fixed test case to compile & run on FreeBSD
Date: Sat, 21 Apr 2018 03:11:00 -0000	[thread overview]
Message-ID: <CAMAnt0nkbMQ=xEo+Fv8tu9evbt1wHgU239XxWc4sNTuQ72vDKg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Problems:
1. linking -dl lib on FreeBSD platform
2. backtrace from ld-elf shows r_debug_state() instead of _dl_debug_state()

Cause:
1. There is no dl library on FreeBSD platform test has to ignore linking "-ldl"
2. The stop due to a shared library event shows backtrace frame #0
function as r_debug_state()

Test passed:
PASS: gdb.base/break-probes.exp: set stop-on-solib-events 1

gdb/ChangeLog:
2018-04-20  Rajendra SY  <rajendra.sy@gmail.com>

        PR gdb/23095
        * gdb/testsuite/gdb.base/break-probes.exp:

[-- Attachment #2: gdb-break-probes.diff --]
[-- Type: application/octet-stream, Size: 991 bytes --]

diff --git a/gdb/testsuite/gdb.base/break-probes.exp b/gdb/testsuite/gdb.base/break-probes.exp
index 22aa66171c..7dbc78e94b 100644
--- a/gdb/testsuite/gdb.base/break-probes.exp
+++ b/gdb/testsuite/gdb.base/break-probes.exp
@@ -23,7 +23,11 @@ set libname $testfile-solib
 set srcfile_lib $srcdir/$subdir/$libname.c
 set binfile_lib [standard_output_file $libname.so]
 
-set normal_bp "_dl_debug_state"
+if { [istarget "*bsd*"] } {
+  set normal_bp "r_debug_state"
+} else {
+  set normal_bp "_dl_debug_state"
+}
 set probes_bp "dl_main"
 
 if { [gdb_compile_shlib $srcfile_lib $binfile_lib \
@@ -32,8 +36,13 @@ if { [gdb_compile_shlib $srcfile_lib $binfile_lib \
     return -1
 }
 
+set lib_dl "-ldl"
+if { [istarget "*bsd*"] } {
+  set lib_dl ""
+}
+
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile \
-	  [list additional_flags=-DSHLIB_NAME=\"$binfile_lib\" libs=-ldl]] } {
+	  [list additional_flags=-DSHLIB_NAME=\"$binfile_lib\" libs=${lib_dl}]] } {
     return -1
 }
 

             reply	other threads:[~2018-04-21  3:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-21  3:11 Rajendra SY [this message]
2018-04-21 14:59 ` Simon Marchi
2018-04-22  1:31   ` Rajendra SY
2018-04-22 14:11     ` Simon Marchi
2018-04-22 15:33       ` Rajendra SY
2018-04-22 22:21         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMAnt0nkbMQ=xEo+Fv8tu9evbt1wHgU239XxWc4sNTuQ72vDKg@mail.gmail.com' \
    --to=rajendra.sy@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox